From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8F34443E92; Wed, 17 Apr 2024 15:24:16 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 60C6740E32; Wed, 17 Apr 2024 15:24:16 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2060.outbound.protection.outlook.com [40.107.220.60]) by mails.dpdk.org (Postfix) with ESMTP id 45CBC402AE for ; Wed, 17 Apr 2024 15:24:14 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oRdvi/qYLKNeBWSgtDbOdYImPfHiiUeO4JD6ppznWdvubcXH6JFgJg02S7DNmMZvHjIhp/FRXIM34W7m69PIYDkEVGSzZQlUkNdE1babo+llskXTtZHLgqR3mrOkNkUSRNHQagQ6sZkGvzaKQe772HPvM5q5BV1bze0m6WP1zLtSbjvaiuFJKkuaioiFnUK/Dq+3ejb+UNaAjtxNs3aFMg4ioBP5HKR+SCy2m6lzJomCDrGoWaE+ePpEVE54U5FO/5sfCYf9gXvA+FahSdQq/oQE13ZasuJ+ih7nQlnJoMdJHk73WPcGyJUyEuqTJT2zDjzA8D3vb+Wylet/bWFjmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FBVzvN7aypkUIAz4+9u0MS/7UPqR7VUVjDZI2Mz9XhA=; b=Ko302y5NTo8ADsBT2Pi3qkiZHZSs/jB4P6js3KdB5duzBQ7stP+RYHMvj15h6hl+XJRUZOgWid+gExZshK5I3Vyfa4bviVQjQ2ZaOcCe8Rf56/gQN/KL2xD3M6a5rG4jnyA38jnzoYFIcnBFLKWiIRETBNOv/3DAGESyO7/1DnpedAVJISKT2ZtV7gF1QzoN249MDzERGm8c4rDWx450D3102VsoHnjbdjps/JLwMj+hBn4PxpdKyvWgQarzkf9nximoixYkj8JN1+5LEddiVIYQLoBDvVnsu2u3N63lcltcBb4IHZ0oOZDPn3a3tFilQPgcv5mKtQ1lk1zVuuxMJQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FBVzvN7aypkUIAz4+9u0MS/7UPqR7VUVjDZI2Mz9XhA=; b=OXoRzopx0Dp7Ivco/OW8bUYVCTjW7dAsh4m3roeagn3VnazBjwts1Uq+LR+8H0xqOa3Ss/mft0IRD36/1kAtdHwomMKXcoXeHmD2Atr0W3UtONBqG1HicPqzmAlaRCMTact4YFGt3WwLhgvGulQ0n75/q6xPi8zQjxGYWyrPTqw= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by PH7PR12MB7258.namprd12.prod.outlook.com (2603:10b6:510:206::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7472.38; Wed, 17 Apr 2024 13:24:05 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::282f:29d3:cac1:cde3]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::282f:29d3:cac1:cde3%7]) with mapi id 15.20.7452.049; Wed, 17 Apr 2024 13:24:05 +0000 Message-ID: Date: Wed, 17 Apr 2024 14:24:00 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] drivers: remove compile-time option for IEEE 1588 From: Ferruh Yigit To: Thomas Monjalon , Ajit Khaparde Cc: dev@dpdk.org, Aman Singh , Yuying Zhang , Somnath Kotur , Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao , Hemant Agrawal , Sachin Saxena , Simei Su , Wenjun Wu , Qi Zhang , Xiao Wang , Beilei Xing , Qiming Yang , Jiawen Wu , Jian Wang , david.marchand@redhat.com, Olivier MATZ References: <20230203132810.14187-1-thomas@monjalon.net> <3062773.CbtlEUcBR6@thomas> Content-Language: en-US Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P265CA0034.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2ae::8) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|PH7PR12MB7258:EE_ X-MS-Office365-Filtering-Correlation-Id: 0ee44fec-1bfd-4f0a-3d0a-08dc5ee1a790 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wkkp6NFplHy5IArzYdyFM6sqrNBrDsAv60RdM3CkcLun7X9lMiblBr9NFf2AIvRB1w3NKjjzvIGr7yhQPM76KDh//R8fq8FOTH3kg0P900MXhNKnzSn+vXGxrOG6QmUYnrhVT1V4YTioMdXUblTjiHAw+3X8KXgNDvCzOpZZm+nBTu8qSbqb+8sxWBvAuaqA+ymr15GWIKOuvCIOzdn7QZLdgeDemTVnMeBx0HFfvYjEK9yxulhSsuRsKQC55h9V2nS4Z1i30iXruK3357+WAbPzn7s9ETW2+4DsqTeeCX82foGIkgm1SD5VBrf2OWh1Xr77JNS1a9ux/+1P0+hirAh2yhv9GyLURrxBKi81l+nth4ExIY/GC0diQis0A8aBzIXInyIaW2Khk2NaKklgO2hQAciL5K/KPzNK7WTVaM1sHC81F3RNRSlmNjDiew2Q5SFRUta7tfjv87u/LBbEGvaLYslLj4+JK9+VX19G9kggwJnF+d4OPiPywZMjdBqWrYrjjmq18A1OVx5xvlvkfcxCHDnzXyUHnadplSOGh74fe0GuZl+MIknanVQci1e8xXKzbGpGPi3hwXx47SLYcOFnHXYOJWxEFDDTd8TDi4flZ+ByLT+oHELQ0mZxC0skIB8rsSwPaNwngAP+DMdjHYDTyn3JBdzOh2KPRy1a6MA= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366007)(7416005)(376005)(1800799015); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c3V4T0RDajZqbEdaZUsrYlAwdHlUd1RmbUdKKzhXUTN5NUxDUGpIaG94YXR6?= =?utf-8?B?ZHhYNkVTbHJjU2lzRUJxUWNiM01LM2twa2FubzRpc3NuM1ltOHJxTnJ2ME4r?= =?utf-8?B?L29CWmJnSStHQ0VkOUYzaHFMRHJqK3RpQ2NGa3BpbFVpRG9STkkwemwvZmY5?= =?utf-8?B?RjM0MFl6VlhqVk5KU0tJTmtOK0kyelZ0UitHT3hKeHF0VXJSa08wbk1KVHdj?= =?utf-8?B?T0xxc1NybnVhN3hBbkVIc1JvSWJRS2Z3SFkzSGRnc1pubVhzT0hhNFVOdldp?= =?utf-8?B?Rk5LZnpnS1BUM0lMVnBaNWdBNVhoOUk5bk1VT1JsOXJVK2Y2Yi93R1NmQzNT?= =?utf-8?B?bU9iVnF6dG9TOHRuTXBicklwWnNHM1cyZVFPTWI0cDJGR2I4SldiVmJYSVNq?= =?utf-8?B?N0Nud296R2ZqM0ZzbnRTYzNmZzEwRWdWNXJqd3RrdmZQU1FlVjVYVVpoSllT?= =?utf-8?B?SEZLcnJEK3k3WVE5bWRPQkhuOGhnVEk1b05JclhlNkZ2STllZnVTRWZNWmpZ?= =?utf-8?B?YXpQVThmS3lJb00xcWJPZVpZUWhqZWhSREdvMEE3aHVhVmlHNDRhUU1oazRE?= =?utf-8?B?YXZnRDh0T3hvZWJjSDUwQlA4eXV4RzVNZ3BrQ0s4L1BpbXM5WTYvcHhUWndn?= =?utf-8?B?R1ZUNTBZWEorSitoRDVlalc5N2VXaW9nS1Q2dFdOL2gvSjRIM2RPV3Avclgv?= =?utf-8?B?RjVGN3VYczJWZUZHNldPYmoyZHlYTmV1b1I1ZDgvTGc4R1pqMFp5aFJ2VVM5?= =?utf-8?B?eGFQS0VqMnVMSnhHRmNOdWo3NzRPblB4ZlZ2NzNscEpaaHdPZ3BhTzJSVjFy?= =?utf-8?B?N0ZyVk1NTWlrR1JVbVVHRTFFbm8xK3hqbkZNU2pMdHJYOXZscTZZdmRMa2tD?= =?utf-8?B?T05WUmxPYWFwL295bWFVVjFzd3hQMHlmZlhzY2o3N1BZemFXTWVPbmFqQWV3?= =?utf-8?B?WmRHZEsyR2R4ZkY5cFREdXZEdFNWamlla2hmNlVnVjJEMDBFdHllbzB4emNx?= =?utf-8?B?UWZpa3BBMUoyb0NkdE9xaXFGNm9kTnpGbHE3OWliMDFLU21tUjhKb3F4bVBn?= =?utf-8?B?S3N4dUVCYXdxRTdkZU5JZ1I4ZmlvVGNsbC90NHh3RmYzOWx4L3R0bHBPa3ZP?= =?utf-8?B?a3ZhcUM0UTAwb0FCUmJRY3IyUTRIN2pvZG5WU0QvR1c5MXY4UGx5QjU1bW9D?= =?utf-8?B?T1prNGN4SGFpL0dPcVYxMkJDTEJFeFArQWZMdXRjYng1VHAyZndPMlhLY1pV?= =?utf-8?B?Rmo0Y1FFZllvNTZmbXZ5dGU3RVZsZWtYdElIOHJaWGoydkxNcG1UQlRzRlZD?= =?utf-8?B?ODhXdmFEcjJwWnh1QlZxOUpFUlpUR0FDNlBsbUlzMmFKaGplQ0dsSStJOUFj?= =?utf-8?B?MnR5Mi91R1EyOWFWNFBJdEZ1Wm1TKzY4SWV0bXNBRFBpdFhncEZBZW1odmxo?= =?utf-8?B?OVVheXJab1lBWnZvY1ZEN3dsYUZuQnNYaWVpalNKemliNVo4cGdUSVVoVFZ2?= =?utf-8?B?MUR3VXNOWHFmN3JFdm9zRW5xNkl1RjVVUUd2UE5CRlpnanNFMEluTm81QU8v?= =?utf-8?B?emxDaHo5VlpGcHFBdElHMTBUbGtWdmlyNVhrSGtSSTFvaW1DVFF2ZDRiQ04z?= =?utf-8?B?WE0yam1jNWNQZ3BSUUdhbVNSZXljamhjNTRMWEdjaFpsOS9HVlowL1hWUWRF?= =?utf-8?B?bkFvc1U5NjlUUnpEMWM0YUw2MjY4VXZ1RU41cEh1SXk0YkdFekF1RUNGTzdz?= =?utf-8?B?aHhPSDFBay9Pc3hqS3EyOEdxQmo4c0VoQ0wrUmpBclJtWFNpN3J6NHB2TjJS?= =?utf-8?B?dnltT1JPUWlhNHRWaDJXL2hHREZLRUFzYVUremlOR2dBRXhOQ1FSMmV0bGxq?= =?utf-8?B?WVMxZ3MrcWl4dngrZkRJaG5xS2cxUm01aEhGbjdVV0tjSTI5R204Sm1WOHZR?= =?utf-8?B?ODdoRnVVcS9zQUhTVFdSdDgrNzZFNkF6WWtTMitwTnVrQTRHUVRDMTU5UERq?= =?utf-8?B?UkZzMEhhait1SEZ2UEd3L2JUTFhWek5YejFpU1MxalZ5UmJOMFFtMmFtd0lr?= =?utf-8?B?ZU9SYjNvK2RseUtWbkl2WG4wOFl4WUxBVGUzZGJqQjdycFV5Z2xiYUl3TFNy?= =?utf-8?Q?k3yoHXFjppyH35tfj/LDkFVF9?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0ee44fec-1bfd-4f0a-3d0a-08dc5ee1a790 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Apr 2024 13:24:05.4091 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: PR4MU8FfEcucPtSU/G2qbNH3BXcapiquZ0iITqSVFkdpfIgYy4M8SrsASbGalBLG X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB7258 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11/3/2023 12:08 AM, Ferruh Yigit wrote: > On 11/2/2023 10:17 PM, Thomas Monjalon wrote: >> 02/11/2023 22:21, Ajit Khaparde: >>> On Thu, Nov 2, 2023 at 2:13 PM Ferruh Yigit wrote: >>>> On 6/25/2023 4:45 PM, Thomas Monjalon wrote: >>>>> 23/06/2023 16:00, Ferruh Yigit: >>>>>> On 2/3/2023 1:28 PM, Thomas Monjalon wrote: >>>>>>> The option RTE_LIBRTE_IEEE1588 has no effect on any library >>>>>>> unlike its name. >>>>>>> >>>>>>> Also we are suppose to enable/disable features dynamically, >>>>>>> not at compilation time. >>>>>>> >>>>>>> And the best is that this macro is neither documented, >>>>>>> nor in rte_config.h. >>>>>>> >>>>>>> It looks to be a mistake keeping this flag, so it is removed, >>>>>>> meaning always enabled. >>>>>>> PS: it is disabling vector paths of some drivers. >>>>>>> >>>>>> >>>>>> PTP (IEEE1588) processing brings additional overhead to datapath. >>>>>> >>>>>> Agree that it is not good to have undocumented compile macro, but just >>>>>> removing it may cause performance degradation. >>>>>> >>>>>> It may be possible to have separate burst function that supports PTP and >>>>>> driver configures it when application explicitly request it with a new >>>>>> offload flag (although it is not exactly an offload), what do you think? >>>>> >>>>> The best is to enable dynamically with different functions. >>>> >>>> There was no comment from driver maintainers. >> >> If I made a baby when sending this patch, it would be a birth today. >> Isn't it enough time to warn maintainers? >> >>>> Perhaps better option is plan flag removal and execute it, like to >>>> remove the flag in 24.11 LTS, this gives enough time for drivers to update. >> >> You want to give time for one more baby? >> >>>> If this sounds good, I can send a deprecation notice to record this plan. >>> +1 >> >> Which plan? 2 babies? >> >> > > :) remove compile flag in 24.11 LTS. > > But we may end up in same situation in 24.11, some drivers not being > ready, so we should merge this patch very early in the 24.11 to give > time to drivers to fix if they were not ready at that time. > > Other option is merge this patch in 24.07, so that vendors which were > not ready can plan a fix for 24.11? Although enforcing an update by > breaking the driver is not best planning, it may be an efficient one. > Hi Thomas and et al. , Is is good time to merge this patch, there is enough time to fix potential issues in this release, what do you think?