From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6F7AAA0550; Mon, 21 Nov 2022 14:52:42 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2C44A41144; Mon, 21 Nov 2022 14:52:42 +0100 (CET) Received: from mail-qv1-f49.google.com (mail-qv1-f49.google.com [209.85.219.49]) by mails.dpdk.org (Postfix) with ESMTP id A63DA400EF for ; Mon, 21 Nov 2022 14:52:40 +0100 (CET) Received: by mail-qv1-f49.google.com with SMTP id d13so2300526qvj.8 for ; Mon, 21 Nov 2022 05:52:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=xk7uaNUDCS8JWLvcAN/GeFiCBdMk0Y1uhVHHpPiXUhw=; b=YQrY7zcdBxcXJbfg+QiQZToxdjgcNOTqo2N/rqacsQT7EECTwO+A8Qf7KgYuNAqCt1 fbQh86V7vlu/XfzDWD9j6ez/0qjhNolPJT7Hm4xCDDXvjeWkd9FHcULbktyK/tYzzG45 aKaRK9Z6Xn73GZaFalgQNUGnDFcBXcoiT59vjE8C/YwnAuJ6Do3qQ/o6mo2ZYfuUIpcR W2Ay+7ZQ2b9nAOXk6J/kOBqgS3YkHVAuZA/h/w25nDZLoLIApyeezXXQRRgppNaBvNEl gRfE54YF/yfQ7slFfY0VN16Jfjl/HqGE1bwlLMW8PPz69X8tSfDkurgV0kmJkRrAf/3i v8tA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xk7uaNUDCS8JWLvcAN/GeFiCBdMk0Y1uhVHHpPiXUhw=; b=RL8dsCXqm2tR3dAggJuTlzrqJf2dXAoDnPpZ6rI+tXEslTQQKTxoIQrs8oE2/m2hZC TvyKvzwcQdSSeE/wxBEjkpuZG/m5X/ndQYchDhEUB6I9zEMSs1nU/El8MVvBZA276ZqK GsyCV15Xc4o8ZBfxfnD2fXAGWI10EZzZZLSwG8h2UAQA1fqX41RjkUpY34G5hedKWmx/ Di6UYKrZbSqgMr84Pg1fm2X8cWzybq/oCLEL8j2lYtRoARbmoxGkMGWLPxfJ9tK/aNmn 5CZUwJy1hyH2iF+Xbw1pHBwIRFTbeF4hGA1mVFAU3Jil8YRgYFxYDMPxn0QUOpMkf5dI q4XA== X-Gm-Message-State: ANoB5pkUBcvPa2hN44DByYti//8seCg61BWZn7g95msc09TrQ6q7hZ21 jkUn+P6YKHPMHGFDfz2yUTo= X-Google-Smtp-Source: AA0mqf741OUDdI3W8HtE2Ey6Z9O+uy8aKcTlwGuob1vyT78GNRHBIoZNK6QZpYdrAXjF54wolWBInw== X-Received: by 2002:ad4:5223:0:b0:4bb:59c1:3dec with SMTP id r3-20020ad45223000000b004bb59c13decmr17440311qvq.39.1669038760015; Mon, 21 Nov 2022 05:52:40 -0800 (PST) Received: from [10.249.157.237] (nat-216-240-30-25.netapp.com. [216.240.30.25]) by smtp.gmail.com with ESMTPSA id c12-20020ac8054c000000b003995f6513b9sm6562176qth.95.2022.11.21.05.52.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Nov 2022 05:52:39 -0800 (PST) Message-ID: Date: Mon, 21 Nov 2022 13:52:36 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [EXT] [dpdk-dev v6] doc: support IPsec Multi-buffer lib v1.3 Content-Language: en-US To: Akhil Goyal , Kai Ji , "dev@dpdk.org" Cc: Pablo de Lara References: <20221116120629.56634-1-kai.ji@intel.com> <20221117121618.50924-1-kai.ji@intel.com> <3cbd7396-c5f1-4d5b-79ff-2b635123a1ed@gmail.com> From: "Zhang, Fan" In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Akhil, Agreed. Thanks for clarification. Regards, Fan On 11/21/2022 11:35 AM, Akhil Goyal wrote: > Hi Fan, >> Hi Akhil, >> >> >> From 22.11 the ipsec-mb PMDs will be working on two different libraries >> that may or may not work the same. >> >> We also have two different contributor groups working on adding features >> on top of each library, again one may or may not be compatible to another. >> >> I believe there should be some words necessary to distinguish each >> library support as well as the credits for adding certain features for >> one platform. > Ok, but release notes is not a correct place to mention that. > It should be part of the respective driver documentation. > >> >> On 11/21/2022 6:57 AM, Akhil Goyal wrote: >>>> diff --git a/doc/guides/rel_notes/release_22_11.rst >>>> b/doc/guides/rel_notes/release_22_11.rst >>>> index 4e55b543ef..b98b603fe7 100644 >>>> --- a/doc/guides/rel_notes/release_22_11.rst >>>> +++ b/doc/guides/rel_notes/release_22_11.rst >>>> @@ -240,7 +240,16 @@ New Features >>>> >>>> * **Updated ipsec_mb crypto driver.** >>>> >>>> - Added SNOW-3G and ZUC support for ARM platform. >>>> + * Added ARM64 port of ipsec-mb library support and SNOW-3G and ZUC >>>> + support for ARM platform. >>> You need not update the above line. >>> * Added SNOW-3G and ZUC support for ARM platform. >>> Should be good enough. >>>> + * Added Intel IPsec MB v1.3 library support for x86 platform, >>>> + see the following guides for more details: >>>> + :doc:`../cryptodevs/aesni_gcm` >>>> + :doc:`../cryptodevs/aesni_mb` >>>> + :doc:`../cryptodevs/chacha20_poly1305` >>>> + :doc:`../cryptodevs/kasumi` >>>> + :doc:`../cryptodevs/snow3g` >>>> + :doc:`../cryptodevs/zuc` >>> I believe adding reference for each guide is not needed. >>> >>> * Added Intel IPsec MB v1.3 library support for x86 platform. >>> Added details in the guides for all the drivers supported by ipsec_mb. >> What the guideline Pablo/Kai added here only applies for x86 as >> >> a. ARM does not support algorithms other than SNOW3G and ZUC. > This should be distinguished in the .rst file. > For release notes, above thing is sufficient. > >> b. The performance guideline may not apply to ARM. > Again, it should be part of driver documentation and not release notes. > > And for each of the release note bullet that I suggested are mentioning the > Platform on which the support is added. > >