From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D5BC9440B7; Fri, 31 May 2024 18:44:36 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C182440C35; Fri, 31 May 2024 18:44:36 +0200 (CEST) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mails.dpdk.org (Postfix) with ESMTP id 584EA402D0 for ; Fri, 31 May 2024 18:44:35 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 20F2C1063; Fri, 31 May 2024 09:44:59 -0700 (PDT) Received: from [10.1.39.25] (FVFG51LCQ05N.cambridge.arm.com [10.1.39.25]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 66DBB3F792; Fri, 31 May 2024 09:44:33 -0700 (PDT) Message-ID: Date: Fri, 31 May 2024 17:44:31 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH v2] dts: skip test cases based on capabilities Content-Language: en-GB To: =?UTF-8?Q?Juraj_Linke=C5=A1?= , thomas@monjalon.net, Honnappa.Nagarahalli@arm.com, jspewock@iol.unh.edu, probb@iol.unh.edu, paul.szczepanek@arm.com, npratte@iol.unh.edu Cc: dev@dpdk.org References: <20240301155416.96960-1-juraj.linkes@pantheon.tech> <20240411084829.64984-1-juraj.linkes@pantheon.tech> From: Luca Vizzarro In-Reply-To: <20240411084829.64984-1-juraj.linkes@pantheon.tech> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi again Juraj, sorry for yet another comment! On 11/04/2024 09:48, Juraj Linkeš wrote: > + def get_capas_rxq( > + self, supported_capabilities: MutableSet, unsupported_capabilities: MutableSet > + ) -> None: > + """Get all rxq capabilities and divide them into supported and unsupported. > + > + Args: > + supported_capabilities: A set where capabilities which are supported will be stored. > + unsupported_capabilities: A set where capabilities which are > + not supported will be stored. > + """ > + self._logger.debug("Getting rxq capabilities.") > + command = "show rxq info 0 0" In my testing of Jeremy's patches which depend on this one ("Add second scatter test case"), I've discovered that the Intel E810-C NIC I am using to test does not automatically show "RX scattered packets: on". But I've noticed it does if the MTU is set to something big like 9000. I've tested a change of this by adding: self.set_port_mtu(0, 9000) > + rxq_info = self.send_command(command) self.set_port_mtu(1, 9000) And it seems to work alright. I've also tested this specific change with Mellanox NICs and it didn't seem to affect them at all. No errors or problems and they still showed "RX scattered packets: off" as expected. The `set_port_mtu` method comes from Jeremy's patch... > + for line in rxq_info.split("\n"): > + bare_line = line.strip() > + if bare_line.startswith("RX scattered packets:"): > + if bare_line.endswith("on"): > + supported_capabilities.add(NicCapability.scattered_rx) > + else: > + unsupported_capabilities.add(NicCapability.scattered_rx)