From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BAF27A00C3; Tue, 1 Feb 2022 15:11:12 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 534C940698; Tue, 1 Feb 2022 15:11:12 +0100 (CET) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 8422E40691 for ; Tue, 1 Feb 2022 15:11:10 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1643724670; x=1675260670; h=message-id:date:to:cc:references:from:subject: in-reply-to:content-transfer-encoding:mime-version; bh=gVgIa6UYFUfrgcqh2tiDKynEoyfFi50+pfoms7dFe2o=; b=SyLeBdYJ7MCNKJ9jvlKBBRu6NY/xJvOClZ8gSga6ZlP1j7OvY40mGqZ1 xhzJzmRh8aKrdw3Z3uXy4HH2bLXUgQNGqcRiLC9hrCvKpxRqA1u2HtGEf lC5LtjuU22/SpOH8VfUv07TYvxiAmohYx9Bzp5OjubghtyLHpDx8VDN0H CsQgEZCCNqNVE7Tpl19fLIXQY1mZAGs8YpQLI5fXFPoZ7e3/Dfatn6WBA Osrph7P7uW5h8/zcbE58bI+eiyQfSpZV2HswKNdnwEiX6Aty3i4GGVWBI /1nnMygvzX5vT1Cg0lVr+Jfh+lI6IiPSrqYLpeWl4zOQsqDxGCQiICqlW g==; X-IronPort-AV: E=McAfee;i="6200,9189,10244"; a="245288558" X-IronPort-AV: E=Sophos;i="5.88,334,1635231600"; d="scan'208";a="245288558" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Feb 2022 06:11:09 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,334,1635231600"; d="scan'208";a="565599700" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga001.jf.intel.com with ESMTP; 01 Feb 2022 06:11:08 -0800 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 1 Feb 2022 06:11:08 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Tue, 1 Feb 2022 06:11:08 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.170) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Tue, 1 Feb 2022 06:11:08 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BBjkOdsiiE/Yym2Vh1FkZfvXvmLbwFvR7oa/GUlk+Du/liz8RoYOl1X14nB7sijoBx+Ygbl8+Fv+rePYlfv06jaMMEhQKK5npLs8lTPvy1CUCmVcW72lyvO3Tcq3cicNI8HHdTkewSkQak22DVY5Hhyp15BneLbibfWJn8WdDvPDLgJa1d9xSIbodF8vdQMK9eqPwstolXwA/mnZ1MVGHbgBnJ5t4wb1ImANr/X54n8RIhN/3yyk0CwL2NGH8ViiyIDz6IuViiNj+lqfUKd7K1AxlnY62lmuAQYOTOxzeHTYNfesvhLXjHEWgztZFHHUnYnXIh55etypbU79cZW5bA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oatq7P6xrAk3gWPGh546oJ1C0xyC+lMTzQliB2YU6r0=; b=h1iR9oK/zav2u/iJig3DvNuc47g9POCJnWLP9IrSJDiNhW1qNKQXC8kL1GwPNm2J8uwZo26bEnCWK/ni1ZcGv+CkNHYi6dAdqssNmk9P3oY7319Fp4ZcYCg6IdjrZOT1yZoJ/myXm1X4vu2OxK4tgP17cHQG9tknPmn/hdpub0YXnZJSVehUZX1EDN8g7IkWNO8HFqJ26qVwS1WzDVYita4m64r+/d83WdgQNwAl6jeIVKgG/MDL0d0gmCHWhubF3o3DY4wcsTw4uLUNX3uGDu2DdN3UvztVuZ6i9+MWhjJfpdZRT1alhgPLxKPpLRsKC/0+cMEiJErcTQLSdw7JDw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by BL0PR11MB3073.namprd11.prod.outlook.com (2603:10b6:208:7c::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4930.15; Tue, 1 Feb 2022 14:11:06 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::5046:8550:928d:850e]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::5046:8550:928d:850e%7]) with mapi id 15.20.4930.022; Tue, 1 Feb 2022 14:11:06 +0000 Message-ID: Date: Tue, 1 Feb 2022 14:10:58 +0000 Content-Language: en-US To: Akhil Goyal , CC: , , , , , , , , References: <20220120162627.4155695-1-gakhil@marvell.com> <20220130175935.1947730-1-gakhil@marvell.com> From: Ferruh Yigit Subject: Re: [PATCH v3 0/4] ethdev: introduce IP reassembly offload X-User: ferruhy In-Reply-To: <20220130175935.1947730-1-gakhil@marvell.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0212.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a5::19) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a58603fd-380a-418e-3d1a-08d9e58cafe0 X-MS-TrafficTypeDiagnostic: BL0PR11MB3073:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: SUSsRChkuwzbpHtG1VKCUSCIA1iKNR+Wi+98MbW3k8Qq1X702Pqh0/LsEWiFdhRA4aUtNDP2ZtkLsQbWWX67d4hY7tIrh+qGKf7X6mPOmD6cxk6naWJru1a3OgVYQV0tJ1XaAGPPDU2ZUwIvE2S+X57uRsv6azNGEEUFpw9z1Ox3niog92NqWxlyNUTu54SPQAtrNfI6HzqkOn7ZiVXQKuCvSD8ttS7Lgk1u6BUVGxVBz2kD6kJsA+X/xBg2IWLa6Kz31yxS7YA0dl0nC66BEk1HLuVfnZs1oYFN09evdpEqsw+4+Y5Ek30bPlHMp2Q8Ya4zukImhRABulRAcIiaw+Xw7jMKNa1ltTZiTbkc4AwpE0V2AD/yg9A20/7CzeqoJKWHb5ekJu64PLhrXhZjKdS7PutJLDOJ5SG8fHIK2r+RBhQ9uxI7bFnCDvkeRcvc7tB7y9vEB2va0LDVqVpDsUEES4p8rrgD9J9Q7fbKIKxY2gCTHlHx9roCtOGciH/H6Uo50dwzLTLtiC/pHX47HR889FI1Wo/3cq7/G9Q6chHjDJI/aTdmpEht9yfNMQSgP8p05kSTjc2xOo2Ze0MOSYSaDQ7NA6xP4ACngzzEI82ikPb8R1edsh3n34mJrO1C21Bh+5nBiLC7Q6bAPnbBADgtdYTzYY7DsrjVL6LScyqhw3ln5SstHnKHBEdBa6CBE4At623mlxieojHtG/cIBAoQ1ZEG1r/QyIawIU5JHCy0GwHPrieYD3KWmHbvNtHYiP7kYFNHhr4pMq4KH4nupF3CvfICu8M2yuE8QRRxTl4= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(66946007)(31686004)(966005)(6486002)(31696002)(44832011)(2906002)(82960400001)(5660300002)(316002)(36756003)(6512007)(86362001)(38100700002)(8676002)(8936002)(4326008)(186003)(2616005)(6506007)(6666004)(26005)(66476007)(83380400001)(508600001)(53546011)(55236004)(66556008)(45980500001)(20210929001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YTk3UDE2UDNQYWNyaG03UHBmYzlCOHo0VUtKckJTdDZwMCtGL0dCakVIUVRm?= =?utf-8?B?OGNYUFpZeVE4eVFrQk4rOUdEaHZyZGRLZTFWVEI0RVNiYzF5T21BdEJnejdJ?= =?utf-8?B?SUFESnhicGh4V0JkazFUOE9ZM1QzR3pwU0tnSk41MzZjaDdqak8xTDNNZVpx?= =?utf-8?B?NEQ0ZFpwSmIxYW1HZWM1M1Z6SWMrWFRueUkvVXJ2WitaSDBIb0ZuVGNDdXR6?= =?utf-8?B?bXh2L1RodktES3B3Y3VDZDRmWFRKV1YvMjFwMVhOOEIreWc2Q1c3eGdja1hS?= =?utf-8?B?dFRaQ2tTT0pUZFkwdENIN0VNMFIyWG16Wm0ralA2a1ZzdDFBSUNHNzE5SlAz?= =?utf-8?B?dE1Kb0w3SWhCemYvQ2ttbjFHWVRZaDN2L1ZoYVlBb01Vd21qaHFvbEVnZzBn?= =?utf-8?B?cHc1TXBtL2hkaVBPRllTaUZud2svUkMwTHpNUHpMTVJWaXFlbVI5RUlhRUV5?= =?utf-8?B?RXhMbXVwNW0wdjkvb2dsT3d5NDZYTktETlZnZ0RiY09YdWlPZlVteGtNc1Fw?= =?utf-8?B?T0xXa2FvTVNEVUltakJVYkltUXdITXE0WjRzd1VoMFB4RWlob0l0VVIwYmZL?= =?utf-8?B?RDFic3JHZVBJRElneEErYmFpaGJHVDA1WEk0UDdSOVdLNUwyZ3BhY2hVWU55?= =?utf-8?B?c3EyWm1qZ2ZCTkNvVjU2ZkN5NFRqUGJER2YycVdUbkVIM2JjdVowZEU5ZG5r?= =?utf-8?B?WXRxSHB6R1NYcGRPTE9FTlZSbWhqVDNBZkdIZEtUTkk2YmVqdUh4U3VNc2xs?= =?utf-8?B?ZDRaWng1MUdGb2NlaStDa1QyWE5YT21pK1BpSVBlUkJHaUhzaHgxTE9lL2Jl?= =?utf-8?B?Q3N4ZmJKTU9kNkVrUUNnVWxMZ3FEU000SVlkVlBDVjhpUWdRN0srbnkzaXZR?= =?utf-8?B?OGJvQy9KTG5VbU41aFhVYlZ1UHdtSzR4RTBMNjVSNkRXdy9haDdxVDRmaGVq?= =?utf-8?B?aHU3NDRJUEY4b1BJUkVoTHNSTGwyRVpOc2hoUjhSQjJBSHEreXd2Uk15MDJG?= =?utf-8?B?QWFCVHdFWjAwVFFRU3RCRDhCd0VyazFrRGZBY3pIcTFXaUVKUFFXMFhNWlpD?= =?utf-8?B?Zm95RGpscE9GVm9oZnRMYUYxQ2pHaThJUUdOK0JNdEcwSDVGQXVrZXE1V0ky?= =?utf-8?B?QW5nM3R5YnJGakxnZ1IzQm50Si9PT1V4bVhUa3lYbW9PTjFsTWpIZUxxWG1j?= =?utf-8?B?NE1SQ3F3OGFYUzlObExWV210aC9rakZ3amZQQjQ2VnIyMlNQclY4UWhOMjJr?= =?utf-8?B?ZHZVeE1EK0YrK2dxMnczNlpzMGh3eGxoZDFGL2xjUUg5c0VYL0lzVW1xRWhR?= =?utf-8?B?TzF2VEsvZHNuL2xaaEFSV1JBNENacjlWK21DaGorMXBaS2dzOEdwUytPbEpl?= =?utf-8?B?eXhvbGVlVTFmV3hKa0g0eGkzQjQ0d0RrLzdqd3VkR2xld3lsSjJpVExPT0U5?= =?utf-8?B?aUZqd09lYSt5MmtIQlRnMlhobG4yTkw5RXBoa3U0VytiMmVNVmNkb3k1YjFz?= =?utf-8?B?VmJVT2ZhOUhVMjFPS3gxWFdIME9tODJXN3RjaHBTQUN6bnhBWFVnL2FhZDBP?= =?utf-8?B?eGxyS21NUDNjeEptWWdpUGxmTmpyM2tKbVRsYkFrSldmSEdEenRSTUVBNGFJ?= =?utf-8?B?Wkg2SkF0NFNGRHA1L0V4UnZuK3gxcjZkU05QeGZkWldzNlBZWGdrRVJKUVVN?= =?utf-8?B?NjlGdEFzdU52NzB0Q0xFcHQwS3B3MlZvZEE1Y0ZTRERMZ0trYUpxUU1VMnFs?= =?utf-8?B?c1ZUZEdvbjlBbmxNbWI2ZFoySS9ORUtBV0VKWGRhMVlwQ3F2V1ZWLzJCRDJj?= =?utf-8?B?SmFqVzU3WGsyV1c5OXByN2hMS0N1ZFdIdGNGaGJmcUxaaElpdGVHcEVkOUNH?= =?utf-8?B?VDRPa2NBRlU5SUFBb21UcXpkUVZYSm5reE9mVTF5Vk9CZjFYek5rVWRKMElW?= =?utf-8?B?QWkzV3ZLWlM5MEgxT3U4MjNEcjNyUFFNTFR5aTRFV1FCRDE4Z0pqZ2gzZXdW?= =?utf-8?B?NUFNUnpWSzZsMnAreGhDTlFSeTJqTG83TUlMZ2g2R3F3SlNXbWdkTmdkN2pL?= =?utf-8?B?TnVBNThncGNpMW5QMi9BVFdKV0FGZkNTdVczNTdjbjNtc1J0WWg4cmxWZ0dj?= =?utf-8?B?djd5cEZYcEZLUzVHR2pIbGwrcWI1dHpZeDQzanZkeUMyTW02V0xyTDZNY21W?= =?utf-8?Q?5x9SAWlE6+j6octbYepBuek=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: a58603fd-380a-418e-3d1a-08d9e58cafe0 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Feb 2022 14:11:06.1963 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0IUAoNfa13jnS/ZvHho1TM20pIqgdsUldEzxQXS6tV4QiIzmkepg+huMOHy9dCAxD6jsG7n8Ex7U3bI44mVwHg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR11MB3073 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 1/30/2022 5:59 PM, Akhil Goyal wrote: > As discussed in the RFC[1] sent in 21.11, a new offload is > introduced in ethdev for IP reassembly. > > This patchset add the IP reassembly RX offload. > Currently, the offload is tested along with inline IPsec processing. > It can also be updated as a standalone offload without IPsec, if there > are some hardware available to test it. > The patchset is tested on cnxk platform. The driver implementation > and a test app are added as separate patchsets.> Can you please share the links of those sets? > [1]: http://patches.dpdk.org/project/dpdk/patch/20210823100259.1619886-1-gakhil@marvell.com/ > > changes in v3: > - incorporated comments from Andrew and Stephen Hemminger > > changes in v2: > - added abi ignore exceptions for modifications in reserved fields. > Added a crude way to subside the rte_security and rte_ipsec ABI issue. > Please suggest a better way. > - incorporated Konstantin's comment for extra checks in new API > introduced. > - converted static mbuf ol_flag to mbuf dynflag (Konstantin) > - added a get API for reassembly configuration (Konstantin) > - Fixed checkpatch issues. > - Dynfield is NOT split into 2 parts as it would cause an extra fetch in > case of IP reassembly failure. > - Application patches are split into a separate series. > > > Akhil Goyal (4): > ethdev: introduce IP reassembly offload > ethdev: add dev op to set/get IP reassembly configuration > ethdev: add mbuf dynfield for incomplete IP reassembly > security: add IPsec option for IP reassembly > > devtools/libabigail.abignore | 19 ++++++ > doc/guides/nics/features.rst | 12 ++++ > lib/ethdev/ethdev_driver.h | 45 +++++++++++++++ > lib/ethdev/rte_ethdev.c | 109 +++++++++++++++++++++++++++++++++++ > lib/ethdev/rte_ethdev.h | 100 +++++++++++++++++++++++++++++++- > lib/ethdev/version.map | 5 ++ > lib/security/rte_security.h | 12 +++- > 7 files changed, 300 insertions(+), 2 deletions(-) >