From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: "Zhang, RobinX" <robinx.zhang@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Xing, Beilei" <beilei.xing@intel.com>,
"Guo, Junfeng" <junfeng.guo@intel.com>,
"Yang, SteveX" <stevex.yang@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: upgrade AQ command of MAC/VLAN remove
Date: Wed, 13 Oct 2021 02:21:24 +0000 [thread overview]
Message-ID: <d4fdd4014522467faaf0b49bf07d3b1d@intel.com> (raw)
In-Reply-To: <20211011081248.4108-1-robinx.zhang@intel.com>
> -----Original Message-----
> From: Zhang, RobinX <robinx.zhang@intel.com>
> Sent: Monday, October 11, 2021 4:13 PM
> To: dev@dpdk.org
> Cc: Xing, Beilei <beilei.xing@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>;
> Guo, Junfeng <junfeng.guo@intel.com>; Yang, SteveX
> <stevex.yang@intel.com>; Zhang, RobinX <robinx.zhang@intel.com>
> Subject: [PATCH v2] net/i40e: upgrade AQ command of MAC/VLAN remove
>
> Firmware will return I40E_AQ_RC_ENOENT when try to delete non-existent
Better to add firmware version it should be 8.4+
> MAC/VLAN addresses from the HW filtering, this should not be considered as
> an Admin Queue error. But in i40e_asq_send_command, it will return
> I40E_ERR_ADMIN_QUEUE_ERROR if the return value of Admin Queue
> command processed by Firmware is not I40E_AQ_RC_OK or
> I40E_AQ_RC_EBUSY.
>
> Use i40e_aq_remove_macvlan_v2 instead so that we can get the
> corresponding Admin Queue status, and not report as an error in DPDK when
> Firmware return I40E_AQ_RC_ENOENT.
and it will not break with a old firmware
>
> Signed-off-by: Robin Zhang <robinx.zhang@intel.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Applied to dpdk-next-net-intel after refine the commit log.
Thanks
Qi
prev parent reply other threads:[~2021-10-13 2:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-28 8:40 [dpdk-dev] [PATCH] net/i40e: fix remove MAC/VLAN addresses error Robin Zhang
2021-09-28 9:53 ` Kevin Traynor
2021-09-28 10:36 ` Zhang, RobinX
2021-10-09 9:21 ` Zhang, Qi Z
2021-10-11 8:12 ` [dpdk-dev] [PATCH v2] net/i40e: upgrade AQ command of MAC/VLAN remove Robin Zhang
2021-10-13 2:21 ` Zhang, Qi Z [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d4fdd4014522467faaf0b49bf07d3b1d@intel.com \
--to=qi.z.zhang@intel.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=junfeng.guo@intel.com \
--cc=robinx.zhang@intel.com \
--cc=stevex.yang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).