From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6CB1DA0C4D; Wed, 13 Oct 2021 04:21:30 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0E1F340150; Wed, 13 Oct 2021 04:21:30 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 7548A40142 for ; Wed, 13 Oct 2021 04:21:28 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10135"; a="227222418" X-IronPort-AV: E=Sophos;i="5.85,369,1624345200"; d="scan'208";a="227222418" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Oct 2021 19:21:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,369,1624345200"; d="scan'208";a="486709912" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga007.fm.intel.com with ESMTP; 12 Oct 2021 19:21:27 -0700 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 12 Oct 2021 19:21:26 -0700 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by SHSMSX601.ccr.corp.intel.com (10.109.6.141) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 13 Oct 2021 10:21:24 +0800 Received: from shsmsx601.ccr.corp.intel.com ([10.109.6.141]) by SHSMSX601.ccr.corp.intel.com ([10.109.6.141]) with mapi id 15.01.2242.012; Wed, 13 Oct 2021 10:21:24 +0800 From: "Zhang, Qi Z" To: "Zhang, RobinX" , "dev@dpdk.org" CC: "Xing, Beilei" , "Guo, Junfeng" , "Yang, SteveX" Thread-Topic: [PATCH v2] net/i40e: upgrade AQ command of MAC/VLAN remove Thread-Index: AQHXvnnHYrjbPwH0m0uY1QG6m6LJl6vQNB/Q Date: Wed, 13 Oct 2021 02:21:24 +0000 Message-ID: References: <20210928084042.1227848-1-robinx.zhang@intel.com> <20211011081248.4108-1-robinx.zhang@intel.com> In-Reply-To: <20211011081248.4108-1-robinx.zhang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.200.16 dlp-product: dlpe-windows x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: upgrade AQ command of MAC/VLAN remove X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Zhang, RobinX > Sent: Monday, October 11, 2021 4:13 PM > To: dev@dpdk.org > Cc: Xing, Beilei ; Zhang, Qi Z ; > Guo, Junfeng ; Yang, SteveX > ; Zhang, RobinX > Subject: [PATCH v2] net/i40e: upgrade AQ command of MAC/VLAN remove >=20 > Firmware will return I40E_AQ_RC_ENOENT when try to delete non-existent Better to add firmware version it should be 8.4+ > MAC/VLAN addresses from the HW filtering, this should not be considered a= s > an Admin Queue error. But in i40e_asq_send_command, it will return > I40E_ERR_ADMIN_QUEUE_ERROR if the return value of Admin Queue > command processed by Firmware is not I40E_AQ_RC_OK or > I40E_AQ_RC_EBUSY. >=20 > Use i40e_aq_remove_macvlan_v2 instead so that we can get the > corresponding Admin Queue status, and not report as an error in DPDK when > Firmware return I40E_AQ_RC_ENOENT. and it will not break with a old firmware >=20 > Signed-off-by: Robin Zhang Acked-by: Qi Zhang Applied to dpdk-next-net-intel after refine the commit log. Thanks Qi