From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9E1FFA0598; Tue, 21 Apr 2020 12:04:41 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C87CD1D6EE; Tue, 21 Apr 2020 12:04:40 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 582E31D501 for ; Tue, 21 Apr 2020 12:04:35 +0200 (CEST) IronPort-SDR: /DzSJum2Aa71wRVpxebtjhtsh7CZjOFOHH81ibAGXjt8XsBOWz5UwVvCYo3o8vG1EBUxhfrVKh kkiBUnINjhJQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Apr 2020 03:04:34 -0700 IronPort-SDR: 9mB3kPekCt3VZA2r9RgDXvHr3SHXo0ogo1aCwllTobg7zQkDVlWyE+ElBwUcTZ6wrRKnNfdBx3 wtqz9mvLgB/A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,410,1580803200"; d="scan'208";a="279583188" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.252.10.127]) ([10.252.10.127]) by fmsmga004.fm.intel.com with ESMTP; 21 Apr 2020 03:04:32 -0700 To: Thomas Monjalon , Bill Zhou Cc: Ori Kam , Matan Azrad , "wenzhuo.lu@intel.com" , "jingjing.wu@intel.com" , "bernard.iremonger@intel.com" , "john.mcnamara@intel.com" , "marko.kovacevic@intel.com" , "arybchenko@solarflare.com" , dev@dpdk.org References: <20200410094631.31330-1-dongz@mellanox.com> <4860948.CpGBqz00pN@thomas> <3422085.0RtB02Ng89@thomas> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJUBBMBCgA+AhsDAh4BAheABQsJCAcDBRUK CQgLBRYCAwEAFiEE0jZTh0IuwoTjmYHH+TPrQ98TYR8FAl1meboFCQlupOoACgkQ+TPrQ98T YR9ACBAAv2tomhyxY0Tp9Up7mNGLfEdBu/7joB/vIdqMRv63ojkwr9orQq5V16V/25+JEAD0 60cKodBDM6HdUvqLHatS8fooWRueSXHKYwJ3vxyB2tWDyZrLzLI1jxEvunGodoIzUOtum0Ce gPynnfQCelXBja0BwLXJMplM6TY1wXX22ap0ZViC0m714U5U4LQpzjabtFtjT8qOUR6L7hfy YQ72PBuktGb00UR/N5UrR6GqB0x4W41aZBHXfUQnvWIMmmCrRUJX36hOTYBzh+x86ULgg7H2 1499tA4o6rvE13FiGccplBNWCAIroAe/G11rdoN5NBgYVXu++38gTa/MBmIt6zRi6ch15oLA Ln2vHOdqhrgDuxjhMpG2bpNE36DG/V9WWyWdIRlz3NYPCDM/S3anbHlhjStXHOz1uHOnerXM 1jEjcsvmj1vSyYoQMyRcRJmBZLrekvgZeh7nJzbPHxtth8M7AoqiZ/o/BpYU+0xZ+J5/szWZ aYxxmIRu5ejFf+Wn9s5eXNHmyqxBidpCWvcbKYDBnkw2+Y9E5YTpL0mS0dCCOlrO7gca27ux ybtbj84aaW1g0CfIlUnOtHgMCmz6zPXThb+A8H8j3O6qmPoVqT3qnq3Uhy6GOoH8Fdu2Vchh TWiF5yo+pvUagQP6LpslffufSnu+RKAagkj7/RSuZV25Ag0EV9ZMvgEQAKc0Db17xNqtSwEv mfp4tkddwW9XA0tWWKtY4KUdd/jijYqc3fDD54ESYpV8QWj0xK4YM0dLxnDU2IYxjEshSB1T qAatVWz9WtBYvzalsyTqMKP3w34FciuL7orXP4AibPtrHuIXWQOBECcVZTTOdZYGAzaYzxiA ONzF9eTiwIqe9/oaOjTwTLnOarHt16QApTYQSnxDUQljeNvKYt1lZE/gAUUxNLWsYyTT+22/ vU0GDUahsJxs1+f1yEr+OGrFiEAmqrzpF0lCS3f/3HVTU6rS9cK3glVUeaTF4+1SK5ZNO35p iVQCwphmxa+dwTG/DvvHYCtgOZorTJ+OHfvCnSVjsM4kcXGjJPy3JZmUtyL9UxEbYlrffGPQ I3gLXIGD5AN5XdAXFCjjaID/KR1c9RHd7Oaw0Pdcq9UtMLgM1vdX8RlDuMGPrj5sQrRVbgYH fVU/TQCk1C9KhzOwg4Ap2T3tE1umY/DqrXQgsgH71PXFucVjOyHMYXXugLT8YQ0gcBPHy9mZ qw5mgOI5lCl6d4uCcUT0l/OEtPG/rA1lxz8ctdFBVOQOxCvwRG2QCgcJ/UTn5vlivul+cThi 6ERPvjqjblLncQtRg8izj2qgmwQkvfj+h7Ex88bI8iWtu5+I3K3LmNz/UxHBSWEmUnkg4fJl Rr7oItHsZ0ia6wWQ8lQnABEBAAGJAjwEGAEKACYCGwwWIQTSNlOHQi7ChOOZgcf5M+tD3xNh HwUCXWZ5wAUJB3FgggAKCRD5M+tD3xNhH2O+D/9OEz62YuJQLuIuOfL67eFTIB5/1+0j8Tsu o2psca1PUQ61SZJZOMl6VwNxpdvEaolVdrpnSxUF31kPEvR0Igy8HysQ11pj8AcgH0a9FrvU /8k2Roccd2ZIdpNLkirGFZR7LtRw41Kt1Jg+lafI0efkiHKMT/6D/P1EUp1RxOBNtWGV2hrd 0Yg9ds+VMphHHU69fDH02SwgpvXwG8Qm14Zi5WQ66R4CtTkHuYtA63sS17vMl8fDuTCtvfPF HzvdJLIhDYN3Mm1oMjKLlq4PUdYh68Fiwm+boJoBUFGuregJFlO3hM7uHBDhSEnXQr5mqpPM 6R/7Q5BjAxrwVBisH0yQGjsWlnysRWNfExAE2sRePSl0or9q19ddkRYltl6X4FDUXy2DTXa9 a+Fw4e1EvmcF3PjmTYs9IE3Vc64CRQXkhujcN4ZZh5lvOpU8WgyDxFq7bavFnSS6kx7Tk29/ wNJBp+cf9qsQxLbqhW5kfORuZGecus0TLcmpZEFKKjTJBK9gELRBB/zoN3j41hlEl7uTUXTI JQFLhpsFlEdKLujyvT/aCwP3XWT+B2uZDKrMAElF6ltpTxI53JYi22WO7NH7MR16Fhi4R6vh FHNBOkiAhUpoXRZXaCR6+X4qwA8CwHGqHRBfYFSU/Ulq1ZLR+S3hNj2mbnSx0lBs1eEqe2vh cA== Message-ID: Date: Tue, 21 Apr 2020 11:04:31 +0100 MIME-Version: 1.0 In-Reply-To: <3422085.0RtB02Ng89@thomas> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2] ethdev: support flow aging X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/20/2020 5:10 PM, Thomas Monjalon wrote: > 20/04/2020 16:06, Ferruh Yigit: >> On 4/18/2020 10:44 AM, Thomas Monjalon wrote: >>> 18/04/2020 07:04, Bill Zhou: >>>> From: Ferruh Yigit >>>>> On 4/14/2020 9:32 AM, Dong Zhou wrote: >>>>>> --- a/lib/librte_ethdev/rte_ethdev.h >>>>>> +++ b/lib/librte_ethdev/rte_ethdev.h >>>>>> @@ -3015,6 +3015,7 @@ enum rte_eth_event_type { >>>>>> RTE_ETH_EVENT_NEW, /**< port is probed */ >>>>>> RTE_ETH_EVENT_DESTROY, /**< port is released */ >>>>>> RTE_ETH_EVENT_IPSEC, /**< IPsec offload related event */ >>>>>> + RTE_ETH_EVENT_FLOW_AGED,/**< New aged-out flows is detected >>>>> */ >>>>>> RTE_ETH_EVENT_MAX /**< max value of this enum */ >>>>>> }; >>>>> >>>>> >>>>> Just recognized that this is failing in ABI check [1], as far as last time for a >>>>> similar enum warning a QAT patch has been dropped, should this need to >>>>> wait for >>>>> 20.11 too? >>>> >>>> This patch is commonly used for flow aging, there are 2 other patches have >>>> implement flow aging in mlx5 driver reply to this patch. > [...] >>> These MAX values in enums are a pain. >>> We can try to think what can be done, waiting 20.11. >>> Not sure there is a solution, except hijacking an existing value >>> not used in the PMD, waiting the definitive value in 20.11... >> >> Dropping from the tree as of now, to not cause more merge conflicts, we can add >> it later when issue is resolved. > > Thanks for dropping, that's the right thing to do > when a patch is breaking ABI check. > > After some thoughts, I think it is acceptable to make a v3 > which ignore this specific enum change. I explain my thought below: > > An enum can accept a new value at 2 conditions: > - added as last value (not changing old values) > - new value not used by existing API > > The value RTE_ETH_EVENT_FLOW_AGED meet the above 2 conditions: > - only RTE_ETH_EVENT_MAX is changed, which is consistent > - new value sent to the app only if the app registered for it > Same here, as far as I can see it is safe to get this change. If any DPDK API returns this enum, either as return of the API or as output parameter, this still can be problem, because application may use that returned value, this was the concern in the QAT sample. But here application registers an event and DPDK library process callback for it, so application callbacks won't be called for anything that application doesn't already know about, in that respect this should be safe for old applications. Not sure if we can generalize above two conditions for all enum changes, but we can investigate them case by case as we get the warnings. > So, except if I miss something, I suggest we add this exception: > Allow new value in rte_eth_event_type if added just before RTE_ETH_EVENT_MAX. > In other words, allow changing the value of RTE_ETH_EVENT_MAX. > The file to add such exception is devtools/libabigail.abignore. > OK to exception.