From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 77340424CF; Tue, 11 Jun 2024 19:07:19 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 346ED40698; Tue, 11 Jun 2024 19:07:18 +0200 (CEST) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2075.outbound.protection.outlook.com [40.107.93.75]) by mails.dpdk.org (Postfix) with ESMTP id ED0B64021F for ; Tue, 11 Jun 2024 19:07:16 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=B+E1Ge6RwqmjNBPC9oURnfjiaoCc9MIKjFuechyb+KBrPgPx1hU42P2w2nnfoSRtlxNPaKu/aRFka+KLsuClof9hUc+O19ss55iMCj0r+pcNGlbg8d56lpEaj6BMTABOdWvc0cw3FXq1/+k48W+eqqqfUt/s+8gd8gXIX4dm7SssxtglQygqZ5j8sqywncDGHQK1kb0gNnfUT2zw4kiGKyfitf4kUWraKzOegq1vP+IKx5HMZba2Rpk+Y00B8gUtXiFIZxDsZyM86QJMLkf5HUTG1oJei8TrohZ0+nvBIcbeY3QQzJwUAPIwykTqHm7o0Svwbr2DhQxy5V8RBobKkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5F7398LHcDCwMSpDw0LQcOB65BZHa2Kx7Nl44qoKicc=; b=WGWDi4qBJojL+dcT4qMFTHoaKzd8xvmqTGGWRExPx+2An4gkRLLybkcOfiWVW80ufHm5Y87W7Kzgy3F6R730IBrat6wWi98jmktYFNJLitG7MXUJuejwAJLURKg4xuujXGcwoQ6JY7a2Ji+VqiyJzrQ+PQ+91vYOw6EpY9U8XU7PjMlKZHPNSWMr4bEpmYfhzz7iB6EDkp84Of+MpC6bKIyO49J9fLOD6g6O1E1vGu0AowgGH4KUdcmHND3eUF1LOK6JW0qypNFo4fgmudC4kn/eXkBU29YiJU9rMGBEq0GVsJ7IHRcbxPpvJ65nYTnBgsd9p9yOlpmCFqdBIYgCFg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5F7398LHcDCwMSpDw0LQcOB65BZHa2Kx7Nl44qoKicc=; b=zDZVu3uu9KisO73bOj6xQcWZYuOhEWN6WewBPTR0jamfrfJ/zOKQFV3Ym4QMxbrVet2PXFymmpIGFZQqR7jJnKwhtMNQP0zsw6H3/aMM8pgHqzfElPK8jkFBgTb5XBlyApiuEwfXJA7D/vOsctb2gEaa/fIQ+YvCdA+gsyWdtIM= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by IA0PR12MB9012.namprd12.prod.outlook.com (2603:10b6:208:485::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7633.36; Tue, 11 Jun 2024 17:07:14 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::ebfb:2f9f:f9ca:82cd]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::ebfb:2f9f:f9ca:82cd%4]) with mapi id 15.20.7633.036; Tue, 11 Jun 2024 17:07:14 +0000 Message-ID: Date: Tue, 11 Jun 2024 18:07:09 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [RFC 0/2] ethdev: update GENEVE option item structure To: Michael Baum , dev@dpdk.org Cc: Dariusz Sosnowski , Thomas Monjalon , Ori Kam References: <20240417072304.3260172-1-michaelba@nvidia.com> Content-Language: en-US From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <20240417072304.3260172-1-michaelba@nvidia.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DUZPR01CA0154.eurprd01.prod.exchangelabs.com (2603:10a6:10:4bd::24) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|IA0PR12MB9012:EE_ X-MS-Office365-Filtering-Correlation-Id: 3de2c9dc-eb9b-4168-77dc-08dc8a38f08a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230032|376006|366008|1800799016; X-Microsoft-Antispam-Message-Info: =?utf-8?B?eVhBTEdqNWdVa21GcW9VRWlSYTErVHo1NDBSSVovQXZzNlljcmd6UlZLWk1S?= =?utf-8?B?OXkvbnlqaXlFMWZBTWtsSDlYb240UHZ4aytRcVhBZkNxOXdhaDU5bWxxczYw?= =?utf-8?B?VUZrYngrbXVSa3JpYi9tYzU3d2cyaDE1TUkvMFliVlpqcHZ1SFVKOFVIVGpG?= =?utf-8?B?VnVkWG9WTUhCYUhmcHlVOEhkWk9GemNZMjVFZVZmcUtFVS9nenFmb3o1dU54?= =?utf-8?B?ekJWVmxlVU05endJTlIzOXZCcWhOSmw4RWVjRDBWejZwQml0bHo4NVp5cE1Z?= =?utf-8?B?TmVpQWdBaXVUYmdGbm1VKzhZWGFoS0RTcWRXMUR3OUh0Y09md3ZhbHcxMnIw?= =?utf-8?B?UU9GZFEyQk51MWVHSEpaREcwRW5SN1JKbXp3NXV2ZndLeDNWZkNWbmNVN1FF?= =?utf-8?B?OE5rUFgva1NPWnpDY0d4Zi80Zm53eVIrVWwxcDBoazZQVTZ5QlNTMjFDYlRh?= =?utf-8?B?b0ZtaXo0ZFUvdDcvaCtPNG1qZjBPcENxMGxBMlQyRGZpOHNuK0xLdkQvS21m?= =?utf-8?B?RllKSFJ5dkY5elYzekllaHJQVG9laUZQY3dWMXJMZ2ZlNXcrQmxQNFdPazY1?= =?utf-8?B?SGNKMWV1bkFGYS9pQ21CbTllQ2I4ZVVpTW5EcWFvZ3hmVTNMWEFNelBSdERv?= =?utf-8?B?UWhuS1R1QU9tVTdYRlpvV0pEZUQzZmdTbVZwZ0MvWFV6THdYcys0WVl4ZDNW?= =?utf-8?B?MWY0azYvZzhtUFI4dFdlaUJyODVpS1lVcUx0TUE2bHROdURpM2xpSC9neXdI?= =?utf-8?B?SnZZUGd3SkRnWTE0N1k0MnZlZVhsWVJXZnpJWGZmWU9HNklUQi92VkpUdmxo?= =?utf-8?B?a1k1QUU3d0FQNHpmWmRkK3E4VEFhS1BlcUV0TW9vajJpcGFJaENGQUJHb1J4?= =?utf-8?B?c2tUZzJaL1pjS2FPbEVTVkR6c0ZsQWtqNGJ3Mk02OVNybWMwZzFwakMyTDcv?= =?utf-8?B?QTRUZ25iclVMYkRBN2RiVmNZc2c5VTIySDhwZ0M3dVpKU1M4UVFpaVNFTmsw?= =?utf-8?B?NWdLQ1VCM3R5S1YvM2x4dC83bzlIaTlaVWhCUldHSUZhdk1FenlCeE44U25x?= =?utf-8?B?QUhpMHFhcXh6UEVTRUkwb3lNWjZlemd3Y3JCYURIMS96MkVzY3dPN29MTHF4?= =?utf-8?B?KzhFTk1leWxGZWNuV0VWMHp3Y2hFTXRSeXk1eGo0bkVFMEdldGFlRXhTUlFY?= =?utf-8?B?M0ZLbFBlRXVsN2hpdzUrVW5DS01KekF0Ym45cVhVN3VaaFhMb2szM3A1MGRq?= =?utf-8?B?UHcwTFhmQ3V6MDB0NytLVWJRSjcveHhSVnZQV3FwTDd0N3UzUGtYbGlwbUV2?= =?utf-8?B?T3hzVk9DWnU2QXF3dkZHYTVvNmo5dkxhOHkwWkZwdUpCcHZ5NC9OQ0hDSFJR?= =?utf-8?B?MjlOV0ttQ093d3hHL0h3Vldna01wMVpqMUt2WjBGNkd2RDBnanBQcTNtWCt0?= =?utf-8?B?RGRUM1M1MVZkSkdneWJTLzRnYlBQV3RLb2FIcXpFcUxuK3ltckZlMkRjM1Ur?= =?utf-8?B?UUlMaHE5ZlBZN1ZuaG13Y1BsUVpZd1Y2dEdEZWpLZG1lWG8rb0Y5SXNuWUNX?= =?utf-8?B?bzYweWcyMHdrQmFxK0N4ajg0MlVmM3d0RlkwWnBUNHZNVzNBb0RVNlIvcGh2?= =?utf-8?B?US9uc1VQd0VwN29Ba0daSmRWYit5WE9XbWdqUlVwTnBreVlNdGEwV2w4NTBG?= =?utf-8?Q?Mn22ozo06FCckjAxp8M4?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230032)(376006)(366008)(1800799016); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TnFwYXJSZGdHSWtYQzczUWJzWnR5bGhXSWpOUmptMVdIdGcyL3NuaDZteXh6?= =?utf-8?B?T093VG1mMzQ2SjE3SWZCU3Nvb3BPTVJjVW85akcxSnNMOW1weG1mWFZTekZG?= =?utf-8?B?WmdGWGMwL3h5MHQ2T0IyQjdwV1dTa0VKVDZ0Z3dUVnk3M01SRGRnQ05wNXVQ?= =?utf-8?B?am5lR0RqMmlraGRVN1BZc3RQZmxDWnMxRlRPMFQ3NndFUnMyU2x4VkRQVmJH?= =?utf-8?B?SEw2TWJIYk94RnB0NGVvU29ZNVFpYStMcGJZSHB3V1B6a213ZUNQaDZEYUNK?= =?utf-8?B?b1NkK29BQjhuZUlzejhWZ0N2MmpwOFJ1aE9GVWJ1MVNtWEY1VmwwT25JVmZk?= =?utf-8?B?ZmtzY3loV3BqYnJsSWtRWWptcUkzWkRRVDh4UHBCZW5SbHZQYVZpZmtCYjds?= =?utf-8?B?QXJnR1VZTy8reDkvRFZ0dHI4SmlucXBRMjFEMDlkNVp0VnprUjVIVkZTTUJ3?= =?utf-8?B?YWdQYk1jblllZGpKQmdRckp0djJZOU5SYTM5VXFudlFWbm1iZHF2WExnSnNF?= =?utf-8?B?T3pRU1VvTjMvMVdmNFpUdS9EK3NjUDk4Ti90Zm9VZm42WmhaZENsaVhDSWpz?= =?utf-8?B?UEZ3bVlYWHN6akYwL04xdGt5WlBQa1d6aEJPZDZOSXZHaHFNT0F3cVRncFJu?= =?utf-8?B?TUZiSjZvTmY4R0ovVm5LYzNhaWUrQ2ZPQ0lmSTdFS3VqWTNMaTkyZ1ZyV0xK?= =?utf-8?B?QXNrQ1dpeUZ3ME52a01ua1NyTG5neTVvM29tU3NQOW5ZeHBTRFo1TnB4T1F6?= =?utf-8?B?TTlEUkJ6WFFmUjFOemRNK3JGVS9DRDFZelZkcmpoZzltTyt0Z0lkWFExbXpm?= =?utf-8?B?ajVvcEVnWEo1WlFCUk5UbTRpaURDbExWL2E5MDExY1hzS2lwb0VCVGZXV2Qv?= =?utf-8?B?aFJqaCtCanJoYnVZMXI1ekdqTU1YaGlBS1F0V1FlVUlUTncxdTA3OGdrcnhE?= =?utf-8?B?OVR2QklQdTF3M3FxbHRsMk13L1M3MzJEWnV6WTIySUg0SHdVNzdpQjhUVzk3?= =?utf-8?B?S3YrODhNckNsYkh2TDNBRkhCdVUzekdEZmpVQ0NWNnRMcWNpQklXYzBiV1pN?= =?utf-8?B?dHgwVXErcEs5UER0SDBiTDFpdlRHc3ZjUHR3RFN2NmJFOHc5QTQzQmRHK20w?= =?utf-8?B?VUgrTHZxdG1WWjZ2aGNHajdVaXVqN3BEWnh2ZjFzN1pWRmV3MmkzMFNpTmRD?= =?utf-8?B?UjVYcXM2djl1M25YU0tOenNYOThsaG91TVk5YjBubndHVTZ1M3RMUHRPMlA3?= =?utf-8?B?SnFjM21tR2VNbVFJelM3cjJKc29BSXFGbWNpTzhRY0FDU0dGMTdSZkZDMjJu?= =?utf-8?B?ei8rMXRmNStXRHIwMjBNUWFkRy8rTFdYaW9YRUN4TVZVRmRRVWwrSUxMN2Iv?= =?utf-8?B?R3dkQkx3RDBVZTBPNXRHOUVtL0lOcnNFWk9DbUd6ei83ZGNKVVZ6WHMySHBy?= =?utf-8?B?Y1hWdXVRM1g1VUxpdkN5S08rOUtoY0dxTFR2K1RxN0NPZFpKdjhmeGd2YWZs?= =?utf-8?B?NGxTd1N3V1NOYlBRRkVyaU83Z29OcCs0MGxJR3BtZWp5MU91SXdvdVFqR3RE?= =?utf-8?B?TjkwbFhOTnlNbEZMVHdXdnptZ0cyVEo2eHlJbkVSMnpLaFZ4U2FLemVNKzBT?= =?utf-8?B?bTA4SGpvUFlVeTFXNkhuTXJUZ1kvQThURkJob2tDZHlOK2JPeVZBL2tmZVE2?= =?utf-8?B?N3ErbkxLVWhwTDMvcGtKbHBLUEorRHY1NlgySTR6aGRlRTFwTGlpZ3h4MGZi?= =?utf-8?B?NGZBeGlMd3NPMGZ1VTNrOUswbXhRUEJtVWJMWDZlMVpISXVlRDJEbFJxckNp?= =?utf-8?B?NWlzWWREK3p5Ni9MOEJKWEFBSDN1WFZEaWNsd2pXRHZ2c1J1eEkrQW9LNGRV?= =?utf-8?B?SFJaSDd2U1Q5UUFYc1Z6SnVCclJqVFFWSEN6WDMxNW5oZmxUOXVYeWFRcmpO?= =?utf-8?B?Qnl3TmMwcklOUy96VU84TWhBdU8xQ2JBMkJaQmJWemRsVm5KU0pNSSsyYUpo?= =?utf-8?B?VUpqWTVDUlAwL3ZKcjE0RDdDM0NRWVJCUzZnZ2hBRUtNQlJPeCswUGhWNm5h?= =?utf-8?B?cHVWT3VmdStzWStiaXZOTjBPcFNOQUNaOWVqckl6Tk5WV0NudDhZcVBYMTZM?= =?utf-8?Q?jCKETSzZeRVG3tnGq6H1AlibH?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3de2c9dc-eb9b-4168-77dc-08dc8a38f08a X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jun 2024 17:07:14.0610 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1qVuCVsFJoHq5MuXXKrgkb+jVh21/+IyO5M4aGvjMO2X0aYDEa00T0rIj0gzquiO X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB9012 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 4/17/2024 8:23 AM, Michael Baum wrote: > The "rte_flow_item_geneve_opt" structure describes the GENEVE TLV option > header according to RFC 8926 [1]: > > struct rte_flow_item_geneve_opt { > rte_be16_t option_class; > uint8_t option_type; > uint8_t option_len; > uint32_t *data; > }; > > The "option_len" field is used for two different purposes: > 1. item field for matching with value/mask. > 2. descriptor for data array size. > For the long run solution, we may consider adding geneve option header to net/rte_geneve.h and make "struct rte_flow_item_geneve_opt" + data size ? > Those two different purposes might limit each other. For example, when > matching on length with full mask (0x1f), the data array in the mask > structure might be taken as size 31 and read invalid memory. > > This problem appears in conversion API. In current implementation, the > "rte_flow_conv" API copies the "rte_flow_item_geneve_opt" structure > without taking care about data deep-copy. The attempt to solve this > revealed the problem in determining the size of the mask data array. To > resolve this issue, two solutions are suggested. > Are we having this problem only with geneve options because data size is not fixed / defined for the header? > Immediate Workaround: > The data array size in the "mask" structure is determined by > "option_len" field in the "spec" structure. This workaround can be > integrated soon to avoid deep-copy missing. > This requires a geneve specific pointer in the item spec, which is not really nice, although it is temporary solution. Perhaps we can skip this, can you please check below comment. > Long Run Solution: > Add a new field into "rte_flow_item_geneve_opt" structure regardless to > "option_len" field. This solution should wait to "24.11" version since > it contains API change. > I was expecting the same, but CI seems passed ABI test case [1], it may be because new field appended end of the struct. Can you please double check, if ABI is not broken, we can go with this solution directly? [1] https://mails.dpdk.org/archives/test-report/2024-April/643570.html > When the API is changed, I'll take the opportunity to add documentation > for this item in "rte_flow.rst" file and update the data type to > "rte_be32_t". > If we can go with updating struct in this release, adding protocol option struct in net library can wait v24.11 release. So "rte_be32_t" type change in this struct won't be a thing. > [1] https://datatracker.ietf.org/doc/html/rfc8926 > > Michael Baum (2): > ethdev: fix GENEVE option item conversion > ethdev: add data size field to GENEVE option item > > @Ori, Can you please help reviewing this patch? At worst, it can be good to address the fix in this release.