From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B68FDA0548; Mon, 20 Sep 2021 17:21:17 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 46C3340DF7; Mon, 20 Sep 2021 17:21:17 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 96A4C40DF5 for ; Mon, 20 Sep 2021 17:21:15 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10113"; a="203308316" X-IronPort-AV: E=Sophos;i="5.85,308,1624345200"; d="scan'208";a="203308316" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Sep 2021 08:20:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,308,1624345200"; d="scan'208";a="454048735" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by orsmga002.jf.intel.com with ESMTP; 20 Sep 2021 08:20:48 -0700 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 20 Sep 2021 08:20:44 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Mon, 20 Sep 2021 08:20:44 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.172) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Mon, 20 Sep 2021 08:20:44 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VQGNs+G91MQeuaA1xDokdCvM0LyRiatXufMfkYpnVPWvx6WdTELCkEkYU4PXVM0SdrQ0Hp0iHKHW/emyTu2MCVZL773Ti4n3IOgKr8hufNKv7rB5NBlrpRYTBCCbO2qtgbGhbNm3GOpipf57fAcfnIRkSlNOsEWjqXcZwyO2ZcmvQH/MHBRDAitgqj1+cYFu0NJ2Kl1iLc3uC+ZTbBzqNcCFACoeUyKiA9Vcq+4ABBZv7shvxLBlrDA5Q1wdR94REIVw9Iy1lO5sgpN4tTL9bF3vaoirKlRoSCY3SDSMsz2bYB3+blYRv0Ab2Iak2ZMJwwJ4musD3Osaip0cCv8mSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=Lq9wSF7uzBc1mYZeUwNfqbeK7m0dyow5Wyregiarwy4=; b=dCrtPEB6lplwefUHJovl9F/iKWKb3KjcF8hv5C0JzbrJlFkKhoJvrZGRrRrYNZmf8DKUhUVZ54e5MzzTwCaFh5gqVqSaChkpB3FqlAeyUACqWXrEj0TUASSL8Rhrnzex3oVc6FLc/kig8gK1CuVDHP2YmXRHzZBYTAqcr3ObaRdjf1amde/Urp/Yz3nmwLkXvfc6ZC69tQdeoLrshaQtwzHwIVGaiiwTMNO7zD6s/N4lA+Go8s6gnf311J3zSX8H4aJOv+YlXsa+Fz9xWmWNWxTsNG9qnfh+mtiaGADlO/6Gt5BllyB7sjaa1Fe25rqT7iz/uTBYfNpO38qouSvSUA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Lq9wSF7uzBc1mYZeUwNfqbeK7m0dyow5Wyregiarwy4=; b=tqjshWUr/K7ILGDKo+USddeKOuaKORYwBL8LsyGnDmHzbyUF/SzOdtTFwJpGts3IgRCQz9bL2dNeoZjNaW38eMxZ9eZlQDEePsq54hg2wWIjmg8zesIxYBFp5emoSH2FajacfbM3a+x1uhOhCfvmAe1z/uqCnG5obr3423Zyoic= Authentication-Results: dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.16; Mon, 20 Sep 2021 15:20:43 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc%5]) with mapi id 15.20.4523.018; Mon, 20 Sep 2021 15:20:43 +0000 To: Jakub Grajciar References: <973f32e49849ad68@cs.arizona.edu> CC: Junxiao Shi , From: Ferruh Yigit X-User: ferruhy Message-ID: Date: Mon, 20 Sep 2021 16:20:37 +0100 In-Reply-To: <973f32e49849ad68@cs.arizona.edu> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DB6P193CA0017.EURP193.PROD.OUTLOOK.COM (2603:10a6:6:29::27) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB6P193CA0017.EURP193.PROD.OUTLOOK.COM (2603:10a6:6:29::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.14 via Frontend Transport; Mon, 20 Sep 2021 15:20:42 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 58f82719-1967-430b-bc7f-08d97c4a3677 X-MS-TrafficTypeDiagnostic: PH0PR11MB5000: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4941; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gVhVAvuTkp4z62HdeGF+MGp4uDOAJlW2UCJImgkC0CmQy6CucWZ5EFM5aMh5ZUuQZonuYTe1npaMOQUnDdPYeBkRhkK9IHg8vCAXSlJj5G9ql2lDGqDHKIHj6Joapu/cLLXqQpXe895rTcH94b76EjFBC91EA3uyEV3Uhh1exlx0Wy7UNvn+Z1NFwQ7HWrkJfzBPYem8NmUPvdv+deNVTi2jPu/ViGxHIdh2vVVRxg1luSphTj2I1P/tBJ4tQE5aIN9HwHZNi6jpjEQX1LJYcHt6Teih6z/q0V4vJoJorEjyQdmn319TX/oc4LmTFGbDnBEI5BYHxt2Cs9IUqAH7UxBEl1NWwj/SlC6+kjXDrJCPyyZb4P8/6A537XePqQVJyZJmaiNsL68GRe/8JoH8LOw6xQ9/lyhmJwuw/ZOcqID648cPiVQtXiKwOaB17Id5dVH0D48PF03gnDu3Irf36L3cUAqEWp6YLPYaY2Wcl1l09NmDsI1mXcANMHospeu9Df0aQLMPek2g16yxZbtc/5V5rAyUz3KuDV6DWs9/hprH2XSGdCgrQ1Usx0E5FidEFdb7Zr7a9qxjVPhQK41NCLJsPYCSdRgVB38kelEiUogBJU2eNLc6SO/IMbEGyOoPE9ni9bcWE7n25j6hEOcGzSwNpGJAKMNaYP0fPg5YbCwVgBP6Gl5LbjWuHIDvnaIH3N0WBfoQKqRl3YJ+GteoKA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(39860400002)(346002)(376002)(396003)(136003)(316002)(2616005)(16576012)(6486002)(6666004)(31696002)(66556008)(66476007)(8676002)(956004)(6916009)(83380400001)(4744005)(186003)(26005)(86362001)(2906002)(66946007)(5660300002)(36756003)(53546011)(4326008)(44832011)(38100700002)(8936002)(31686004)(478600001)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UFp5Z2FBNDVMZ3ZZZ2cwdHpoZjJ5aWVDRDM5Y3J0TytMclJ3OVFjc1FXVjY1?= =?utf-8?B?RTd5VEI0S0tmMWV6cGdZWlYvYlJlMVptQWRuQU5tMHA1UlMzWTY2K0EyTWFv?= =?utf-8?B?S2ZHUHl5KzI1aDYzZzZEa0hSQmdWUy9zWG1uVzVLMnV4a0RoTkphdXZPYWwy?= =?utf-8?B?Tm5WTCttZko1Nk5Cb1p1K3BKUVVmOGY3RG5VQk13cER1ZGY3bmp1c3BwUEFQ?= =?utf-8?B?R09qZVdsREhvVk1wajBLc2lCOG1XY3Q0NTkvZW4rbXpXT2lUK1dzRExMWUto?= =?utf-8?B?Mms1ZUw5YS9OdlVueVNkRFNIUm1FWjlCQm43WHlYYVFuL20wM3VxWFFFTy83?= =?utf-8?B?RkxoVVVDU1FmV1NRd05kSzk4R1dUbUh6eW1HRlFVcmxTYTVDVm5JNUxQbDRK?= =?utf-8?B?L1NWUVBnakNMUnltRG9ndkFuV1kxNjVpSkhZT2FWNHNlQnRhb1IvWXFsRDZI?= =?utf-8?B?aHl6WkdHQko2d1pJdkdrckxzaDJVVHBuSklURGRDWlJ0b0FZTXF3U2RlZ3lU?= =?utf-8?B?TWpiQnpBSUZxemJYampIS0NUeFlsNFNSSStzT05vcENyblZkcHJIdExGUlNY?= =?utf-8?B?eWtuaGdXUEdqWDZIQjB1bnZzR0p0cnZvc05IdG9OU1VkRE1ldC9hdHVqUUNq?= =?utf-8?B?Uy81aGV0MTJWYWl6SW1jSXpuZTAxV3UrOUxRMkcwWDNmUWwxTXlFK0VnMnVq?= =?utf-8?B?VXRiUk14WGJWV0JUU21IUlVGK3pVdGhmY2syenFiQ091SDZRcXF1eTEzYnEx?= =?utf-8?B?WUMxWVhSREpaeDBGRlVJTVBoWnorSFcvTVpRaGxPa3djZEp6RVVsd0daQkQv?= =?utf-8?B?bTdvcXFWZkdES3VPVlpweW9ERFJzdG1NcGpXNitUSUJmMFpFdC9pcGlpbzlO?= =?utf-8?B?d2tLU0lRM0paVi8zNlhENmdidFdhNHNrYlRIeEUwYUFCa0pYczJUOExaM09M?= =?utf-8?B?cFVpZjRtcklidWQ1djg1ZXZWN0ZoclhiQnlOZTR0UEtzdVRCczB5OENzY0Zp?= =?utf-8?B?TWt2UEk3UVJmSWhBUFpDY1R3dnIzMGZYV0swUFFrOHRVb0RFV0NOZk5rQUhN?= =?utf-8?B?MzBnTmpQQU9mRTlZMXFLZUExbVE2Y1RxcnE2MVZINGNwZE9aelBtazRJVGVZ?= =?utf-8?B?U3ByQ1lvTEVadTJ0T2tqYUc2S0VIWGs2ZzdaZk5OVHJnYncrUzFFOUtiancv?= =?utf-8?B?a2dwVzRaRWFSQy9ySjJkeGtzRzBjS25GekhpUGxDMEEyb0srYmpLejJHL25D?= =?utf-8?B?UE9HZmdUekxTOUdvY0lFQ0M4RVd1dEZwVXpvZWtpeTRJU1pZVU5WT200Z2VF?= =?utf-8?B?aWhLTkNsRis0WFBEbjJXWU1qcTJyYS9YS3dmcHNCcEc4Z3BsWDhzT0FzRDJh?= =?utf-8?B?TjlrT3RCSHZSdFY0S00vdGdWa3RNTTQ5b1Z5UUxYb2JiQXkyT0h1elpVUjVm?= =?utf-8?B?V0JlaW5iUlkxNFBndUFSZUxST1JrWDBybE81d0pnRFhaY3YzMzFRcTNLSnVM?= =?utf-8?B?QmZCakNqVk5Sa2FNNFR0S3JHV1dHb2R0bE1oSTN4aEk4TWlqSk8zZkFUb3VM?= =?utf-8?B?OVFsWkZKcUZSVG4rZlNIZHpKK2ZDRk5uK2NDYUJpVDBNS2VzRGdIaVNYZkFW?= =?utf-8?B?WTlQUGgraWpreDNqSTFiYnQ4VFlkRzBJRys3cnY4eVBCR0hnZzgrQmtwNWl4?= =?utf-8?B?SmNXZmtRR0xRdXlnWGJUOG9LbHJFRzBrVWpYWkpoWG9QVXg5dDNJczRzZllY?= =?utf-8?Q?iYcKOpsXxVKdSk8xiVju/pQtD7jIncAgq1G7l06?= X-MS-Exchange-CrossTenant-Network-Message-Id: 58f82719-1967-430b-bc7f-08d97c4a3677 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Sep 2021 15:20:43.5375 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Tym+K7dTXKvrBDQHi+CATPtDYnNnd4m+sdXHvUKBIfyLThjDrfiyqDa4afeScU0saeCuP59ZyMPOnpEXHWcoOA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5000 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] net/memif: fix chained mbuf determination X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/9/2021 3:42 PM, Junxiao Shi wrote: > Previously, TX functions call rte_pktmbuf_is_contiguous to determine > whether an mbuf is chained. However, rte_pktmbuf_is_contiguous is > designed to work on the first mbuf of a packet only. In case a packet > contains three or more segment mbufs in a chain, it may cause truncated > packets or rte_mbuf_sanity_check panics. > > This patch updates TX functions to determine chained mbufs using > mbuf_head->nb_segs field, which works in all cases. Moreover, it > maintains that the second cacheline is only accessed when chained mbuf > is actually present. > > Signed-off-by: Junxiao Shi + memif maintainer, Jakub. Jakub, can you please review the patch?