DPDK patches and discussions
 help / color / mirror / Atom feed
From: Akhil Goyal <akhil.goyal@nxp.com>
To: Tomasz Duszynski <tdu@semihalf.com>, dev@dpdk.org
Cc: nsamsono@marvell.com, mw@semihalf.com, Szymon Sliwa <szs@semihalf.com>
Subject: Re: [dpdk-dev] [PATCH 2/6] crypto/mvsam: update hash digest sizes
Date: Mon, 17 Sep 2018 19:24:41 +0530	[thread overview]
Message-ID: <d53bff1e-c79d-3ca8-1428-1f3fb2dce30d@nxp.com> (raw)
In-Reply-To: <1535118895-6505-3-git-send-email-tdu@semihalf.com>

Hi Tomasz,

Is this patch a fix which needs to be applied for stable as well or you have
added some changes in the code which can support this.

-Akhil

On 8/24/2018 7:24 PM, Tomasz Duszynski wrote:
> From: Szymon Sliwa <szs@semihalf.com>
>
> Update hash digest sizes to match hardware capabilities.
>
> Signed-off-by: Szymon Sliwa <szs@semihalf.com>
> Reviewed-by: Yelena Krivosheev <yelena@marvell.com>
> Reviewed-by: Natalie Samsonov <nsamsono@marvell.com>
> ---
>   drivers/crypto/mvsam/rte_mrvl_pmd_ops.c | 46 ++++++++++++++++-----------------
>   1 file changed, 23 insertions(+), 23 deletions(-)
>
> diff --git a/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c b/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c
> index c045562..e2cfc07 100644
> --- a/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c
> +++ b/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c
> @@ -30,9 +30,9 @@ static const struct rte_cryptodev_capabilities
>   					.increment = 1
>   				},
>   				.digest_size = {
> -					.min = 16,
> +					.min = 12,
>   					.max = 16,
> -					.increment = 0
> +					.increment = 4
>   				},
>   			}, }
>   		}, }
> @@ -50,9 +50,9 @@ static const struct rte_cryptodev_capabilities
>   						.increment = 0
>   					},
>   					.digest_size = {
> -						.min = 16,
> +						.min = 12,
>   						.max = 16,
> -						.increment = 0
> +						.increment = 4
>   					},
>   				}, }
>   			}, }
> @@ -70,9 +70,9 @@ static const struct rte_cryptodev_capabilities
>   						.increment = 1
>   					},
>   					.digest_size = {
> -						.min = 20,
> +						.min = 12,
>   						.max = 20,
> -						.increment = 0
> +						.increment = 4
>   					},
>   				}, }
>   			}, }
> @@ -90,9 +90,9 @@ static const struct rte_cryptodev_capabilities
>   					.increment = 0
>   				},
>   				.digest_size = {
> -					.min = 20,
> +					.min = 12,
>   					.max = 20,
> -					.increment = 0
> +					.increment = 4
>   				},
>   			}, }
>   		}, }
> @@ -110,9 +110,9 @@ static const struct rte_cryptodev_capabilities
>   					.increment = 0
>   				},
>   				.digest_size = {
> -					.min = 28,
> +					.min = 12,
>   					.max = 28,
> -					.increment = 0
> +					.increment = 4
>   				},
>   			}, }
>   		}, }
> @@ -130,9 +130,9 @@ static const struct rte_cryptodev_capabilities
>   						.increment = 1
>   					},
>   					.digest_size = {
> -						.min = 32,
> +						.min = 12,
>   						.max = 32,
> -						.increment = 0
> +						.increment = 4
>   					},
>   				}, }
>   			}, }
> @@ -150,9 +150,9 @@ static const struct rte_cryptodev_capabilities
>   						.increment = 0
>   					},
>   					.digest_size = {
> -						.min = 32,
> +						.min = 12,
>   						.max = 32,
> -						.increment = 0
> +						.increment = 4
>   					},
>   				}, }
>   			}, }
> @@ -170,9 +170,9 @@ static const struct rte_cryptodev_capabilities
>   					.increment = 1
>   				},
>   				.digest_size = {
> -					.min = 48,
> +					.min = 12,
>   					.max = 48,
> -					.increment = 0
> +					.increment = 4
>   				},
>   			}, }
>   		}, }
> @@ -190,9 +190,9 @@ static const struct rte_cryptodev_capabilities
>   					.increment = 0
>   				},
>   				.digest_size = {
> -					.min = 48,
> +					.min = 12,
>   					.max = 48,
> -					.increment = 0
> +					.increment = 4
>   				},
>   			}, }
>   		}, }
> @@ -210,9 +210,9 @@ static const struct rte_cryptodev_capabilities
>   					.increment = 1
>   				},
>   				.digest_size = {
> -					.min = 64,
> -					.max = 64,
> -					.increment = 0
> +					.min = 12,
> +					.max = 48,
> +					.increment = 4
>   				},
>   			}, }
>   		}, }
> @@ -230,8 +230,8 @@ static const struct rte_cryptodev_capabilities
>   					.increment = 0
>   				},
>   				.digest_size = {
> -					.min = 64,
> -					.max = 64,
> +					.min = 12,
> +					.max = 48,
>   					.increment = 0
>   				},
>   			}, }

  reply	other threads:[~2018-09-17 13:54 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-24 13:54 [dpdk-dev] [PATCH 0/6] crypto/mvsam: add new features and fixes Tomasz Duszynski
2018-08-24 13:54 ` [dpdk-dev] [PATCH 1/6] crypto/mvsam: fix shared library build Tomasz Duszynski
2018-09-17 14:00   ` Akhil Goyal
2018-08-24 13:54 ` [dpdk-dev] [PATCH 2/6] crypto/mvsam: update hash digest sizes Tomasz Duszynski
2018-09-17 13:54   ` Akhil Goyal [this message]
2018-08-24 13:54 ` [dpdk-dev] [PATCH 3/6] crypto/mvsam: add support for HMAC SHA224 Tomasz Duszynski
2018-09-17 13:57   ` Akhil Goyal
2018-09-21 14:49     ` Andrzej Ostruszka
2018-08-24 13:54 ` [dpdk-dev] [PATCH 4/6] crypto/mvsam: add support for AES ECB Tomasz Duszynski
2018-09-17 13:59   ` Akhil Goyal
2018-09-21 14:46     ` Andrzej Ostruszka
2018-08-24 13:54 ` [dpdk-dev] [PATCH 5/6] crypto/mvsam: add support for crypto/auth NULL algorithms Tomasz Duszynski
2018-08-24 13:54 ` [dpdk-dev] [PATCH 6/6] crypto/mvsam: add 3DES ECB to the capabilities list Tomasz Duszynski
2018-09-21 14:53 ` [dpdk-dev] [PATCH v2 0/6] crypto/mvsam: add new features and fixes Andrzej Ostruszka
2018-09-21 14:53   ` [dpdk-dev] [PATCH v2 1/6] crypto/mvsam: fix shared library build Andrzej Ostruszka
2018-09-21 14:53   ` [dpdk-dev] [PATCH v2 2/6] crypto/mvsam: update hash digest sizes Andrzej Ostruszka
2018-09-21 14:53   ` [dpdk-dev] [PATCH v2 3/6] crypto/mvsam: support for HMAC SHA224 Andrzej Ostruszka
2018-09-21 14:53   ` [dpdk-dev] [PATCH v2 4/6] crypto/mvsam: support for AES ECB Andrzej Ostruszka
2018-09-21 14:53   ` [dpdk-dev] [PATCH v2 5/6] crypto/mvsam: support for crypto/auth NULL algorithms Andrzej Ostruszka
2018-09-21 14:53   ` [dpdk-dev] [PATCH v2 6/6] crypto/mvsam: add 3DES ECB to the capabilities list Andrzej Ostruszka
2018-09-25 15:24   ` [dpdk-dev] [PATCH v2 0/6] crypto/mvsam: add new features and fixes Akhil Goyal
2018-09-26 10:03     ` Andrzej Ostruszka
2018-09-26 10:51       ` Akhil Goyal
2018-10-01 13:28   ` Akhil Goyal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d53bff1e-c79d-3ca8-1428-1f3fb2dce30d@nxp.com \
    --to=akhil.goyal@nxp.com \
    --cc=dev@dpdk.org \
    --cc=mw@semihalf.com \
    --cc=nsamsono@marvell.com \
    --cc=szs@semihalf.com \
    --cc=tdu@semihalf.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).