[dpdk-dev] [PATCH] kni: fix build on RHEL 7.5

[dpdk-dev] [PATCH] kni: fix build on RHEL 7.5

[Drocula]

Signed-off-by: Drocula <quzeyao@gmail.com>
---
 kernel/linux/kni/ethtool/igb/kcompat.h | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/kernel/linux/kni/ethtool/igb/kcompat.h b/kernel/linux/kni/ethtool/igb/kcompat.h
index 40a8d99..ae1b530 100644
--- a/kernel/linux/kni/ethtool/igb/kcompat.h
+++ b/kernel/linux/kni/ethtool/igb/kcompat.h
@@ -3929,6 +3929,11 @@ static inline struct sk_buff *__kc__vlan_hwaccel_put_tag(struct sk_buff *skb,
 #endif
 #endif
 
+#if (defined(RHEL_RELEASE_CODE) && \
+	(RHEL_RELEASE_VERSION(7, 5) <= RHEL_RELEASE_CODE))
+#define ndo_change_mtu ndo_change_mtu_rh74
+#endif
+
 #if LINUX_VERSION_CODE < KERNEL_VERSION(4, 8, 0)
 #define HAVE_PCI_ENABLE_MSIX
 #endif
-- 
1.8.3.1

Re: [dpdk-dev] [PATCH] kni: fix build on RHEL 7.5

[Ferruh Yigit]

On 8/6/2018 1:06 PM, Drocula wrote:
> Signed-off-by: Drocula <quzeyao@gmail.com>

+1 for fixing build error, hence
Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>

But it would be better to have more detail on the build error, why and when this
change required in RedHat side, it would be good if this information can make on
time, but not I am for still getting the patch.

Also we require "Name Surname" syntax for sign off, can you please provide this.

Thanks,
ferruh

Re: [dpdk-dev] [PATCH] kni: fix build on RHEL 7.5

[Drocula]

This patch Fix compilation errors on Centos 7.4 when
CONFIG_RTE_KNI_KMOD_ETHTOOL is set to 'y'.

On Thu, Aug 9, 2018, 17:59 Ferruh Yigit <ferruh.yigit@intel.com> wrote:

> On 8/6/2018 1:06 PM, Drocula wrote:
> > Signed-off-by: Drocula <quzeyao@gmail.com>
>
> +1 for fixing build error, hence
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
>
> But it would be better to have more detail on the build error, why and
> when this
> change required in RedHat side, it would be good if this information can
> make on
> time, but not I am for still getting the patch.
>
> Also we require "Name Surname" syntax for sign off, can you please provide
> this.
>
> Thanks,
> ferruh
>

Re: [dpdk-dev] [PATCH] kni: fix build on RHEL 7.5

[Drocula]

Sorry for my mistake,
This patch  fixes compilation errors on Centos 7.5 when
CONFIG_RTE_KNI_KMOD_ETHTOOL is set to 'y'.
On RHEL75 ndo_change_mtu has changed to ndo_change_mtu_rh74.

See commit 37d477b6863e5c06e20be434b559d3a03d89f46a

-- Drocula Lambda

Thanks

On Aug 9, 2018 18:25, "Drocula" <quzeyao@gmail.com> wrote:

This patch Fix compilation errors on Centos 7.4 when
CONFIG_RTE_KNI_KMOD_ETHTOOL is set to 'y'.

On Thu, Aug 9, 2018, 17:59 Ferruh Yigit <ferruh.yigit@intel.com> wrote:

> On 8/6/2018 1:06 PM, Drocula wrote:
> > Signed-off-by: Drocula <quzeyao@gmail.com>
>
> +1 for fixing build error, hence
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
>
> But it would be better to have more detail on the build error, why and
> when this
> change required in RedHat side, it would be good if this information can
> make on
> time, but not I am for still getting the patch.
>
> Also we require "Name Surname" syntax for sign off, can you please provide
> this.
>
> Thanks,
> ferruh
>

[dpdk-dev] [PATCH v2] kni: fix build on RHEL 7.5

[Drocula]

This patch fixes compilation errors on Centos 7.5 when
CONFIG_RTE_KNI_KMOD_ETHTOOL is set to 'y'.
On RHEL75 ndo_change_mtu has changed to ndo_change_mtu_rh74.

See commit 37d477b6863e5c06 ("kni: fix build on RHEL 7.5")

Signed-off-by: Drocula Lambda <quzeyao@gmail.com>
---
 kernel/linux/kni/ethtool/igb/kcompat.h | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/kernel/linux/kni/ethtool/igb/kcompat.h b/kernel/linux/kni/ethtool/igb/kcompat.h
index 40a8d99..ae1b530 100644
--- a/kernel/linux/kni/ethtool/igb/kcompat.h
+++ b/kernel/linux/kni/ethtool/igb/kcompat.h
@@ -3929,6 +3929,11 @@ static inline struct sk_buff *__kc__vlan_hwaccel_put_tag(struct sk_buff *skb,
 #endif
 #endif
 
+#if (defined(RHEL_RELEASE_CODE) && \
+	(RHEL_RELEASE_VERSION(7, 5) <= RHEL_RELEASE_CODE))
+#define ndo_change_mtu ndo_change_mtu_rh74
+#endif
+
 #if LINUX_VERSION_CODE < KERNEL_VERSION(4, 8, 0)
 #define HAVE_PCI_ENABLE_MSIX
 #endif
-- 
1.8.3.1

Re: [dpdk-dev] [PATCH v2] kni: fix build on RHEL 7.5

[Ferruh Yigit]

On 8/9/2018 1:09 PM, Drocula wrote:
> This patch fixes compilation errors on Centos 7.5 when
> CONFIG_RTE_KNI_KMOD_ETHTOOL is set to 'y'.
> On RHEL75 ndo_change_mtu has changed to ndo_change_mtu_rh74.
> 
> See commit 37d477b6863e5c06 ("kni: fix build on RHEL 7.5")
> 
> Signed-off-by: Drocula Lambda <quzeyao@gmail.com>

Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>

Re: [dpdk-dev] [PATCH v2] kni: fix build on RHEL 7.5

[Thomas Monjalon]

09/08/2018 14:15, Ferruh Yigit:
> On 8/9/2018 1:09 PM, Drocula wrote:
> > This patch fixes compilation errors on Centos 7.5 when
> > CONFIG_RTE_KNI_KMOD_ETHTOOL is set to 'y'.
> > On RHEL75 ndo_change_mtu has changed to ndo_change_mtu_rh74.
> > 
> > See commit 37d477b6863e5c06 ("kni: fix build on RHEL 7.5")
> > 
> > Signed-off-by: Drocula Lambda <quzeyao@gmail.com>

I am pretty sure this is not a real name.
As it is a small patch, I will forgive it.

> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied, thanks

Re: [dpdk-dev] [PATCH v2] kni: fix build on RHEL 7.5

[Thomas Monjalon]

> Signed-off-by: Drocula Lambda <quzeyao@gmail.com>

I am not sure we should accept anonymous authors.
Does it really comply with https://developercertificate.org/ ?

Re: [dpdk-dev] [PATCH v2] kni: fix build on RHEL 7.5

[Stephen Hemminger]

On Thu, 09 Aug 2018 16:03:15 +0200
Thomas Monjalon <thomas@monjalon.net> wrote:

> > Signed-off-by: Drocula Lambda <quzeyao@gmail.com>  
> 
> I am not sure we should accept anonymous authors.
> Does it really comply with https://developercertificate.org/ ?
> 
> 
> 

No we can't accept patches from pseudonym's. DCO is a legal signature
and made up names don't count.

Kernel community went through this with Solar Designer as I remember.