From: Kevin Laatz <kevin.laatz@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Richardson, Bruce" <bruce.richardson@intel.com>,
"Walsh, Conor" <conor.walsh@intel.com>
Subject: Re: [PATCH] dma/idxd: fix return value for pci device commands
Date: Wed, 8 Jun 2022 09:57:18 +0100 [thread overview]
Message-ID: <d54ed687-ba74-754d-bf15-b9b8f538a190@intel.com> (raw)
In-Reply-To: <2240626.ElGaqSPkdT@thomas>
On 08/06/2022 09:54, Thomas Monjalon wrote:
> 07/06/2022 12:56, Walsh, Conor:
>>> Subject: [PATCH] dma/idxd: fix return value for pci device commands
>>>
>>> When sending a command to an idxd device via pci bar, the response from
>>> HW is checked to ensure it was successful. The response was incorrectly
>>> being negated before being returned by the function, meaning error codes
>>> cannot be checked against the HW specification.
>>>
>>> This patch fixes the return values of the function by removing the
>>> negation.
>>>
>>> Signed-off-by: Kevin Laatz <kevin.laatz@intel.com>
>> Acked-by: Conor Walsh <conor.walsh@intel.com>
> Fixes: 9449330a8458 ("dma/idxd: create dmadev instances on PCI probe")
> Fixes: 452c1916b0db ("dma/idxd: fix truncated error code in status check")
> Cc: stable@dpdk.org
>
> Please don't forget above lines in future.
>
> Applied, thanks.
>
That was an oversight, thanks for adding!
prev parent reply other threads:[~2022-06-08 8:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-08 14:16 Kevin Laatz
2022-06-07 10:56 ` Walsh, Conor
2022-06-08 8:54 ` Thomas Monjalon
2022-06-08 8:57 ` Kevin Laatz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d54ed687-ba74-754d-bf15-b9b8f538a190@intel.com \
--to=kevin.laatz@intel.com \
--cc=bruce.richardson@intel.com \
--cc=conor.walsh@intel.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).