From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 4D530199C8; Tue, 12 Dec 2017 19:57:49 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Dec 2017 10:57:48 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,395,1508828400"; d="scan'208";a="11750785" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.241.225.33]) ([10.241.225.33]) by orsmga003.jf.intel.com with ESMTP; 12 Dec 2017 10:57:48 -0800 To: Olivier MATZ , "Mcnamara, John" Cc: Thomas Monjalon , "dev@dpdk.org" , "techboard@dpdk.org" References: <20171121195905.66410-1-ferruh.yigit@intel.com> <20171212155430.nqt27wwy4lgsgpuk@platinum> From: Ferruh Yigit Message-ID: Date: Tue, 12 Dec 2017 10:57:48 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20171212155430.nqt27wwy4lgsgpuk@platinum> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [dpdk-techboard] [PATCH] doc: update contribution guideline for dependent work X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Dec 2017 18:57:50 -0000 On 12/12/2017 7:54 AM, Olivier MATZ wrote: > Hi, > > On Mon, Dec 11, 2017 at 02:26:34PM +0000, Mcnamara, John wrote: >> From: Yigit, Ferruh >>> Changing some part of the libraries but not updating all dependent code >>> cause maintenance problems. >>> >>> ... >>> >>> Signed-off-by: Ferruh Yigit >>> >> >> >> integration testing. >>> >>> +* If changes effect other parts of the project, update all those parts as >>> well unless updating requires special knowledge. > > I feel that "requiring special knowledge" is a bit blury. Yes it is, but hard to define where to put the line. My point is if author has enough knowledge to go and update dependent part, please do so. > Shouldn't we add some > examples? Typically, I'm thinking about changes in ethdev that imply updating > the PMDs. Any opinion for this use case? Overall many libraries to PMDs fit into this. eal/mbuf/ethdev -> PMD changes. I think, the dynamic logging update in the other libraries and PMDs should be done with the original patch, adding dynamic logging to any library doesn't require library specific information, but agree this is more work. For new ethdev offload method, I believe it fits into more gray area, it may be possible to update PMDs to use new offloading method but some part PMDs can be challenging. Converting flow director filtering to the rte_flow filtering is something I believe fair to expect from PMD owner instead of rte_flow author. >