Re: [dpdk-dev] [PATCH] common/cnxk: align npa stack to roc cache line size

[Ferruh Yigit <ferruh.yigit@intel.com>]

On 8/30/2021 2:52 PM, Ashwin Sekhar T K wrote:
> NPA stack should be aligned to ROC cache line size.
> 

Can you please document the long versions of 'NPA' & 'ROC' abbreviations?

Also for the patch title, since abbreviations needs to be uppercase, to automate
the check for these abbreviations, can you please add them to
'./devtools/words-case.txt' in separate patch.

And can you add some more context on the reasoning of the change, why it should
be aligned to cache line?
What is the impact user/application sees if it is not aligned, and after aligned?

Thanks,
ferruh

> Fixes: f765f5611240 ("common/cnxk: add NPA pool HW operations")
> 
> Signed-off-by: Ashwin Sekhar T K <asekhar@marvell.com>
> ---
>  drivers/common/cnxk/roc_npa.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/common/cnxk/roc_npa.c b/drivers/common/cnxk/roc_npa.c
> index d064d125c1..a0d2cc8f19 100644
> --- a/drivers/common/cnxk/roc_npa.c
> +++ b/drivers/common/cnxk/roc_npa.c
> @@ -194,7 +194,7 @@ npa_stack_dma_alloc(struct npa_lf *lf, char *name, int pool_id, size_t size)
>  {
>  	const char *mz_name = npa_stack_memzone_name(lf, pool_id, name);
>  
> -	return plt_memzone_reserve_cache_align(mz_name, size);
> +	return plt_memzone_reserve_aligned(mz_name, size, 0, ROC_ALIGN);
>  }
>  
>  static inline int
>