From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 67848A0C45; Thu, 16 Sep 2021 17:16:02 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F07D14069E; Thu, 16 Sep 2021 17:16:01 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id AA42C40151 for ; Thu, 16 Sep 2021 17:16:00 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10109"; a="209816803" X-IronPort-AV: E=Sophos;i="5.85,298,1624345200"; d="scan'208";a="209816803" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Sep 2021 08:15:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,298,1624345200"; d="scan'208";a="516806290" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by orsmga001.jf.intel.com with ESMTP; 16 Sep 2021 08:15:58 -0700 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 16 Sep 2021 08:15:57 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Thu, 16 Sep 2021 08:15:57 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.177) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Thu, 16 Sep 2021 08:15:57 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hbbwlyzc3Y+r6SIqsobjGEFVRhS3PvgI4jXV1/3V5uu7ciRsHFwjBbuTcfLdzUtWKA+xRBODTHMC0DB6wY9ZoH+ik0N8E1l8lr388w6I0gnBUZRxy4r/v0m/8c1SZFe5I0BMMMNfg0d5LIyJ2dH11M4E27u0Rw1DkBYCU9ISOclUlzMpYO3nbNB0TKsggUEhGHXGIIB3UwCRBSvdAkVGwtO+owfwr5dQW+VGwBoJBbqlbwAPU49BlxpRouNwKYtNuz7iOeaQmthKuXNcAPnvp1gwmjUzCgLFeFmCbfPj+BWr9OI9FxZqMz86BVgA7N0upIRTQDy7+U9+m9ALYn7xKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=mgdQn405TJsDRjsjy5q7ysqAA64+vJAvgZkYtn/QwwA=; b=AcJs7O4dCeBwWip9pkuE+yoTgds32fHyFV5ZrEniC0j6H6dCrCLoeu41Vaier31Wp9f0Sj8DPUOhd8mUopY9Z7MSfaPFrS+e3YsPTCsF86mQk1RyJGL6QxM6/hRnimVytlso0adABnUUkz7DbDzmTH210EHnDMOcYEyS+E8UA6LdNkfTwrLMgQmDH1niManxwYqer1Bx43UZaSvR7lXxt7XGFTM5aH6QnmgL3a0aoyNNkY4Lx8+rvnCgWtAaQglX8nmjY1a450Mz3ktLvKhDMAjfHn9yuhkOa6J8DUqEuOaawIoj7z9ik82BrkwzkAdlJ297hZ7Hg3wwv5ZPeNk8Iw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mgdQn405TJsDRjsjy5q7ysqAA64+vJAvgZkYtn/QwwA=; b=VT1GjzGFzm6dEHCjxtoKoQMmDnAKTIf8sT7fprv7xEJXNgG/D8Hu18sYXIGVPc/RBuMPAPyN8Wx5XqQ2uyqLna/4rWNLdywLhtXtSKCPiuQwzUWIqU9cCVyRudzSW41Jpvuo9zod/tFUqYkBuHciffazNt+TOGvdIfajGaQ3EY4= Authentication-Results: marvell.com; dkim=none (message not signed) header.d=none;marvell.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB5080.namprd11.prod.outlook.com (2603:10b6:510:3f::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.14; Thu, 16 Sep 2021 15:15:55 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc%5]) with mapi id 15.20.4523.016; Thu, 16 Sep 2021 15:15:54 +0000 To: Ashwin Sekhar T K , CC: , , References: <20210830135231.2610152-1-asekhar@marvell.com> From: Ferruh Yigit X-User: ferruhy Message-ID: Date: Thu, 16 Sep 2021 16:15:49 +0100 In-Reply-To: <20210830135231.2610152-1-asekhar@marvell.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DB6PR0402CA0015.eurprd04.prod.outlook.com (2603:10a6:4:91::25) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB6PR0402CA0015.eurprd04.prod.outlook.com (2603:10a6:4:91::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.16 via Frontend Transport; Thu, 16 Sep 2021 15:15:53 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 444fdacb-8146-4580-b737-08d97924e0c2 X-MS-TrafficTypeDiagnostic: PH0PR11MB5080: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2rm/DGwJXGGR/hkjgAhYqbskW2TUjKv7384/hahqNY4MwOllchgvwS3QkTjTp72ZoaLE2VR/gImzMfVuYFKTZ05rNLP2cUGsjDi/8G0+YEagGn4BAqhkYvuFDP1vOdq0LXLqQ+Zfs2psU6hIzo/+ruaYvyLblqFNEcTFmmVd/LyHK1eyE26/Y7p8mZINfyC7/MbKBerR3Wz+P294LxjAVA4LltOw6Es2B2mvyDk/vrIJKvBECPGKjO9V2QziFAS2E+sHUIpNZXpFGJnKZqU+U9+YQnFRr+Q7tdSYcscZoX4Xr85sDt3x2P20ofwesPft5JIocI1AqZ5ovJHulKrBZP6zWF6+1RTcqyTj4WwxWkzh52/iiXC8MPdo5RIL8Ozhb15MI5iLejlFblOUGI6dnZiY9vArMN8PtoUNeip9eP7ky3xWmIcS9Sg9/xEWbjBrpRQ0yRiUA06kVns14+D9nxqQuAdFC5Hf9qJyqfYkUC/dayBdoMs2VZbI2ErdOBNDJGPaFMucX8bQD/x4hvh5e/rUBdBAqOk00+fLRTEzuVrvOkEnLD2hCc9iUr+Go/NCjwD1o1eM6DErrvTbNw3st4pCwozlwF9Yp5/fzs7gdRmHDfXh+Yo3dOrKk7k50qtlRTYnf+0f2S+zYy5yI7XAPWPdP5ne42g/DTk4/826u8l9XxakEjblAyWw95rccAnVJiwLO0uG+QoX1HkuTmHo5w== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(346002)(136003)(366004)(376002)(396003)(8936002)(26005)(83380400001)(5660300002)(478600001)(186003)(2906002)(86362001)(6486002)(31686004)(66946007)(44832011)(36756003)(6666004)(53546011)(66556008)(66476007)(8676002)(38100700002)(2616005)(956004)(31696002)(316002)(16576012)(4326008)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eHRvMWJ1cTZOS3k4bVM4V2MxcUEvQVhhaTRTbW1tbDQ0eTEzQlE5eXVXTXRG?= =?utf-8?B?S1VIT1dRSVpCL2ZNbXVESVoyR1kvSEdOaHlaWHRjSlpoZUtjbmFxdldTcUhh?= =?utf-8?B?bm9lbDE0OXZqVVIwZE1DaXhBUjlqSDl4YlJkQi9aM3h1TFBNMXJGUFJQZ1FE?= =?utf-8?B?RWhNd1JlV2hjSlpNNm5NKzdTTThaTzlqOVVSbVlIL21ZWXZRK0lwQWVsUDd4?= =?utf-8?B?VGVrK2E3UWpqK2IwNURZV2ZFeWIwQ2MwS3lGSjZicERubmxJQXhmZEI3SkxY?= =?utf-8?B?bEVna3MxNm5HNitOaWU3dE5oMHN0YU5RWFRqb3hxeld2bjdaVmtKQks5SzRR?= =?utf-8?B?NUF5OEhIb2ZKSmI1c0xKZ01DZk1IRFhmcVMzMTY2SzRaWGZ4OWNxN1dUYjNh?= =?utf-8?B?czlFdnRlcUMvTkFvRTJWdlpmbjlJRjNXVURxZXZBSi9hN2ZFS240V1RUdU8v?= =?utf-8?B?S1JWbWJRNzM3VUVJNUwyaU9odFNIL2s1UkJGSEFSYUN3bU5JMFpYY1hrR2FK?= =?utf-8?B?WkFsRVNpUnp6bm4yZm9VZ2xOSFRER0I1ODRsSmhJZDFNY0FneGtUbExIc3RQ?= =?utf-8?B?YS9kSFl0RWtEak9IUWsrQWhuYVRONnNEdy83emJKa2t6cklUQTZ4ZGVKc29T?= =?utf-8?B?aFJmTEFHMFRVU0cyaXlyaHp4Umo1S2RuVlNlSDdYUDYrNVBxYmM0bWFZdGZZ?= =?utf-8?B?SzN2Q0RxUnl5YmROQVI3ZDlGK1l2eDMxTkdZZHA3Nmc0L3N4eHJzNHR1Sklw?= =?utf-8?B?WVptczRTSXY2MHg2TGNlb2loM3J2aEU5QUF1TjdBUW50bEFXQXlxUUtjY090?= =?utf-8?B?WDlwS29DUVAxSGNFM1FwOUZYNXNSbUU0bmZqQnJwbzVkU0RnOGxUN3dad2x6?= =?utf-8?B?K25xcERacW9Pd0NrOHJJalY1T1pCMTJqSHdYYmJzVkZ6NFIrWklKQ1JUbksv?= =?utf-8?B?cFlHdFpSamw3YlRzSmNxWW15cjJzZDVjbWdlSysvS2NySGNCdTIxcWVLTjZx?= =?utf-8?B?SkM0TXJKRzF6WlJ1M3Z1OUxPOFhOU1JLMDduSm5nd2hnQ1BFM2hNVmZYb0F1?= =?utf-8?B?NG5NS3RmeTRyZ1ZJYnFUYUhSMG55dGxvS3VYTFZ1M3FhS0RVNWF3QWVRZFV4?= =?utf-8?B?MGhxNXVKYjZ6SlFOdnNiaUpZa0pRRHhFa00rMGFBWHdCZW45dmtFUkZYMy83?= =?utf-8?B?VXdWdkJpdSt3UXpxWXE3eis2WTQva2Z2VjloNXlEaWJScWl5eTJSOGtEV25Y?= =?utf-8?B?ZWhDUnJnMmxtSC9KR0g3NXo3YS9uSTdVcVFnM2s2SUM1MDFmUURIeFNxREg3?= =?utf-8?B?SlU1QTR6cStoOFI3TnFUeERPNFlCVVJGNUU5SGVJTy9KUnRRNmdXR1Rmbzd6?= =?utf-8?B?WlZXUWpqNURIeUNUQ0dnMDlNMWFLakFnd3BocmdpNnRTMDBNRkNwV0lZVTlj?= =?utf-8?B?YndCMVlvVlNLVFhveWJZQ3pNUEZaajRXaTZWZXpwVlpuT3c3eHZkQ1p6TUJq?= =?utf-8?B?UXl5NGhJYm9GblQ0SUZ2dTE3V2dEYW8yS21NOEhBcTdzWEJsaDFDeHB3VlRD?= =?utf-8?B?ZHNDTWErMkhpMXgydUZaemludU9RczczdUtaODVXcGROT0o4eEREU2JuaFUw?= =?utf-8?B?NCtCM3hhSHFxVUtXTlZocUZZWExDeEwxbmFaazV5cmd4LzBUVWNqS3NkTENs?= =?utf-8?B?UnNuTHlWVW5XcFVWa0dIeGhhY2xKQWNKdmNvbFI5Skp1NjZlRm1qb2dGVGk5?= =?utf-8?Q?PGr+XqmEdPl4CxmPSgYsT6TjYTC0iT4fFhzn7xS?= X-MS-Exchange-CrossTenant-Network-Message-Id: 444fdacb-8146-4580-b737-08d97924e0c2 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Sep 2021 15:15:54.8676 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: GYTGsEjVX0WZ05LAqDUUp9NsgNcbgtQc5DhWDYBYS/Mhm9WNOHijXmUQb3S6GZJylDgxqFyH9luTHnzJU1fu/Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5080 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] common/cnxk: align npa stack to roc cache line size X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 8/30/2021 2:52 PM, Ashwin Sekhar T K wrote: > NPA stack should be aligned to ROC cache line size. > Can you please document the long versions of 'NPA' & 'ROC' abbreviations? Also for the patch title, since abbreviations needs to be uppercase, to automate the check for these abbreviations, can you please add them to './devtools/words-case.txt' in separate patch. And can you add some more context on the reasoning of the change, why it should be aligned to cache line? What is the impact user/application sees if it is not aligned, and after aligned? Thanks, ferruh > Fixes: f765f5611240 ("common/cnxk: add NPA pool HW operations") > > Signed-off-by: Ashwin Sekhar T K > --- > drivers/common/cnxk/roc_npa.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/common/cnxk/roc_npa.c b/drivers/common/cnxk/roc_npa.c > index d064d125c1..a0d2cc8f19 100644 > --- a/drivers/common/cnxk/roc_npa.c > +++ b/drivers/common/cnxk/roc_npa.c > @@ -194,7 +194,7 @@ npa_stack_dma_alloc(struct npa_lf *lf, char *name, int pool_id, size_t size) > { > const char *mz_name = npa_stack_memzone_name(lf, pool_id, name); > > - return plt_memzone_reserve_cache_align(mz_name, size); > + return plt_memzone_reserve_aligned(mz_name, size, 0, ROC_ALIGN); > } > > static inline int >