From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 1380F4CBD for ; Thu, 20 Sep 2018 13:29:53 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Sep 2018 04:29:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,398,1531810800"; d="scan'208";a="264244228" Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.237.220.55]) ([10.237.220.55]) by fmsmga005.fm.intel.com with ESMTP; 20 Sep 2018 04:29:51 -0700 To: Bruce Richardson Cc: dev@dpdk.org, thomas@monjalon.net, xuemingx.zhang@intel.com References: <20180920112528.GB19844@bricha3-MOBL.ger.corp.intel.com> From: "Burakov, Anatoly" Message-ID: Date: Thu, 20 Sep 2018 12:29:51 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180920112528.GB19844@bricha3-MOBL.ger.corp.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] eal/bsd: fix compile issue due to unused variables X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Sep 2018 11:29:54 -0000 On 20-Sep-18 12:25 PM, Bruce Richardson wrote: > On Thu, Sep 20, 2018 at 10:34:46AM +0100, Anatoly Burakov wrote: >> Fixes: 1009ba1704f9 ("mem: add internal API to get and set segment fd") >> >> Signed-off-by: Anatoly Burakov >> --- > > Sorry, I missed your patch by about 1 hour - hadn't got through my mail > fully when sent mine. > I think you could do with a couple of other fixes tags on it, just take > them from my patch. Otherwise: > > Acked-by: Bruce Richardson My patch had one too few Fixes tags, yours had one too many :) I'll resubmit a v2 with new extra tags and probably changed commit message. > >> lib/librte_eal/bsdapp/eal/eal_memalloc.c | 8 +++++--- >> 1 file changed, 5 insertions(+), 3 deletions(-) >> >> diff --git a/lib/librte_eal/bsdapp/eal/eal_memalloc.c b/lib/librte_eal/bsdapp/eal/eal_memalloc.c >> index 06afbcc99..a5847f0bd 100644 >> --- a/lib/librte_eal/bsdapp/eal/eal_memalloc.c >> +++ b/lib/librte_eal/bsdapp/eal/eal_memalloc.c >> @@ -49,19 +49,21 @@ eal_memalloc_sync_with_primary(void) >> } >> >> int >> -eal_memalloc_get_seg_fd(int list_idx, int seg_idx) >> +eal_memalloc_get_seg_fd(int list_idx __rte_unused, int seg_idx __rte_unused) >> { >> return -ENOTSUP; >> } >> >> int >> -eal_memalloc_set_seg_fd(int list_idx, int seg_idx, int fd) >> +eal_memalloc_set_seg_fd(int list_idx __rte_unused, int seg_idx __rte_unused, >> + int fd __rte_unused) >> { >> return -ENOTSUP; >> } >> >> int >> -eal_memalloc_get_seg_fd_offset(int list_idx, int seg_idx, size_t *offset) >> +eal_memalloc_get_seg_fd_offset(int list_idx __rte_unused, >> + int seg_idx __rte_unused, size_t *offset __rte_unused) >> { >> return -ENOTSUP; >> } >> -- >> 2.17.1 > -- Thanks, Anatoly