From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 6F4558E72 for ; Tue, 17 Apr 2018 16:02:15 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Apr 2018 07:02:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,463,1517904000"; d="scan'208";a="46853308" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.237.220.128]) ([10.237.220.128]) by fmsmga004.fm.intel.com with ESMTP; 17 Apr 2018 07:02:11 -0700 To: Thomas Monjalon , zhouyangchao Cc: dev@dpdk.org, bruce.richardson@intel.com References: <6821483b-30f3-ac79-208c-406fb46685af@intel.com> <1581625.s6OpJcviaZ@xps> From: "Burakov, Anatoly" Message-ID: Date: Tue, 17 Apr 2018 15:02:11 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <1581625.s6OpJcviaZ@xps> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] mem: memory leaks of hubedir caused by strdup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Apr 2018 14:02:16 -0000 On 17-Apr-18 12:47 PM, Thomas Monjalon wrote: > I see no reason to accept this patch, replacing strdup by snprintf, > given that we have strlcpy. > Please do a v3 with strlcpy. OK. Please also fix the typo in patch headline :) -- Thanks, Anatoly