From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id A50D32B8C for ; Wed, 7 Dec 2016 16:02:33 +0100 (CET) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga102.jf.intel.com with ESMTP; 07 Dec 2016 07:01:47 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,310,1477983600"; d="scan'208";a="909712097" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.29]) ([10.237.220.29]) by orsmga003.jf.intel.com with ESMTP; 07 Dec 2016 07:01:46 -0800 To: Wenzhuo Lu , dev@dpdk.org References: <1480637533-37425-1-git-send-email-wenzhuo.lu@intel.com> <1481081535-37448-1-git-send-email-wenzhuo.lu@intel.com> <1481081535-37448-23-git-send-email-wenzhuo.lu@intel.com> From: Ferruh Yigit Message-ID: Date: Wed, 7 Dec 2016 15:01:45 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <1481081535-37448-23-git-send-email-wenzhuo.lu@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 22/32] app/testpmd: use multicast promiscuous mode on i40e X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Dec 2016 15:02:34 -0000 On 12/7/2016 3:32 AM, Wenzhuo Lu wrote: > Add testpmd CLI to set VF multicast promiscuous mode on i40e. > > Signed-off-by: Wenzhuo Lu > --- > app/test-pmd/cmdline.c | 86 +++++++++++++++++++++++++++++ > doc/guides/testpmd_app_ug/testpmd_funcs.rst | 8 +++ > 2 files changed, 94 insertions(+) > > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c > index d39712e..7e7a016 100644 > --- a/app/test-pmd/cmdline.c > +++ b/app/test-pmd/cmdline.c > @@ -407,6 +407,9 @@ static void cmd_help_long_parsed(void *parsed_result, > #ifdef RTE_LIBRTE_I40E_PMD > "set vf unicast-promisc (port_id) (vf_id) (on|off)\n" > " Set unicast promiscuous mode for a VF from the PF.\n\n" > + > + "set vf multicast-promisc (port_id) (vf_id) (on|off)\n" > + " Set multicast promiscuous mode for a VF from the PF.\n\n" Why not "allmulti" instead of multicast-promisc? Also same comments as previous patch for help_str and documentation. <...>