From: "Varghese, Vipin" <vipin.varghese@amd.com>
To: fengchengwen <fengchengwen@huawei.com>,
dev@dpdk.org, stable@dpdk.org, honest.jiang@foxmail.com
Subject: Re: [PATCH] doc: update size parameter details
Date: Thu, 7 Mar 2024 21:20:04 +0530 [thread overview]
Message-ID: <d61003f2-42ad-48d2-9187-c4a785cedbc3@amd.com> (raw)
In-Reply-To: <3dc0dccf-190c-0588-1927-ecb865400d30@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 1390 bytes --]
<snipped>
>> - The size of the memory footprint.
>> + The size of the memory footprint in megabytes (MB) for source and destination.
> I prefer not add "for source and destination", it makes sense without this, and maybe future test like fill don't have source buffer.
The current dma-perf application, makes use of memory in MegaBytes for
combined buffer of source and destination. That is, if the total memory
is 10MB
this is split into 5MB for source buffer and 5MB for destination buffer.
dma-fill option is not enabled or used in dma-test-perf yet. I would
recommend, once the feature is added `both fill-pattern and mem_size
will get added`.
As it is not available this is not applicable. Hence I am do not agree
`it makes sense without this` instead it is needed to be clear.
>
>> ``buf_size``
>> - The memory size of a single operation.
>> + The memory size of a single operation in bytes (B).
>>
>> ``dma_ring_size``
>> The DMA ring buffer size. Must be a power of two, and between ``64`` and ``4096``.
>>
> BTW: Could you please also modify the app/test-dma-perf/config.ini (which also missing this)
dma-perf documentation is updated with right message. Yes, I can
understand end-user may also refer to the comments in `config.ini`. So
yes i can shared v2 with same message as v1
`memsize is combination of source and destination in MB`
>
> Thanks
[-- Attachment #2: Type: text/html, Size: 2508 bytes --]
next prev parent reply other threads:[~2024-03-07 15:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-12 10:45 Vipin Varghese
2024-03-06 6:08 ` Varghese, Vipin
2024-03-07 13:27 ` fengchengwen
2024-03-07 15:50 ` Varghese, Vipin [this message]
2024-03-12 4:22 ` [PATCH v2] " Vipin Varghese
2024-03-12 6:07 ` fengchengwen
2024-03-12 6:17 ` fengchengwen
2024-03-18 2:47 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d61003f2-42ad-48d2-9187-c4a785cedbc3@amd.com \
--to=vipin.varghese@amd.com \
--cc=dev@dpdk.org \
--cc=fengchengwen@huawei.com \
--cc=honest.jiang@foxmail.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).