From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8CD8D43C0C; Thu, 7 Mar 2024 16:50:24 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6950B42EF0; Thu, 7 Mar 2024 16:50:23 +0100 (CET) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2046.outbound.protection.outlook.com [40.107.94.46]) by mails.dpdk.org (Postfix) with ESMTP id 0E3E240272; Thu, 7 Mar 2024 16:50:22 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Qz3FMClVYu5mMjrM4+jtGEHtNYhYEgr2I0f+OONRuLUyg+q3j9/XKkbL3xPYOofIrGvUpGSKdvD5Duv/5ufDMWGBBRCHnRetiIDFIHD4WmbLfY+QFuT1GtYqjCt3sfMvL+2AzbaO7Kgb6KH0TX3wjkHBT2x0dTrDfL0mTTB6DQ5p0JimWBTh37AJ+TMGN3t9Em4LtWJVuQXXA5g0SbSdm2JOFgOAYqwhe3vCcCDtvlaaT8XAERuSpgaR9/U43Xmv6Hy5eLz/NodqrtlZZyv4VS4Y4DvtSR/Te46Oct8/LRIwqPLYNT74jTpRsvAUC7OhIykBiMyqPvzttwuYmgFbzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eAJymCyxpnDu7QC1pQuZ6/14duC8GO1Yds+lGhSCzuY=; b=RcASEBLKU+FNJPCvvzCt0279aMYbNsDvEGmcLLs67zBvxlVPNXdgXW5D+qEYdLPbN1DgHGKMu4mGWR2z4DUZxwRjwrXyMJJcAQ2FthiLKZFfV3TdoK6t7d1YpkbPK/Sa8Z6bGqf032UU+CSRKafO5t5UAqLVq8ibpr+gI+7tWsZJkZVHX27HkOQupUp2Yx0eKuv3JAm8KqdR5dyWs4rxjevIjOT0X94mnYO15SMxZDnDTkfow9/8HGPb7ncSWGS3WLviyK5mN0E4E5rB2TyNjZfmwn3iYQwhvURsC+rHYqHagBuLY/LlIZiIozZ+ssDyPYtlu7Rbpc5c+mGkUgJy2g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eAJymCyxpnDu7QC1pQuZ6/14duC8GO1Yds+lGhSCzuY=; b=2IXgpYL9GWm2TSCmW3pN7yZvUjSKAqCmd/eRsprZE0HBXi0F3JR4fDpFsBjGfnGAJTmbo1Z/DO5L14MSEVwh0EWk3WxxRyC1lEgM73HVKT8Zbt3Yt4wI3/690wSmwTUUXaZEAqEgiLAElxXSMizJdWUesWdPYFAUrRNjszLcy8E= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from PH7PR12MB8596.namprd12.prod.outlook.com (2603:10b6:510:1b7::6) by CY8PR12MB7196.namprd12.prod.outlook.com (2603:10b6:930:58::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7316.33; Thu, 7 Mar 2024 15:50:12 +0000 Received: from PH7PR12MB8596.namprd12.prod.outlook.com ([fe80::5f0d:af7:7f6b:9b9c]) by PH7PR12MB8596.namprd12.prod.outlook.com ([fe80::5f0d:af7:7f6b:9b9c%5]) with mapi id 15.20.7362.024; Thu, 7 Mar 2024 15:50:12 +0000 Content-Type: multipart/alternative; boundary="------------YbHv90RhXALc51lPBaszUXMS" Message-ID: Date: Thu, 7 Mar 2024 21:20:04 +0530 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] doc: update size parameter details To: fengchengwen , dev@dpdk.org, stable@dpdk.org, honest.jiang@foxmail.com References: <20231212104508.1941-1-vipin.varghese@amd.com> <3dc0dccf-190c-0588-1927-ecb865400d30@huawei.com> Content-Language: en-US From: "Varghese, Vipin" In-Reply-To: <3dc0dccf-190c-0588-1927-ecb865400d30@huawei.com> X-ClientProxiedBy: PN2PR01CA0141.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:6::26) To PH7PR12MB8596.namprd12.prod.outlook.com (2603:10b6:510:1b7::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH7PR12MB8596:EE_|CY8PR12MB7196:EE_ X-MS-Office365-Filtering-Correlation-Id: e00ddde9-584d-46ef-4507-08dc3ebe462b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: R/vakCx7orddB4UrHCJsDlIDE2cp2JYSu/r48stcZ0VN3ccZxhV7Xx4H5L2vO44NliQt4IFuM6jbxsqt/5L5jRB7flfMNfssYruX6Y2J3NhjztvgDGWTGY9r38fngYdSWViFelENRemFHYX6XTeB2uqmVgCF8lXYy2E0/UifcOcS9oqG/TOAiakN8ZtbhVf20h1sOOkvigWQUKl/a4IwVNEsJBFPmoYSPfSTyDxNHuLgptZj8p6l4ATpw+fS3DKuOZcg9voZ+VQ/gxXk0L7HhYz5SPUzgFKP9dyFqo8MhLGpUb0IFQWDzYHBmFJ5bON9wWYx3C8bo+7HYbWO1Z9ElU2A6jtBc45v75gNL6Plcl+wbRpwFqBYkPteLU3TjtN9q2v7+XdkcflfeNINrQurfH4DJByiLkzWdmVpWWwBZuO7vdBqnGKIQ6KsHmBrxSozcOhsP6fIIuK7cOCDLrC4BeRky7fTWBn+H+bJKSp2OmdFcqMhGqVFykmNgTLC/J0Nz6DCA3w0dysGt2Eqn4sRR2W57mVDtc4nyW+aGDF7LcWF9v7WNbP3VoNkv7vZn2tZoxbxwlxWo/hgRbS22btkKnN0tjvXNQd7z06ULPk5xYpZswXZwvIVFHR5w4uxwJDOateG4RAqDnc/HJoe/5qnHyApj3jWKqXaqtEEgcrgj1Q= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH7PR12MB8596.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376005); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YlR1S2x0U1BqVnlOMFdaQWdMaTEyZjllU1JneTJXTUhoajlvUnFGN2JjWVFO?= =?utf-8?B?WUc3b200WHY4M1h1Q2RsRy9KWU9TdjJhdG9nMWgyNW5YeFhvRjBZQU9mVWh5?= =?utf-8?B?Q1RIUG1BSWJJQzVDcGFYYVYxL2liV1hleXg2RFh6Rk44UDduOSsvVHp4QXA2?= =?utf-8?B?dUg4a1lZdzlnNjhZZDUyaUVTVlV3YTJvSXhLa2EyOVdIZXdiQXhFOERONnBn?= =?utf-8?B?RnlSTS82NThUSGNuUUpuVzgzeHZiRzhqU0ZrbHJGcTUyUitmbGFKQkw5c3lo?= =?utf-8?B?ZTNFbWhtRlE5dGtXdTFreDFycEFFUEZiSERWMjE5cUFaeDg2RkNURFRCY2xQ?= =?utf-8?B?OFBPY1ZUd3l2bEZHN1F6ZVVJemVkTVp2ZlVSQzlGbnVXRm9DZ3RoeXZzVDBK?= =?utf-8?B?cThSdkVoNFByNzBLU0VNVTl6NVgxbXpzUDJnZG5TclFQS2tGYTNFdUdMQ0Zj?= =?utf-8?B?YXQxendIN2UxWXU4NHBMZHpFZ3RpeFFXWk03bXhWZ3JTdVE4bzh0clhVQVE1?= =?utf-8?B?MmtZMGlnaU1sVWdYc244MU1rVHhSUmZJQlcyeitLK2pOVFFiZHNqSEJYb3hq?= =?utf-8?B?QVNwNVI1K2h3UFpKNVBuUW0xRlZwRzhSbmQ2WXNFOXNrS3MweXFmOVRETGdY?= =?utf-8?B?M091UGM2d3pDOFBORzA3YVJvUi84L2ZkOHZacmhiRG9GWlZIQXpyUHUwcEEx?= =?utf-8?B?SWVuenN0Q1Zya3J0VEloYitNajd3K2tFSWQ0NXh2SFdEWmRoRWtEc3Flc2F3?= =?utf-8?B?V3BudWVUb3hsYUZkVzNUcHJNbGE4dWZuQ3NCaWZ0dlRrZUp2b0wyeU1FZ09G?= =?utf-8?B?SEdRTXRMUXBpOFhCdmxvbjJRcmdSZGtlTExvU01uejZEdDcvbUdxYmkwQmYx?= =?utf-8?B?emZaSkwzbFkyMGx4L3FFN1ZzbEJNcVF6YmQvLzFYRlJXRGJuOG1oRGp3ME5D?= =?utf-8?B?L0c2eFFXeEI0dXBrS1JFc2xSdVc5eUJ5M2JpOXQxTlBHNWVnSnZva0FVL25V?= =?utf-8?B?VHdvWWRndjlIWU5kWkFFTE9HY1pHYUI4Mm5GUGVZTnlRdlRKMFo5MnlMdVN5?= =?utf-8?B?Sm5Lem1QdVR0VWE3cEthcmNOVFZYRWZVOEVtN3UzVzhoSmh1WFlyNGN5eU5O?= =?utf-8?B?dzFLbUQ2TkhDYU03dExvek0zeTRMckR2OU9XTTk1YzVKUG95ODEvVjdDUWpX?= =?utf-8?B?VG1Nak1vMTIxS2hnWlVrckpHTUg4OXdHdU54MnhZWm1vSGs1WW5TcklWYnUw?= =?utf-8?B?TmxmR01YMmNicGZEelM1Z2ZmVFZCQW5yc051Y1IzZmpheE9ZeldEMVNpZWpF?= =?utf-8?B?S0txNGxPaGhoaUxxd1VSMXN0cUNhemNXcllYTHhROUNJZ0Y1MHc2amxPZ2Z6?= =?utf-8?B?M244alJSSlFqTWxTNUNtODIwais1NnpqWmVSOGVKMjJPeWt5ekxzS1hJUUNy?= =?utf-8?B?b0JCcTl5UUZMbWQrTTBESzZKWHh1RWNtTURzM2NoUUtWU3BwZVhVeTVYakNj?= =?utf-8?B?d0JhaFE2YU8rOHVYSndWRTgzK09GV1NqQmZ4RnVhOVFPSFpjNk1aSEZ6TFdQ?= =?utf-8?B?dVBnRjU2dTlxeUFUR01aUExuaE9MaU9DdzE5a3Nnb2U4Q3V4dkFleHdyYlh6?= =?utf-8?B?Q2Q1WS9NQ3lha2xuOHJ6SVg2NzdDTlVHVGRabjVTVlM0aFJZblpoaEdJNU5M?= =?utf-8?B?YlFmdHJzZzRuWXFZclJFYjZCbzQyOXIvcUhOV3lFbC9Oa3VxL2hLazBQZlh3?= =?utf-8?B?TW5xNDJhcGNIY25HMXVDSUNiaWVWR28zRnZPbUswVkNBd3dyRWF3WWVGNCtR?= =?utf-8?B?MHpwVXBMK3VxZjBtcndyb1RKcUFzQUdlRnExa1NadlNXRm1YQ3ZrNUFxcXZG?= =?utf-8?B?eU9hRWtHdDRycFBDZjZ4enM0VjFKK3doSEl5VjJpenNzckFFMU1oQjlvVTJD?= =?utf-8?B?TytJbGEzaVVwSDNXQk9FSlM5bHZwRVpxa3oyQjUzVUduS1BlZDhmMmlJZjhm?= =?utf-8?B?Mk1kMlRCUmJCUjUyQUlUWG5TdDdKZ1dEYmhnMmROaE91V0djSitFV1NnZzBB?= =?utf-8?B?c2NueXFPRk9yWDBmdEdqZ3l6RDU2dWlsd2FVck8rbk9FM3J1OXI3ckRBTUxm?= =?utf-8?Q?oPgFTvVonpN5LGp9R8D/IPyvR?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: e00ddde9-584d-46ef-4507-08dc3ebe462b X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB8596.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Mar 2024 15:50:12.2712 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Ffhy4cIlCcbW0ef43SquR+nFKyGx3cAIJezNWlnANi0to5y72VzEkw8aAKGRa3XMHJRDwLQJKwSq9o6eiuGNTg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7196 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --------------YbHv90RhXALc51lPBaszUXMS Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit >> - The size of the memory footprint. >> + The size of the memory footprint in megabytes (MB) for source and destination. > I prefer not add "for source and destination", it makes sense without this, and maybe future test like fill don't have source buffer. The current dma-perf application, makes use of memory in MegaBytes for combined buffer of source and destination. That is, if the total memory is 10MB this is split into 5MB for source buffer and 5MB for destination buffer. dma-fill option is not enabled or used in dma-test-perf yet. I would recommend, once the feature is added `both fill-pattern and mem_size will get added`. As it is not available this is  not applicable. Hence I am do not agree `it makes sense without this` instead it is needed to be clear. > >> ``buf_size`` >> - The memory size of a single operation. >> + The memory size of a single operation in bytes (B). >> >> ``dma_ring_size`` >> The DMA ring buffer size. Must be a power of two, and between ``64`` and ``4096``. >> > BTW: Could you please also modify the app/test-dma-perf/config.ini (which also missing this) dma-perf documentation is updated with right message. Yes, I can understand end-user may also refer to the comments in `config.ini`.  So yes i can shared v2 with same message as v1 `memsize is combination of source and destination in MB` > > Thanks --------------YbHv90RhXALc51lPBaszUXMS Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit


<snipped> 
-  The size of the memory footprint.
+  The size of the memory footprint in megabytes (MB) for source and destination.

I prefer not add "for source and destination", it makes sense without this, and maybe future test like fill don't have source buffer.

The current dma-perf application, makes use of memory in MegaBytes for combined buffer of source and destination. That is, if the total memory is 10MB

this is split into 5MB for source buffer and 5MB for destination buffer.


dma-fill option is not enabled or used in dma-test-perf yet. I would recommend, once the feature is added `both fill-pattern and mem_size will get added`.

As it is not available this is  not applicable. Hence I am do not agree `it makes sense without this` instead it is needed to be clear. 



 ``buf_size``
-  The memory size of a single operation.
+  The memory size of a single operation in bytes (B).

 ``dma_ring_size``
   The DMA ring buffer size. Must be a power of two, and between ``64`` and ``4096``.


BTW: Could you please also modify the app/test-dma-perf/config.ini (which also missing this)

dma-perf documentation is updated with right message. Yes, I can understand end-user may also refer to the comments in `config.ini`.  So yes i can shared v2 with same message as v1

`memsize is combination of source and destination in MB`


Thanks
--------------YbHv90RhXALc51lPBaszUXMS--