From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id D9A08567C for ; Tue, 6 Jun 2017 16:25:04 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Jun 2017 07:25:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,306,1493708400"; d="scan'208";a="270818545" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.91]) ([10.237.220.91]) by fmsmga004.fm.intel.com with ESMTP; 06 Jun 2017 07:25:02 -0700 To: Ajit Khaparde Cc: dev@dpdk.org, Steeven Li References: <20170601030232.38677-1-ajit.khaparde@broadcom.com> <20170601170723.48709-1-ajit.khaparde@broadcom.com> <20170601170723.48709-13-ajit.khaparde@broadcom.com> <8e3b1d20-dad2-53b3-a4cf-aaf0b5590212@intel.com> From: Ferruh Yigit Message-ID: Date: Tue, 6 Jun 2017 15:25:02 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v4 12/26] net/bnxt: add support to set MTU X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Jun 2017 14:25:05 -0000 On 6/6/2017 3:00 PM, Ajit Khaparde wrote: > Ferruh, if it save times, can you please do that. Done. > > Thanks > Ajit > > On Tue, Jun 6, 2017 at 7:47 AM, Ferruh Yigit wrote: > >> On 6/1/2017 6:07 PM, Ajit Khaparde wrote: >>> This patch adds support to modify MTU using the set_mtu dev_op. >>> To support frames > 2k, the PMD creates an aggregator ring. >>> When a frame greater than 2k is received, it is fragmented >>> and the resulting fragments are DMA'ed to the aggregator ring. >>> Now the driver can support jumbo frames upto 9500 bytes. >>> >>> Signed-off-by: Steeven Li >>> Signed-off-by: Ajit Khaparde >>> >>> -- >>> v1->v2: regroup related patches and incorporate other review comments >>> >>> v2->v3: >>> - rebasing to next-net tree >>> - Use net/bnxt instead of just bnxt in patch subject >> >> <...> >> >>> +int bnxt_hwrm_vnic_plcmode_cfg(struct bnxt *bp, >>> + struct bnxt_vnic_info *vnic) >>> +{ >>> + int rc = 0; >>> + struct hwrm_vnic_plcmodes_cfg_input req = {.req_type = 0 }; >>> + struct hwrm_vnic_plcmodes_cfg_output *resp = >> bp->hwrm_cmd_resp_addr; >>> + uint16_t size; >>> + >>> + HWRM_PREP(req, VNIC_PLCMODES_CFG, -1, resp); >>> + >>> + req.flags = rte_cpu_to_le_32( >>> +// HWRM_VNIC_PLCMODES_CFG_INPUT_FLAGS_REGULAR_PLACEMENT >> | >>> + HWRM_VNIC_PLCMODES_CFG_INPUT_ >> FLAGS_JUMBO_PLACEMENT); >>> +// HWRM_VNIC_PLCMODES_CFG_INPUT_FLAGS_HDS_IPV4 | >> //TODO >>> +// HWRM_VNIC_PLCMODES_CFG_INPUT_FLAGS_HDS_IPV6); >> >> Hi Ajit, >> >> Would you mind if I remove these commented code, in this patch and other >> patches, while applying? >> >> Of course it would be better if you send the new version of the patch to >> fix them, but I believe I can do this faster. Just let me know please. >> >> Thanks, >> ferruh >> >>> + req.enables = rte_cpu_to_le_32( >>> + HWRM_VNIC_PLCMODES_CFG_INPUT_ENABLES_JUMBO_THRESH_VALID); >>> +// HWRM_VNIC_PLCMODES_CFG_INPUT_ENABLES_HDS_THRESHOLD_VALID); >>> + >>> + size = rte_pktmbuf_data_room_size(bp->rx_queues[0]->mb_pool); >>> + size -= RTE_PKTMBUF_HEADROOM; >>> + >>> + req.jumbo_thresh = rte_cpu_to_le_16(size); >>> +// req.hds_threshold = rte_cpu_to_le_16(size); >>> + req.vnic_id = rte_cpu_to_le_32(vnic->fw_vnic_id); >>> + >>> + rc = bnxt_hwrm_send_message(bp, &req, sizeof(req)); >>> + >>> + HWRM_CHECK_RESULT; >>> + >>> + return rc; >>> +} >> >> <...> >> >>