From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D822543388; Tue, 21 Nov 2023 04:32:35 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C8C1D42E55; Tue, 21 Nov 2023 04:32:35 +0100 (CET) Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by mails.dpdk.org (Postfix) with ESMTP id CD7824025F for ; Tue, 21 Nov 2023 04:32:34 +0100 (CET) Received: from kwepemm000004.china.huawei.com (unknown [172.30.72.57]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4SZ8vp4yr2zMnB2; Tue, 21 Nov 2023 11:27:50 +0800 (CST) Received: from [10.67.121.59] (10.67.121.59) by kwepemm000004.china.huawei.com (7.193.23.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 21 Nov 2023 11:32:32 +0800 Message-ID: Date: Tue, 21 Nov 2023 11:32:31 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH v2 13/16] app/test-dma-perf: verify strdup return value To: Chengwen Feng , , , Cheng Jiang , Yuan Wang , Chenbo Xia , Jiayu Hu CC: References: <20231110100117.8350-1-fengchengwen@huawei.com> <20231110100117.8350-14-fengchengwen@huawei.com> From: "lihuisong (C)" In-Reply-To: <20231110100117.8350-14-fengchengwen@huawei.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.121.59] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To kwepemm000004.china.huawei.com (7.193.23.18) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Acked-by: Huisong Li 在 2023/11/10 18:01, Chengwen Feng 写道: > Add verify strdup return value logic. > > Fixes: 623dc9364dc6 ("app/dma-perf: introduce DMA performance test") > Cc: stable@dpdk.org > > Signed-off-by: Chengwen Feng > --- > app/test-dma-perf/main.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/app/test-dma-perf/main.c b/app/test-dma-perf/main.c > index e5bccc27da..339ee25eb5 100644 > --- a/app/test-dma-perf/main.c > +++ b/app/test-dma-perf/main.c > @@ -206,6 +206,8 @@ parse_lcore_dma(struct test_configure *test_case, const char *value) > return -1; > > input = strndup(value, strlen(value) + 1); > + if (input == NULL) > + return -1; > addrs = input; > > while (*addrs == '\0')