From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-BY2-obe.outbound.protection.outlook.com (mail-by2nam01on0072.outbound.protection.outlook.com [104.47.34.72]) by dpdk.org (Postfix) with ESMTP id 390402B9A for ; Sat, 7 Oct 2017 13:23:13 +0200 (CEST) Received: from BN6PR03CA0067.namprd03.prod.outlook.com (10.173.137.29) by MWHPR03MB2704.namprd03.prod.outlook.com (10.168.207.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7; Sat, 7 Oct 2017 11:23:11 +0000 Received: from BY2FFO11FD014.protection.gbl (2a01:111:f400:7c0c::117) by BN6PR03CA0067.outlook.office365.com (2603:10b6:404:4c::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7 via Frontend Transport; Sat, 7 Oct 2017 11:23:10 +0000 Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=nxp.com; monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.158.2 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.158.2; helo=az84smr01.freescale.net; Received: from az84smr01.freescale.net (192.88.158.2) by BY2FFO11FD014.mail.protection.outlook.com (10.1.14.76) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.77.10 via Frontend Transport; Sat, 7 Oct 2017 11:23:10 +0000 Received: from [10.214.249.80] ([10.214.249.80]) by az84smr01.freescale.net (8.14.3/8.14.0) with ESMTP id v97BM7j4002471; Sat, 7 Oct 2017 04:22:08 -0700 To: Thomas Monjalon References: <1499946530-29581-1-git-send-email-hemant.agrawal@nxp.com> <2584395.73f1Oakct5@xps> <1afffe26-d574-0c6d-6101-836aaca1a37b@nxp.com> <3872801.Digd9JTyXe@xps> CC: , From: Hemant Agrawal Message-ID: Date: Sat, 7 Oct 2017 16:52:06 +0530 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <3872801.Digd9JTyXe@xps> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131518489905890995; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.158.2; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(336005)(346002)(376002)(39380400002)(39860400002)(2980300002)(1109001)(1110001)(339900001)(189002)(377454003)(199003)(24454002)(31686004)(77096006)(498600001)(58126008)(356003)(229853002)(68736007)(93886005)(31696002)(305945005)(8936002)(5660300001)(2906002)(316002)(8676002)(47776003)(105606002)(53936002)(106466001)(86362001)(65806001)(33646002)(64126003)(65956001)(50466002)(23746002)(81166006)(81156014)(76176999)(189998001)(65826007)(54356999)(230700001)(36756003)(2950100002)(6916009)(54906003)(85426001)(69596002)(50986999)(6246003)(104016004)(83506001)(53546010)(4326008)(97736004); DIR:OUT; SFP:1101; SCL:1; SRVR:MWHPR03MB2704; H:az84smr01.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BY2FFO11FD014; 1:3J8rx3h6Pe+UEZuZKSHsdW7ZwuPGEikvDE7SNPFRzyMl5h2SVy/0RiaAvK/KVaGuCblTpwz25Qc/6TEhFf42KAgKKFaVby112EyyB8e7ogq5YK0E6tOgaODp7vq+nVwr X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7cedb832-dd64-4d6b-7bab-08d50d75caa0 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017052603199)(201703131430075)(201703131517081); SRVR:MWHPR03MB2704; X-Microsoft-Exchange-Diagnostics: 1; MWHPR03MB2704; 3:O8gRVm6EZglrM66A1puHzVW++wUm6uXXz/qyJWaT9B3x+uXn2sBoPATG9ahJKk9Z/XQd0Jy32a5RixJV75jhFHm9OupbVvCW+LSP5EnQFoeDUQ9xvKBs3b8rIjD46QeMf0tzSlgfd4yz7jq69E7phyWoAdNA+a9Z3UKTX7Aio61uCqsIUDKx3k7QsJCDYl1o1O0H7ahEcIRB/BbUiKksOjzFCSEtkk8mFDjwAMqr7TZ26JxQqHGjxPxh6x6fd9rUUKSGk1egeTpJEJXaOmTQ1fYmVwGtV+uFeF654xAwIwvzzPDOR64d5exKD/Pa7ruxf73iOrqorO/EmPhXU7zaUZtmKZGAYevi9J/nfhRHu+Q=; 25:qNMi4Vzf10LdLh9PEy8JH/gZjkg+nNKMIn1hku6medVviDTjYe9VSogFrFtiMvS5cvoAl5etd65iZseb2DNazOfISOCzxHlQBAwDSLmtZ8Fwk2IoO8xqSYXt2LUrGYoHP/gDqsBd7rpgSali/Ozxdjh9D5bsuqWXpTWXSEyMMY2GsqeIwYQ5lmm6U7IALJx+/o0FS6mrnPew5eeiLKvW4G0ZSrDA0MwWdVABnrMFTkThGz1OkK5tSMIOo9oaDNeGodZFn7o/z8z9NEhNrKTA6x4CV89lXbAzs63q3C7BGkQlIs+7UEY34GKaJNQK9SHaa6dI/w4DjGNhygqCEAOTNA== X-MS-TrafficTypeDiagnostic: MWHPR03MB2704: X-Microsoft-Exchange-Diagnostics: 1; MWHPR03MB2704; 31:cX7SbTc6mIK4ErnunECGNI7E/bfM9nkb+Y39M0IFArcvVKPA4d0o0qaEO/b4+tvN/2nqHVtWyTICqsUNqGyE5h051Og3FM52NIjOhNRet97/5wXgILyQETD3kgyNv3sqFj+JrjgB5iMv5e5/DE9RgAbmkl6NEslji5gQ7aM9qm+YlemGuYxp1Id93IXvtI+SnPzTd82k8P4qTzwbiRz7zOMC09ov7vmf4Fre91ASxRg=; 4:/7FCSkAd77bxHokQXdSMmzPrrmnF7xysCI9AEysnB4+S4H0Y9Y8+GPbFfl4+z55KgnXsZfVt44YxObnqfhVLapCxTUxRohZ7h16pn3/VnmfsjONLBYa7U0UAWRIORQ0zKtsenYVUPJhy1n5bbE/ITCaKBpJMXaX+NmUh2G/Hr0Lm6c5GcEJpdmjHCGFovFpED+hWuEEqCXgWpDdHvkOvIjXVcSnm9gAV6NXV7AvpYxEi4eqNE54HZUwfHhWh4YmDTB0+qnivLYDPFbiVjNgUxRxyfdVImHHFPkNZvEPO5+E= X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6095135)(2401047)(8121501046)(5005006)(3002001)(93006095)(93001095)(100000703101)(100105400095)(10201501046)(6055026)(6096035)(20161123556025)(20161123563025)(201703131430075)(201703131448075)(201703131433075)(201703161259150)(201703151042153)(20161123565025)(20161123559100)(20161123561025)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:MWHPR03MB2704; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(400006)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:MWHPR03MB2704; X-Forefront-PRVS: 045315E1EE X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; MWHPR03MB2704; 23:T/xsj6dVm17us2A0CeHXIcGIWdKyJLGIGB2QA?= =?Windows-1252?Q?3VcpY2jAB2ihs9PwaazLdGQ9KlP2TWMZlU9w83cNh/D2TpTSS/qOiaLE?= =?Windows-1252?Q?bO6iz6u5Rsxp5Mn8nxdb1rLpv9hQFi6gRQzkTwXftGab55Jmi7fohhxD?= =?Windows-1252?Q?Cu7nrVuszgPQbFus9jU58P6/IhW9MGQaQ3gEUJuZ0sucBrcU36FN3uBe?= =?Windows-1252?Q?sUc6DRYS+ZbXJPSrszMgs5lJjl4cCoka03/faKyoTBR1/UcMz3SWcJTn?= =?Windows-1252?Q?5Noq3PrUQA5bUPMsrODsUWlVVUDd1uwrkdcrWNmavUs4wyZiCnzanKlD?= =?Windows-1252?Q?VY424gcxj4JtY91YO+6nKkK7M0yn/QhWA4Wh/Ri2/OfYavhJbxKSf12Y?= =?Windows-1252?Q?nTyr7o7IdK7C1CJcoa2AsfVYeePNpP2AY4pypgwml6+5F0CqvNxCW0f2?= =?Windows-1252?Q?nG5Kj+s8z/HHcX32YUwyjaeiPfGpxmXi6axHuLq+rvCNn1vjkh8EjDFo?= =?Windows-1252?Q?iKzk19QYmaeE6B3DA/KhBcfPVlYCQoRhbAW/p8Z963T8Uhbl2i3B1f/N?= =?Windows-1252?Q?Xzs0zro+cgchI7D9jBl3JslFPUIsEU/Adg0yHgWdM/M+QeRyrNRIGfXt?= =?Windows-1252?Q?eldfGEcEga+KYgmZpTTlKSftKVtdroaEX1cTM02rvmo1Ne+ZhVOGqzPl?= =?Windows-1252?Q?PFiXhlDWqcmL+Pi9XV6sImC9MSe0n8MmIor9gAItSgnZvNIuCyGv7B9q?= =?Windows-1252?Q?ODMiCVViL9kUQ66milNIo9pHAMZVCvjvuCIjChph9REb/Y8BlA59/otF?= =?Windows-1252?Q?Rtlzxmj+9vb4qGx/qeaM4H92MGG+LjfZJLrCkuhF1p3E+XINbw9564ez?= =?Windows-1252?Q?lUHUUfGvxFco4Qp4vRDsV00OfqiTVCTOb4uxtXP33mWOSRT1SK5+fOz2?= =?Windows-1252?Q?er+z4/BVnlGaNP6DTUl6IUFfu5mwnXfIgtQprQ5ZjTV1zDGkPMBCfVGA?= =?Windows-1252?Q?ZZd05o/O1D3piiha/JYKNycIQrnYxk5pHxJALDndtBGDgrF2oH1KjFAS?= =?Windows-1252?Q?M+dzNy1XGh8OqcRRYNT/PxxqDzwCBe4UoiK+Q1Y8iVdT5nvMd/QiBOwF?= =?Windows-1252?Q?AxBknhLQb48VvRLKJBCha2MqhoMwR6pDT06XEgbuN0BHb1SCd/OQJc52?= =?Windows-1252?Q?b4BeGEjRRL3v8B8Ql+EIlZLiEVYlz+9/FO/KY10mpvvJmcLG42MWr4Fi?= =?Windows-1252?Q?Y6r8ERs3Yf3A2u5yL9KokVAKQcJSAX4/oY03qZyTCRywssfUHNoDTZWS?= =?Windows-1252?Q?mBxve6/sIrv3sEDEz8BGubd04AeoOmPR5eBFjx1eqsZTAZHMuwROujHh?= =?Windows-1252?Q?+ZAjQXY8pRZNNBYdU+H8tpgWbvH4xK5Qxyt+Nwj9eUETDV7+UubMP2K0?= =?Windows-1252?Q?PFz/v8AYsYd0ezXVR8DkLg/QZ1XrbOXy5V/SRiL2BWV+WsG+pJ0BgHTX?= =?Windows-1252?Q?wtjvUCw7Q5EaCnVcoZqtU6rrSRT?= X-Microsoft-Exchange-Diagnostics: 1; MWHPR03MB2704; 6:ii0T62fm6ex3MNPPtSgnPMasqdlsTsctN5YaUvOgVzOoeSvbb8c94qdM3ihxpob7p9OUfibX1tg0QCd+tnnApUrF0JkgvWEgQJIaBpk25XsNclhcyND7QpTiwKA61257F6lsY1Ri55IzQBIAZJxekAlYHnmC7wXx9NlIdeR7ke7OZIYIQORQ444lGQO/D6DFKX+8v4GPAMpwzAjtFcuGcMXTgA2/TGHEPs68b0lQ4PC73qLHTkL5KcEDSdtr4/tqOCTU7yMWGsJCiAhsLsP/g3q2aAGw0CNATEjt1S8CXTXpEPxs0I8w12OFvV/BYq6BRb1eut84X1iUdGmWxaJgbg==; 5:4FULexXJv/K/WJ57DYkfD0EDVCq4//jCgp8lJ/3R0k8iW2vD6V6poI1HrLrMrQKO6RzcFpY2ebDNtotZ65QKtlvX79AX512KgCnFhItmTMtRdSwsyT+EyYMKZ4XL5J9SGXBPBrz6S96fsAfg4+kTnTynoa7h9Y+2Zu7o4g6/S4M=; 24:bWc0ejbCDpB9f204iNJhJiUm9z1XFBteYVXtgoFNq0oDRZASnledDqgKaL309R5KJTe9GwnqaLwNpI9Zc1oCr7M7wLjc/3XurlRTSuhGQhg=; 7:1JqrIqeervHpMbDoqfHCUZsANfeWYmp3MC7u+CAhPaG8znyYi6mLmKv03E8RpXtFkZK88EYRveVF9gxz8DrBxngrYo8nYBXYftT0AO3PIhzE0QFYad9kuxY3KCn7YzL97z6Yaw+D2YWzFG37xhYHGAXDsG1ZFpIezcI7wdPBDRK3ZF2KRGogpltgFXcKew9GO/82C7wDadOu2q4sLAjWH3S7rhkUgzxeX2FVF7w9/J0= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Oct 2017 11:23:10.3550 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.158.2]; Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB2704 Subject: Re: [dpdk-dev] [PATCH] eal: fslmc bus need vfio enabled for non PCI case as well X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 07 Oct 2017 11:23:14 -0000 On 10/6/2017 10:38 PM, Thomas Monjalon wrote: > 06/10/2017 18:22, Hemant Agrawal: >> On 10/6/2017 5:11 AM, Thomas Monjalon wrote: >>> 13/07/2017 13:48, Hemant Agrawal: >>>> In case no_pci is configured, fslmc bus will still need the >>>> the vfio to be enabled. >>>> >>>> Signed-off-by: Hemant Agrawal >>>> --- >>>> --- a/lib/librte_eal/linuxapp/eal/eal.c >>>> +++ b/lib/librte_eal/linuxapp/eal/eal.c >>>> +#ifdef RTE_LIBRTE_FSLMC_BUS >>>> + if (!vfio_enabled) { >>>> + if (!vfio_enable("vfio_fsl_mc")) >>>> + vfio_enabled = 1; >>>> + } >>>> +#endif >>> >>> It seems to be a hack. >>> VFIO is not only PCI. >>> Why --no-pci is impacting VFIO? >>> >>> Anatoly? >>> >> >> At present there are only 2 users of VFIO. PCI and fsl-mc bus. >> >> >> One options is that we always enable vfio irrespective of --no-pci flag. >> My believe is that vfio-pci will be present in most system supporting >> any other flavor of vfio (platform, fsl-mc etc). >> >> The other option is what I proposed. i.e. if vfio is not already enabled >> the platform is FSLMC bus, enable it. > > Why not always enable it? > I agree. sent a v2 for this. Regards, Hemant