From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-BY2-obe.outbound.protection.outlook.com (mail-by2nam01on0079.outbound.protection.outlook.com [104.47.34.79]) by dpdk.org (Postfix) with ESMTP id C0D0B1B890; Thu, 1 Feb 2018 06:06:03 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=ctVNu/Z8s1V0bk6y3EAEbdWlhNV2f5Rb7HI34SVgoSs=; b=OJAi/ZQzSbsswThWxHAnvZm4Dr6cKE3MSLMUKQHz5QKQZYIcayEPPxv46n0B2zrw4TNeGgy/z4WsY8wjXtuq7UIxGUf5bulGTLU3L2IRYyNnLu64V2UsWAVzLNv8Wx04dQAC7ZZb1+4gDy8avB4tWq2lhA+fcN+QZobB/lM9aeI= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Santosh.Shukla@cavium.com; Received: from [IPv6:2401:4900:1721:8f14:accf:854e:eefe:2] (2401:4900:1721:8f14:accf:854e:eefe:2) by SN1PR0701MB1903.namprd07.prod.outlook.com (10.162.100.29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.444.14; Thu, 1 Feb 2018 05:05:59 +0000 To: Olivier Matz , Andrew Rybchenko Cc: dev@dpdk.org, stable@dpdk.org, jerin.jacob@caviumnetworks.com References: <1511539591-20966-1-git-send-email-arybchenko@solarflare.com> <1516713372-10572-1-git-send-email-arybchenko@solarflare.com> <1516713372-10572-2-git-send-email-arybchenko@solarflare.com> <20180131164504.cnfgfwo2x3ftxnaj@platinum> From: santosh Message-ID: Date: Thu, 1 Feb 2018 10:35:45 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20180131164504.cnfgfwo2x3ftxnaj@platinum> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [2401:4900:1721:8f14:accf:854e:eefe:2] X-ClientProxiedBy: BM1PR0101CA0052.INDPRD01.PROD.OUTLOOK.COM (10.174.220.142) To SN1PR0701MB1903.namprd07.prod.outlook.com (10.162.100.29) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6103018c-97c6-4011-071f-08d569317ce0 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4604075)(2017052603307)(7153060)(7193020); SRVR:SN1PR0701MB1903; X-Microsoft-Exchange-Diagnostics: 1; SN1PR0701MB1903; 3:f1Ol47WhFFjqd/oefGoWSfBexEfdebeOd3mdAMdSWvRN25cKnkIoYGqcoU783t0nADuVLAe8tZt5Y/w/rMU3El2KHQA/gKOZDVkTWlh80ssGDNdXWVRqnmXY0u1+k+6Wn5QSo7zMjUhur04OhbgWFkhwm+/aZeOoqArnv2MJQXiOjIqc8Ucoh1E8HwC8oiREpHZl2Ay7jlYYto4lyb9xUiLA8o5ILa8fKcH2vstE4cF+JUR2oB4bMFYlKkf9V3Jx; 25:ENJiaqyuldt3q9FA9eJWGmoXQk7cBSs6fSDVEq7mH32MoHW0qOJTunv0eVEqdheSiXNqjXlWFLyAhgu/IloldDlT2OnGGUpJRKvE5IRhO9UwGRUsUQkR0JWyOTlWXsh9zqdjH3Lo4oSblJ9E5n+NAZeqXg4ZcwShE87VbJVVku/es5dDCzc6Md3UdTuygen0UEghMIiNPPiWTF0+414bYauIAmlSkXBd7EHKQoSNEx0oA9SAagnFG74p9DzpQy34MECumvPbtmk2ata6ljsS5jWz4QgoKWaLzvpGM6f5kjOaetWF3alG56DxAHOpFwljzAUbkBXr4hLymCNIo2sqNw==; 31:uZEXz1g+s/MiCzp1r7lrH3GGMnxzjiYwJLW2L2VYtlQplrn0Dc0FJlQ3ahCvgLfoDnslKo1zXSC+Hv3eGNV3+Qdti2tHV9L3KNvBb5aZ6vbXEDsxup8RD7FVhwzP9eI5DZpTHYnuD9lv8N3z7egRjnHg71K55KSa/MVmcz7DS+BpM4ENU+1oWL0gO7Pfw9BxwwjPlKw7JfyCKFdore7Q1vDfTHY49i+DJIRsKAgiOmU= X-MS-TrafficTypeDiagnostic: SN1PR0701MB1903: X-Microsoft-Exchange-Diagnostics: 1; SN1PR0701MB1903; 20:1bCMBKYhg05LL1TS01MDaTtXFTm+sNBp+rYecV56VUAcpSXik9FX4Of9SToDH5XWOQtD/4lhZ8FRjWbrd96YKT6cR+z8/Huhpi5nsvtq4HeYgDA/g41L7Bw/AOeTOtsOOUSIWJQvZ6sVLLVCv77VOao164h4CHCG89sl4KXD6iYetlNtOz99prZDDcohBkX7dlNmtLdUyLExgKl7RfRCtDxFxa73cPSC4u3lvkescW9+Rg5QwWsyZXlu5i7y5BSUgMBzFSubCgXNArnShZDHOHktOAYVxrxSYvTebszUSnBAHc0iMwrsXNMkgxYeMdVOVpe+B41hBULoQ2M3HiXSYmZCU6+xulVwxTQca5h1w27Ob3wQKlfEeBjNX1iuOsz8SqXgD0Nojbw28cVQRoB3zVhPv8I68u2Rea9/3ikvaF+qHkXVQASlerjHWfTJeqnptkGKTYuJCPMDMjVUgLvQeeEXAz288ICDFNDJQycHxaDYhf/CQNXzq1HUgEdnYn9ndzq/DSQovBB1XRQiCDwbbQbicD8kAztACYLk0PWcEFE71Uaeq0xHiX2Mq3wUcQKobHjuZel9KIw1EmXam7cqb96rI1ckRnWLqlFl0fFtnNM=; 4:n6+w5cupnn1AFS9IHI9NtYjEbvH9MyhhqGVj6owlv2LK0vkM53YUrG1t3+rSB1CmZHeEDpXoAAacyHWBUZR5THWrz88q0ZAqCa+WMQ7JlX78Hpw2MOK9HFHAOa23F6oDuld6mxW3uBRPfW6Y6xjcXGkKEULiRi6tNG8j5wasvnGF33YVyhRqkhtJu2WgOUaJEtsHbWYQOyIm09h08P3bMxVeBJUMvm3nCJD/LKPmfsJjTIVBwHJQXrNhSzQPksae4MoBfgzu0Z6l8/ErHTthOw== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040501)(2401047)(5005006)(8121501046)(3002001)(93006095)(3231101)(2400082)(944501161)(10201501046)(6041288)(20161123562045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123558120)(6072148)(201708071742011); SRVR:SN1PR0701MB1903; BCL:0; PCL:0; RULEID:; SRVR:SN1PR0701MB1903; X-Forefront-PRVS: 0570F1F193 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(376002)(366004)(346002)(396003)(39860400002)(39380400002)(199004)(189003)(478600001)(305945005)(59450400001)(8676002)(23676004)(52396003)(52146003)(86152003)(83506002)(8936002)(2906002)(386003)(2486003)(107886003)(58126008)(25786009)(4326008)(5660300001)(229853002)(6666003)(2950100002)(42882006)(7736002)(68736007)(110136005)(31686004)(106356001)(6486002)(76176011)(81156014)(47776003)(316002)(36756003)(65956001)(81166006)(53936002)(65826007)(52116002)(50466002)(64126003)(105586002)(72206003)(6246003)(1706002)(16526019)(31696002)(93886005)(230700001)(97736004)(6116002)(65806001); DIR:OUT; SFP:1101; SCL:1; SRVR:SN1PR0701MB1903; H:[IPv6:2401:4900:1721:8f14:accf:854e:eefe:2]; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtTTjFQUjA3MDFNQjE5MDM7MjM6azFueVVvc1kraDdzUjN0RStMUVVTS2pN?= =?utf-8?B?Q2pqN1VSNkFla2Ywck9XSWRLRDU0eERxVjlhUDJkQVBnSUxKSmg4TXUveTJM?= =?utf-8?B?cjREVGRWK0h2V1BvNTdMaGxFSWQ1Zkg5eWd0RFVrZU91dXU0S1RiejhvLzB1?= =?utf-8?B?b2pWdTlQblBHWUk3cTBsOS9DZXNFbWJCVUF6UTJCUUdpZGpHMkttcUI1Ujhq?= =?utf-8?B?dHcrRnVtUHRpU0NuYTl6aTd4VmJ6MmdHUUwwUkJXdmNCTnJKMGF4QlJvYmIz?= =?utf-8?B?Yi81RjZwM205a1A2QXRyMHFEQlNBbERVUzJ2aEU5QnBIQmQwNUVEQlJOcFIr?= =?utf-8?B?WmYyRWZXNWZzeVY4Wm5wWi9lU3FJV1ZvdUNWMzRVbFNDNnl4bFZ3MHJEeTd4?= =?utf-8?B?MDFzTUo1Z3JueDk5Nk9oMFR3akMwMXRsd1owVlhRRy9Oc2xtV2J6REdIb3Ew?= =?utf-8?B?eHhXcWplZWpSSEY5d1VwSmlEcWVoeUY0M04vc0RtR21EeCs3TEx4N2UydWRW?= =?utf-8?B?S1FXeVNxZ3ozYWxrNzhyS3I1cTdiRTA2a080OEdlaFViNlRxUkgxcUVlV1lp?= =?utf-8?B?YTNLWGxzajZlQ3d2cnJYU0Znd1hXZjFGY3VkTDlqU3hETE9aVDVjU3pCWFdK?= =?utf-8?B?aktDenl0Mmd5cGprUW9TUFJycXdSbjRoN2M0c3FqNzJZaGlXNE80TG4rV3dS?= =?utf-8?B?UXdMVng4R2dMb3p6RXllYVVwQ1A2bUc0dW5TeTNNZXBtdWxuZjB1dUZPNERD?= =?utf-8?B?M2xDNG9YOFRXRFU2Q25JYXR6SisyYmJOWWRXTFJsT1lpc1RRZnpXZHZaejhx?= =?utf-8?B?T3h1YUFRYlowc29zdnJ3QVNjelVzNU8xMHJlZDRXQytkYlc5b0FCNEpzcHpi?= =?utf-8?B?cVAzOWtMNVEyakdEM2NaR3h4S2lmVHhOZCt6aU5IdTZlbHArZEtlYnZIQng5?= =?utf-8?B?NThBWHY1ZFlRV3AyOTFyOGdvNzFkQUJXZ3BGOFh5Qkp3VkRYMEw3RXJwRFU4?= =?utf-8?B?TVR6UHZTd09idTluV1Y3NnJsYnF5UjdYVzhpeUZhZHZQQ01qQVBKb05pdms5?= =?utf-8?B?a1lnQ1h1L3VzNVJsQTZIVDlidjNWYWZSUjZFRFpka052MzZOQWdVWGxUNll4?= =?utf-8?B?QTAyZXRhN2FCOW91bElQRHpvVkZzeEVuaXFoYXhZSm5HdzVlbTBTa0gvZHVW?= =?utf-8?B?Qm9CUUp3a2ZHSXVVMXh1YkZoaC91T2N2c3NkU0dmSHAzYWFFd2hCSkVRSW93?= =?utf-8?B?K2MrK1FQNmxkUEFOSTJEOHo2K043dmo5RUFzUUZkVUFCQkI3RTNJZU9GZVdT?= =?utf-8?B?NjZmUnpSc0w2dVpRcmFtU2FOSmVreFZ3MGQrTUM3aGNsbGpWT3A5aHRKL0Fu?= =?utf-8?B?ZEpkcjlReGNRRGMyV1JUV0c3MkdqeTVHd0hmYmZxZlRKYkJ1M2JrNlBQY2Zp?= =?utf-8?B?aEM0M3BjMzJ1OXFHdldUNTUrbWduWDczc2s0UGhramEzSFZaQnZUWWdhS2Va?= =?utf-8?B?MWVHZ0VOWithUGZFY1ZkczNXV094NlppdGRsK0d5cDNETnpPK1VNMGFSVkd0?= =?utf-8?B?cnI3MnIyK2xuMFY4MkYwRHlTbFVWRUhMQXZzQ3l2aTlYM2tleWY5SVovV1Qz?= =?utf-8?B?SlEvallhWDB5MmF6YXVPN2txRVZaU2pyOW9XT1N0ZlFoL1Y4SWlFeXhYK09M?= =?utf-8?B?VHNaU0w4NEN2eUl2MmJBRmRNS2VDR0xBbUt3d0NzVnA0TldHc2FJRS9RTmxO?= =?utf-8?B?VUkwN1I5NTVJTUlNaDdGVE9kWURWNGFIQTA4NWxhT3NUZmpKNzVaKzM2ZVpv?= =?utf-8?B?cnVDZVNaZnNHdnZhSWZEYW9CQjBYcTBuNGV4SzVuMEhFaU9oUT09?= X-Microsoft-Exchange-Diagnostics: 1; SN1PR0701MB1903; 6:j3GZgTfOUphiyNTZzu90gH/FbhM8Ia/h8SqIoojkVq2jj6UWDswwdDId5yJ2cjmNOEQFfyRnBoCMIx2Jffn4rEpYjpYDVKdH5gprRh105+mb9fVZnb+5bPHKetyXLpkd749Jy7ZqFYoNT1UogmMhg49UHSGM9QI3+z8+/ZJokZAdnpSvAoqfq7vMTbrdM5K7HU/wTThW9cmqQ16DiAJQrg77YUBO9DkgG4c4L2u7kEFNm73lmZRS9ZpNIbsj5r8FlpLNRqFPjM4k+AsrotQ8FolU5PG8p+JDS9QDGSFMge0TfLpLamsAJpOc+JVmP8+HORrt+E9VQae8o56kqR9p0xUTyjVA9nJ6N1mEbDHTwek=; 5:gQxiL6i0g9/o7lOvjXX46u4F9MBGTaj/Yeuv8YnGQmlCKzsh1sTB9edrG7h6zZz8gShwuiqRZyo9LUmuMFPNjUiF7s9llkkGHlT6y7uD2f0n7F05mMF/UBNhN8xt/MJyIhkSajjKlkyB3uJAC0Xj3JQWwLQHX0TU45dAJvULRz0=; 24:ErztEjQRwf1hngwPpfvObTRl+PrDVXYhY37eEMywbT42INO76Uowe5nod2gr8Ol/+zEnrMJjrhDt1yIEQX07ie+HYQCtB7zu3RzxHi6P+M4=; 7:CeCK+atBHdiMya5kxVfoX2hYp0xa0dIAk+UOoyNfvgvic+3ad8ZSH6DMaKVTn8Qe5bIFqbPFxUX3IGqgmp8aTWoV3qYxwOQAa5rueiWbPXqBWhTvAK+JFm7vy1hgLdwQrVfcGncMqWjrR5JE5tOBRuXYSNZ3Or/B2gg51e6PXhLcXYgzLVhs+ScQGg9XXhl39Uh4fLkQuM9rhXzLbANp7Hsi0f73QHHsjBJE3ADP4W6GynPq09QXhCWukfoMr8p8 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Feb 2018 05:05:59.1069 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6103018c-97c6-4011-071f-08d569317ce0 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR0701MB1903 Subject: Re: [dpdk-dev] [RFC v2 01/17] mempool: fix phys contig check if populate default skipped X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Feb 2018 05:06:04 -0000 On Wednesday 31 January 2018 10:15 PM, Olivier Matz wrote: > On Tue, Jan 23, 2018 at 01:15:56PM +0000, Andrew Rybchenko wrote: >> There is not specified dependency between rte_mempool_populate_default() >> and rte_mempool_populate_iova(). So, the second should not rely on the >> fact that the first adds capability flags to the mempool flags. >> >> Fixes: 65cf769f5e6a ("mempool: detect physical contiguous objects") >> Cc: stable@dpdk.org >> >> Signed-off-by: Andrew Rybchenko > Looks good to me. I agree it's strange that the mp->flags are > updated with capabilities only in rte_mempool_populate_default(). > I see that this behavior is removed later in the patchset since the > get_capa() is removed! > > However maybe this single patch could go in 18.02. > +Santosh +Jerin since it's mostly about Octeon. rte_mempool_xmem_size should return correct size if MEMPOOL_F_CAPA_BLK_ALIGNED_OBJECTS flag is set in 'mp->flags'. Thats why _ops_get_capabilities() called in _populate_default() but not at _populate_iova(). I think, this 'alone' patch may break octeontx mempool.