From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 76BDFA04B6; Tue, 13 Oct 2020 11:16:20 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D8D511DAD4; Tue, 13 Oct 2020 11:16:18 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by dpdk.org (Postfix) with ESMTP id 3BB711DAD3; Tue, 13 Oct 2020 11:16:17 +0200 (CEST) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id C8EC07F476; Tue, 13 Oct 2020 12:16:15 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru C8EC07F476 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1602580575; bh=xB6lxiO32/fyAS8aP3fNsTi5d1GOIl3x3mCVoJOmRGU=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=En2kRJ6/jWa1bclwWyi97t7wrvcFSl6bLodpOMNzfGCM0LzXboA+HHiyoddZFI8yV mKGWv7VY/lRfc5F4EaZ9dVULes2Ragza9IXqBNG5YLOXDVk/JpBtARNNy6wGwc6ahJ OZjs/q3FymZ4nUfduiIea2bv+LNv9OYeAEEnN1J0= To: Thomas Monjalon , Ferruh Yigit , Stephen Hemminger Cc: dev@dpdk.org, techboard@dpdk.org, Min Hu References: <20201012164602.1965694-1-ferruh.yigit@intel.com> <3382071.xncihUvvZe@thomas> <2290585.EWI7AWl3IT@thomas> From: Andrew Rybchenko Organization: OKTET Labs Message-ID: Date: Tue, 13 Oct 2020 12:16:15 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 MIME-Version: 1.0 In-Reply-To: <2290585.EWI7AWl3IT@thomas> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [RFC 1/2] ethdev: move queue stats to xstats X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/13/20 12:05 PM, Thomas Monjalon wrote: > 13/10/2020 10:31, Andrew Rybchenko: >> On 10/13/20 12:53 AM, Thomas Monjalon wrote: >>> 12/10/2020 18:46, Ferruh Yigit: >>>> Queue stats are stored in 'struct rte_eth_stats' as array and array size >>>> is defined by 'RTE_ETHDEV_QUEUE_STAT_CNTRS' compile time flag. >>>> >>>> As a result of technical board discussion, decided to remove the queue >>>> statistics from 'struct rte_eth_stats' in the long term. >>>> >>>> Instead PMDs should represent the queue statistics via xstats, this >>>> gives more flexibility on the number of the queues supported. >>> >>> Yes >> >> I like Stephen's idea to have dedicated API to get stats per >> queue. Of course it is doable via getting xstats by IDs, >> but IMHO it is over-complicated. From the other hand >> it sounds like a duplication to have it in xstats and >> dedicated API (basically the same as we have for basic >> stats and xstats). > > Please read my proposal to have fixed ids for common stats > and fixed id ranges for stats per queue: > https://fast.dpdk.org/events/slides/DPDK-2019-09-Ethernet_Statistics.pdf > (slide 11) > Ah, yes, I forgot that point. Makes sense and LGTM.