From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <maxime.coquelin@redhat.com>
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by dpdk.org (Postfix) with ESMTP id 1F8C4FB8D
 for <dev@dpdk.org>; Tue, 20 Dec 2016 15:54:51 +0100 (CET)
Received: from int-mx14.intmail.prod.int.phx2.redhat.com
 (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by mx1.redhat.com (Postfix) with ESMTPS id 6129D4D6A7;
 Tue, 20 Dec 2016 14:54:51 +0000 (UTC)
Received: from [10.36.116.159] (ovpn-116-159.ams2.redhat.com [10.36.116.159])
 by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with
 ESMTP id uBKEskbQ031903
 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
 Tue, 20 Dec 2016 09:54:49 -0500
To: Thomas Monjalon <thomas.monjalon@6wind.com>
References: <20161206122440.12039-1-maxime.coquelin@redhat.com>
 <ba28794d-8f2f-21a9-f568-9d9b123a1be8@redhat.com>
 <B27915DBBA3421428155699D51E4CFE202671A59@IRSMSX103.ger.corp.intel.com>
 <15125480.nLCo42mjm8@xps13>
Cc: "Mcnamara, John" <john.mcnamara@intel.com>,
 "yuanhan.liu@linux.intel.com" <yuanhan.liu@linux.intel.com>,
 "Yang, Zhiyong" <zhiyong.yang@intel.com>,
 "ktraynor@redhat.com" <ktraynor@redhat.com>, dev@dpdk.org
From: Maxime Coquelin <maxime.coquelin@redhat.com>
Message-ID: <d6a9f7ab-f2a5-ba02-db5e-d8454a7029f8@redhat.com>
Date: Tue, 20 Dec 2016 15:54:46 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <15125480.nLCo42mjm8@xps13>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
X-Scanned-By: MIMEDefang 2.68 on 10.5.11.27
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
 (mx1.redhat.com [10.5.110.26]); Tue, 20 Dec 2016 14:54:51 +0000 (UTC)
Subject: Re: [dpdk-dev] [PATCH v2] doc: introduce PVP reference benchmark
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 20 Dec 2016 14:54:52 -0000



On 12/20/2016 11:03 AM, Thomas Monjalon wrote:
>>>>> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
>>>>
>>>> There is one trailing whitespace warning but apart from that:
>>>>
>>>> Acked-by: John McNamara <john.mcnamara@intel.com>
>>>
>>> Thanks John,
>>>
>>> Do you want me to send a v3, fixing the trailing whitespace & collecting
>>> the acks?
>>
>> No need (unless the tree maintainer says otherwise).
>> It was one trailing whitespace. Just something to look out for in future.
>
> Removed when applying.
> Fixed some heading issues also:
>
> --- a/doc/guides/howto/pvp_reference_benchmark.rst
> +++ b/doc/guides/howto/pvp_reference_benchmark.rst
> @@ -160,7 +160,7 @@ Testpmd launch
>            --portmask=f --disable-hw-vlan -i --rxq=1 --txq=1
>            --nb-cores=4 --forward-mode=io
>
> -With this command, isolated CPUs 2 to 5 will be used as lcores for PMD threads.
> +   With this command, isolated CPUs 2 to 5 will be used as lcores for PMD threads.
>
>  #. In testpmd interactive mode, set the portlist to obtain the correct port
>     chaining:
> @@ -176,7 +176,8 @@ VM launch
>
>  The VM may be launched either by calling QEMU directly, or by using libvirt.
>
> -#. Qemu way:
> +Qemu way
> +^^^^^^^^
>
>  Launch QEMU with two Virtio-net devices paired to the vhost-user sockets
>  created by testpmd. Below example uses default Virtio-net options, but options
> @@ -210,7 +211,8 @@ where isolated CPUs 6 and 7 will be used as lcores for Virtio PMDs:
>        export PYTHONPATH=$PYTHONPATH:<QEMU path>/scripts/qmp
>        ./qmp-vcpu-pin -s /tmp/qmp.socket 1 6 7
>
> -#. Libvirt way:
> +Libvirt way
> +^^^^^^^^^^^
>
>  Some initial steps are required for libvirt to be able to connect to testpmd's
>  sockets.

Thanks Thomas for handling these fixes.

Maxime