From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 23E113B5 for ; Mon, 15 May 2017 10:40:28 +0200 (CEST) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 May 2017 01:40:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.38,343,1491289200"; d="scan'208";a="87497099" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.81]) ([10.237.220.81]) by orsmga004.jf.intel.com with ESMTP; 15 May 2017 01:40:21 -0700 To: Thomas Monjalon Cc: dev@dpdk.org, Shepard Siegel , Ed Czeck , John Miller , John McNamara , Harish Patil , Rasesh Mody , Rahul Lakkireddy , Hemant Agrawal , Shreyansh Jain , Wenzhuo Lu , Marcin Wojtas , Michal Krawczyk , Guy Tzalik , Evgeny Schemeilin , Jing Chen , Helin Zhang , Jingjing Wu , Konstantin Ananyev , Adrien Mazarguil , Nelio Laranjeiro , Matej Vido , Pascal Mazon , Yuanhan Liu , Maxime Coquelin , Shrikrishna Khare References: <20170510131053.75843-1-ferruh.yigit@intel.com> <16254100.QC6ztoDaX8@xps> <17406199.hqjMraK9H2@xps> From: Ferruh Yigit Message-ID: Date: Mon, 15 May 2017 09:40:20 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: <17406199.hqjMraK9H2@xps> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] drivers/net: document missing speed capabilities feature X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 May 2017 08:40:29 -0000 On 5/12/2017 4:48 PM, Thomas Monjalon wrote: > 12/05/2017 12:49, Ferruh Yigit: >> On 5/10/2017 2:51 PM, Thomas Monjalon wrote: >>> 10/05/2017 15:10, Ferruh Yigit: >>>> --- a/doc/guides/nics/features/bnx2x.ini >>>> +++ b/doc/guides/nics/features/bnx2x.ini >>>> @@ -4,6 +4,7 @@ >>>> ; Refer to default.ini for the full list of available PMD features. >>>> ; >>>> [Features] >>>> +Speed capabilities = Y >>> >>> We should validate this feature only if the driver advertise the >>> right speeds for the device. >> >> Hi Thomas, >> >> Can you please clarify more, what is expected implementation in PMD? > > It is expected to advertise only the speeds that the device is > capable to offer. > >> And perhaps a good and a bad sample can be helpful. > > Good example: > drivers/net/i40e/i40e_ethdev.c > if (I40E_PHY_TYPE_SUPPORT_40G(hw->phy.phy_types)) > /* For XL710 */ > dev_info->speed_capa = ETH_LINK_SPEED_40G; > else if (I40E_PHY_TYPE_SUPPORT_25G(hw->phy.phy_types)) > /* For XXV710 */ > dev_info->speed_capa = ETH_LINK_SPEED_25G; > else > /* For X710 */ > dev_info->speed_capa = ETH_LINK_SPEED_1G | ETH_LINK_SPEED_10G; > > Bad example: > drivers/net/bnx2x/bnx2x_ethdev.c > dev_info->speed_capa = ETH_LINK_SPEED_10G | ETH_LINK_SPEED_20G; > Looking at qlogic.com, only some 57840 adapters are capable of 20G. OK, I will update the patch according. Does it make sense to mark PMDs that report speed_capabilities, but without checking actual hw, as partial "P", to differentiate them from the ones that doesn't report at all, also this may help to PMD maintainers about what to fix. Thanks, ferruh