Re: [dpdk-dev] [PATCH v2] hash table: add an iterator over conflicting entries

[Michel Machado <michel@digirati.com.br>]

On 08/23/2018 08:33 PM, Wang, Yipeng1 wrote:
> I think with Honnappa suggested "uint32_t* next",
> we may need a little bit tricks to make it work with the extra linked list.
> The performance may not be optimal though comparing to your original approach.
> Is this important to your use case?

    It is. We are developing a DDoS protection system, and have chosen 
DPDK because it was the fastest framework in the evaluations we 
considered. We need to find the conflicting entries when a critical flow 
table of our system is overloaded due to an ongoing attack, so the more 
efficient we can evaluate the merits of an incoming flow against the 
conflicting flows already in the table, the higher the chances we find 
the flows that should be in the flow table.

    We've compromised with Honnappa under the understanding that once 
the underlying algorithm changes, there would be a review of the 
interface since even rte_hash_iterate() may be affected. I still think 
that the v2 we proposed is the best approach here because it isolates 
the interface from the underlying algorithm.

[ ]'s
Michel Machado