From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mta113.f1.k8.com.br (mta113.f1.k8.com.br [187.73.32.185]) by dpdk.org (Postfix) with ESMTP id 9A08410A3 for ; Fri, 24 Aug 2018 14:34:13 +0200 (CEST) X-HN-S: bWljaGVsQGRpZ2lyYXRpLmNvbS5icg== X-DKIM: OpenDKIM Filter v2.6.8 smtpz.f1.k8.com.br D035580052 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=digirati.com.br; s=default; t=1535114051; bh=08a05Re8zQMVhpgfyFCrbfY061PiAATy7fqFIN4dk70=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=vw/SQ7YZchTPbPBTthJFUMJdhyoA3UrY0+ue6TJfSGHiK6sf5JVKzXhi1nLc5k4+r vXV2Y6G46B4+JKW0fh/UWn4jmzL3DoouMBrlEM7vr0zkJD60GxvY2oU0QVnWRYwOJ7 T9M8NkSqwaOlIpNPI1MaWYWAd+vkGYaAAPd4xJVA= X-HN-R: cGFibG8uZGUubGFyYS5ndWFyY2hAaW50ZWwuY29t X-HN-S: bWljaGVsQGRpZ2lyYXRpLmNvbS5icg== X-HN-R: YnJ1Y2UucmljaGFyZHNvbkBpbnRlbC5jb20= X-HN-S: bWljaGVsQGRpZ2lyYXRpLmNvbS5icg== X-HN-R: bmRAYXJtLmNvbQ== X-HN-S: bWljaGVsQGRpZ2lyYXRpLmNvbS5icg== X-HN-R: c3RlcGhlbkBuZXR3b3JrcGx1bWJlci5vcmc= X-HN-S: bWljaGVsQGRpZ2lyYXRpLmNvbS5icg== X-HN-R: Y2hhcmxpZS50YWlAaW50ZWwuY29t X-HN-S: bWljaGVsQGRpZ2lyYXRpLmNvbS5icg== X-HN-R: c2FtZWguZ29icmllbEBpbnRlbC5jb20= X-HN-S: bWljaGVsQGRpZ2lyYXRpLmNvbS5icg== X-HN-R: a2VpdGgud2lsZXNAaW50ZWwuY29t X-HN-S: bWljaGVsQGRpZ2lyYXRpLmNvbS5icg== X-HN-R: ZG91Y2V0dGVAYnUuZWR1 X-HN-S: bWljaGVsQGRpZ2lyYXRpLmNvbS5icg== X-HN-R: ZGV2QGRwZGsub3Jn X-HN-S: bWljaGVsQGRpZ2lyYXRpLmNvbS5icg== X-HN-R: cWlhb2JpbmZAYnUuZWR1 X-HN-S: bWljaGVsQGRpZ2lyYXRpLmNvbS5icg== X-HN-R: aG9ubmFwcGEubmFnYXJhaGFsbGlAYXJtLmNvbQ== X-HN-S: bWljaGVsQGRpZ2lyYXRpLmNvbS5icg== X-HN-R: eWlwZW5nMS53YW5nQGludGVsLmNvbQ== Received: from [192.168.1.4] (pool-173-48-214-200.bstnma.fios.verizon.net [173.48.214.200]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtpz.f1.k8.com.br (Postfix) with ESMTPSA id D035580052; Fri, 24 Aug 2018 12:34:04 +0000 (UTC) To: "Wang, Yipeng1" , Honnappa Nagarahalli , "Fu, Qiaobin" Cc: "dev@dpdk.org" , "Doucette, Cody, Joseph" , "Wiles, Keith" , "Gobriel, Sameh" , "Tai, Charlie" , Stephen Hemminger , nd , "Richardson, Bruce" , "De Lara Guarch, Pablo" References: <5e809298-ee0e-f03f-e83a-59b764e3a9b8@digirati.com.br> <12e971e0-41bd-2cd6-d80c-a7a486fd1046@digirati.com.br> From: Michel Machado Organization: Digirati Internet LTDA. Message-ID: Date: Fri, 24 Aug 2018 08:34:01 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Mailman-Approved-At: Sat, 25 Aug 2018 20:33:14 +0200 Subject: Re: [dpdk-dev] [PATCH v2] hash table: add an iterator over conflicting entries X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Aug 2018 12:34:14 -0000 On 08/23/2018 08:33 PM, Wang, Yipeng1 wrote: > I think with Honnappa suggested "uint32_t* next", > we may need a little bit tricks to make it work with the extra linked list. > The performance may not be optimal though comparing to your original approach. > Is this important to your use case? It is. We are developing a DDoS protection system, and have chosen DPDK because it was the fastest framework in the evaluations we considered. We need to find the conflicting entries when a critical flow table of our system is overloaded due to an ongoing attack, so the more efficient we can evaluate the merits of an incoming flow against the conflicting flows already in the table, the higher the chances we find the flows that should be in the flow table. We've compromised with Honnappa under the understanding that once the underlying algorithm changes, there would be a review of the interface since even rte_hash_iterate() may be affected. I still think that the v2 we proposed is the best approach here because it isolates the interface from the underlying algorithm. [ ]'s Michel Machado