From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id E16F4A0A0C;
	Thu,  1 Jul 2021 16:18:38 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id B784640141;
	Thu,  1 Jul 2021 16:18:38 +0200 (CEST)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id 8CBB64003E
 for <dev@dpdk.org>; Thu,  1 Jul 2021 16:18:37 +0200 (CEST)
Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 3CAF07F57E;
 Thu,  1 Jul 2021 17:18:37 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 3CAF07F57E
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1625149117;
 bh=80hHDSBBosLmeM2hrB30Y/hS1A6cV/lecbdBFAD581c=;
 h=Subject:To:Cc:References:From:Date:In-Reply-To;
 b=xcN96tXofVOck38kN0uS34nDLwmhgUPGgAjtdiwm6l+lnKq0pGWejOJcXfvXDxHIN
 MWSp0tCDocwg+M0qKJaRPXUNX4Rk8fUXlW5jzDn410DyEI7fiyYEPYhcOBesiQzjii
 0cX/bVC72yvDhYzJhNSfZjSjJiv9wnjZvHqzJx7Q=
To: Stephen Hemminger <stephen@networkplumber.org>,
 Keith Wiles <keith.wiles@intel.com>
Cc: dev@dpdk.org
References: <20210616041528.4229-1-stephen@networkplumber.org>
 <20210616041528.4229-3-stephen@networkplumber.org>
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Organization: OKTET Labs
Message-ID: <d6e77aca-964a-10fe-0044-c19e7068b9d5@oktetlabs.ru>
Date: Thu, 1 Jul 2021 17:18:37 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <20210616041528.4229-3-stephen@networkplumber.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH 2/2] net/tap: replace offload_capa function
 with define
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 6/16/21 7:15 AM, Stephen Hemminger wrote:
> Since the offload values are always the same, these can
> just be data instead of code.
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>

No strong opinion as well, but above reason is not strong
enough to touch the code. So, I'll wait for the maintainer
here as well.