From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7AA2AA0C55; Wed, 13 Oct 2021 11:56:07 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3AD7C410DA; Wed, 13 Oct 2021 11:56:07 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 9A62340150 for ; Wed, 13 Oct 2021 11:56:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1634118965; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gaAuED8H5cMHpKqnoW9kspwR66MGy1jePAW1B9jlQD4=; b=bFJkuXBQlG/xp4s/FWaAcOM10RQsWOmF6ko3XX8AV8u1PTIpayt1NmHgRZAsDSztuJUqY+ DXjFMvOPSilVianZqXAZEdJPONzzt7DV8cuOdFeA+hhzfA7falGr+g6/FH9vyLk1OyMBad E6aQ1QjvV2UyVdV+aVdSMVuqVcCQiBY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-537-vMopp9fTP_iyw9O8nsIB3g-1; Wed, 13 Oct 2021 05:56:02 -0400 X-MC-Unique: vMopp9fTP_iyw9O8nsIB3g-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 059E11927800; Wed, 13 Oct 2021 09:56:01 +0000 (UTC) Received: from [10.39.208.25] (unknown [10.39.208.25]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0BC3A1B480; Wed, 13 Oct 2021 09:55:59 +0000 (UTC) Message-ID: Date: Wed, 13 Oct 2021 11:55:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 To: Xueming Li , dev@dpdk.org Cc: Matan Azrad , Viacheslav Ovsiienko References: <20210923081758.178745-1-xuemingl@nvidia.com> From: Maxime Coquelin In-Reply-To: <20210923081758.178745-1-xuemingl@nvidia.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 1/2] vdpa/mlx5: workaround FW first completion in start X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Xueming, On 9/23/21 10:17, Xueming Li wrote: > After a vDPA application restart, qemu restores VQ with used and > available index, new incoming packet triggers virtio driver to > handle buffers. Under heavy traffic, no available buffer for > firmware to receive new packets, no Rx interrupts generated, > driver is stuck on endless interrupt waiting. > > As a firmware workaround, this patch sends a notification after > VQ setup to ask driver handling buffers and filling new buffers. > > Signed-off-by: Xueming Li > Reviewed-by: Matan Azrad > --- > drivers/vdpa/mlx5/mlx5_vdpa_virtq.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/vdpa/mlx5/mlx5_vdpa_virtq.c b/drivers/vdpa/mlx5/mlx5_vdpa_virtq.c > index f530646058..71470d23d9 100644 > --- a/drivers/vdpa/mlx5/mlx5_vdpa_virtq.c > +++ b/drivers/vdpa/mlx5/mlx5_vdpa_virtq.c > @@ -4,6 +4,7 @@ > #include > #include > #include > +#include > > #include > #include > @@ -367,6 +368,9 @@ mlx5_vdpa_virtq_setup(struct mlx5_vdpa_priv *priv, int index) > goto error; > } > virtq->stopped = false; > + /* Initial notification to ask qemu handling completed buffers. */ > + if (virtq->eqp.cq.callfd != -1) > + eventfd_write(virtq->eqp.cq.callfd, (eventfd_t)1); > DRV_LOG(DEBUG, "vid %u virtq %u was created successfully.", priv->vid, > index); > return 0; > Maybe this patch should be backported to stable branch? If so, could you reply with the Fixes tag so that I can add it while applying? Thanks, Maxime