From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AA2CDA04A7; Mon, 24 Jan 2022 10:48:19 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3C64E410F5; Mon, 24 Jan 2022 10:48:19 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 6189540E0F for ; Mon, 24 Jan 2022 10:48:17 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1643017697; x=1674553697; h=message-id:date:to:cc:references:from:subject: in-reply-to:content-transfer-encoding:mime-version; bh=dT1IsZzxU3h2XHNIug9wwFw3N1bkpiDInZgE239VOM0=; b=PTi6KlExKcrpjP9m047F0m2JmzjOSAhdJuRiivQYavNnunFRCO8/wXoe dsybsObU5wKyFm08C+7vQwETMTqLfjMCnJdPTb/RM6tCcRjZGfs0j6Oei i1o8rssh1F/o3NMjvFEZ5SL5zBLQC5gaM8WJ/WMyCmKv+VZPv3cdiwyaj PtgJ5h5Yaj5EGWIiBw5WwWzMVs/f6WnSJv5bhOBj63b+aNHvBkcZu9bAN YLyATz+tV/cuzxg+dErkuxsBgCyrzg3DIc6qCcwR+PLzI29ae1LrcLail e3VaeStP3wE0zN8b6GI6AC0IozB4r7fJbWwHtiiDGZHYtJB5FXKys8qnK w==; X-IronPort-AV: E=McAfee;i="6200,9189,10236"; a="233367547" X-IronPort-AV: E=Sophos;i="5.88,311,1635231600"; d="scan'208";a="233367547" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jan 2022 01:48:07 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,311,1635231600"; d="scan'208";a="673572552" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga001.fm.intel.com with ESMTP; 24 Jan 2022 01:48:07 -0800 Received: from orsmsx604.amr.corp.intel.com (10.22.229.17) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Mon, 24 Jan 2022 01:48:06 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Mon, 24 Jan 2022 01:48:06 -0800 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.41) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Mon, 24 Jan 2022 01:48:01 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bRzS1BLSmTQmdQYrb/QvgKKTWTMCQcfj/CMwXEKh/HfcE8XzRFCwbtNZMQfVQa7Sg7hHXt7xZhNkcS31Kpry/B9CdRAYkb2uXfTD5M/P9irMEhz2/swNy5gWSt17FuHwjLbzlXXUJtyFmlOiTgZ3tSaFRqlrfAsJP1RTZlI8j8nyzIYGO0W7RueVyw39qZZOocQvb2duHWaZ2WQ6SKLJCVJBtuz6BCl7e0JSKaTzzAeUxEheHFlJU6iZhycaWnm4Z22aGst8/Gr4hR4vkNdjvJuWB8BxZaRR2thWHMJ/zzgYE9QoPXIN87nSsvl85IA312YWfgE/u3TAK38wHGUHrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wX6uXNaHsIbowutGifoW9RnLvwiAMO8T0p1AsbypvhQ=; b=SFFRG5BUrkD/W//jJrgxcQbZUQi4bh39+g1oCGNLKbwTee8FH106zxW1qJIu4+p8dhu7O8sxjiQ2zkBWA1sZj70ji4bh1C4nvJdbSlzmnm1rtSjFFyI5ShgCLQWoGqxxiX0/6FOrAQPB/3TmI0rKmyRcjFtmDblzXk6EaryAkJl4lyQt+sNoqWDNZJuC7eJa+x9yx993na2vIDvui9gj4wGBivo++2ifF36/WYIY4ry0IccCVrfecaYtgjBWogj54z7fUjZ78ZgkY7Bdk5prG+GnmUAQgwXeTN63UVXtzfDhwHeouh0ox5dyZInQvbweg/f486jtdvr50pxHJOLBDw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by MN2PR11MB3837.namprd11.prod.outlook.com (2603:10b6:208:f6::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4909.12; Mon, 24 Jan 2022 09:47:59 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::5046:8550:928d:850e]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::5046:8550:928d:850e%7]) with mapi id 15.20.4909.017; Mon, 24 Jan 2022 09:47:59 +0000 Message-ID: Date: Mon, 24 Jan 2022 09:47:54 +0000 Content-Language: en-US To: Kumara Parameshwaran CC: , Kumara Parameshwaran , "Stephen Hemminger" References: <20220121042944.23929-1-kumaraparamesh92@gmail.com> From: Ferruh Yigit Subject: Re: [PATCH] net/tap: Bug fix to populate fds in secondary process X-User: ferruhy In-Reply-To: <20220121042944.23929-1-kumaraparamesh92@gmail.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LNXP265CA0016.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:5e::28) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d39130e3-75ef-49a7-b047-08d9df1e9b0b X-MS-TrafficTypeDiagnostic: MN2PR11MB3837:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ACN4T85ySzwTPU25/DcmunvCmeb0n4ELH1rGKYa3HF4iF3P+nuFVyEHgwqvN6OoK6XArCQd6KmmD3gMlSA5IMRaiepUgLJfUOfiJBjGb2TtPHihwOZQVVy9UD4j6b+jecZAVRTdOpFLuOnLhlznFVO8iho27+zstTZzj/mHdx2hYblFfE7laS3ZY5dC//HAV0AsB8m0D9SpH0HX6AN49li4rYAY8cd00AKSdLQ6/ix4Kec5kzgmMh+lzyNrVmgfPZNhruUz70LKOSfWWvnHzyRb8YCApOkaTnWg+qbjXFIfgVCKGZSvCpYzLRsGAu5oNrqwuxFjcSE2MMQqXat5tPrt6/L7zNnws7RUwTt8agEhyg595IJXA2Kpw5SRe4eCvh3+9fbbokrFq67ywVGMN1j1n3qcR0V95byn41qwd++pr3msE84Rrf7JpTNsrrnR0uNVL5jAsEKaftNARVtVVpmQXFLKFRxZVh9LJAfPK8cfMJtSc1sWmeVqu1SEAFNrLM/uZpLrJDK3zbseuTbhFrmy3EKmLcw/d7gAt6Yh7OVEnCPo6kLLjq3rGTjawMgqiN13+4GcbdI1810+bTyegcal+VRiXE5Bddn6SSlg0fCzsInylCdPBKpaGWilxUWsZMe21y/x/DPgrpo6CGTPDnAzi3CcUD226fYQLRZALgJXRZiHz8jz/5N5CynrFoRaT3k0UdeNT0gdXnSplSgBYVSaeEyL0U46PuHKMwoOv/3zWGFCwhDA2qkCSm9HwbXrE80lFIL5Hh1VFgMYZjf6VRzwhjpNFMEdmU6sh3QB+A0QNCeCBuJ70ND4vsHi79oT6a4RFV4GSCMUc+wclGB/fNA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(31686004)(86362001)(31696002)(186003)(26005)(6666004)(2906002)(8936002)(54906003)(6486002)(82960400001)(6916009)(83380400001)(53546011)(5660300002)(36756003)(508600001)(2616005)(66556008)(66476007)(6512007)(8676002)(4326008)(966005)(44832011)(38100700002)(66946007)(316002)(6506007)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VUc4b2lOYSt1TldlcFIzeWVYWXQ3ekdhT0M3bzhaWkpMSGJ3T3dDUi9wL2NF?= =?utf-8?B?K01Hd1U0bkR2NlhDRkVzQ2pwaDR2SzBQdzQ3aDcycWpKZzE3NFpFVTdWemJM?= =?utf-8?B?RFphZXNZVkoyM0V1ZVAwRWU3OUZtTjBLSXNYWURGMmpWaHVQUVkvYlBkOWRh?= =?utf-8?B?eExPcTRWTjVNbnJrTWsxVzJaWWVjd29JNkJXTnFIMHp0RDZmS1lLMXBGQnZ2?= =?utf-8?B?YXFyaGJFYUZYeGlUWExDbElNSHpWTXBQRmRONjFDU0x1cHAyOC9BMmFjbjhp?= =?utf-8?B?anlkZWNLdjcwZkRkZmM3UkorRTdOY1Y4QlQ5bk1GcW1zMXNLL3ljZW9vNmUr?= =?utf-8?B?YkI0bnpGS3ltSi93UWxnVFM1Z2VtNFJiYzBQTHlPYzZZZzE1WnlSamZVZGZv?= =?utf-8?B?YkRQZFhHQmxhSFBQMkhDSStzQnllRWZxZWswTloreTlpSG85S2UwYkgvcC80?= =?utf-8?B?L1VMdFI2TVJoa3NQMWdvNFVNcENNS1F6aFkxUTFrMDJoMXh0NE1rZ0I5SHF2?= =?utf-8?B?ckN0UFY0UmhQVlZwODcxWERLUEtuSVVmaDRBZUJQMm5JMHlqYURsT21XUUZq?= =?utf-8?B?bnBFNkpiRnpXVXpMMEowVkRQZjU0Q20rQWVSVUFMZVpKamdJTk9hNWw0Tkxn?= =?utf-8?B?WU1Cd2VrQ1ZHVk4vQU5iYU5kd0JqdGFYdWJMdXJHQ25kK2lDZlRMQWdIQzU0?= =?utf-8?B?SWQ0RS94ZURIWWhVcnNRZkROYTg0bkJLYmdJd1BQMGtsYjhhSTU2R0RsRXJt?= =?utf-8?B?QXkvZllMa01DeUs3bEpEdUxqYW1rc1VMeGFJbWorRXlSVnpVYlZySWJoWVJV?= =?utf-8?B?L0xDZjNhN1FtR3lEZnNHZHREV0piTTAzSTVCQ2RWL0xMUmF3TlNiUEtkU0tT?= =?utf-8?B?QlhyajRvQUFRSzRCOXQ5MkVhTlN6UWRzd2lEV2RYbENzYjVZdzVFK0hPaTlz?= =?utf-8?B?UUYwaFoxK1IxWDZ6QlhLS0pnZXdqMUVsbUdFQzc4aFkyUURwa01rc3crZzJt?= =?utf-8?B?RGJNVHltd0FEWnQxYVZXUjR2Qm5PdTRLZHE2T21LcWtvL0RKLzBRYnhCRGNw?= =?utf-8?B?K0N3SEd2VHhEbS9kOGNXdHEyalpmVk8xck83SVQraWtPa0ZuMDFQTzJ4Ynlp?= =?utf-8?B?V1JZNkgzNnEvYVc5NHFnMDVTN0tIWHNtQ0gycE9TQnNGb1JRK1ZacXpkRndT?= =?utf-8?B?bmhtMDFBczNVcnduREFJeEI1akV5QW1XY1FxcWgyenhIVGRiZXlKYm9IVTFk?= =?utf-8?B?N1FiUWRVMUkzeHEza0FIVFpPSmVOdjhDQWp5UlkvaldqdFNKalNwZTRHSGpa?= =?utf-8?B?Q3l0aUFMYUR5a2ltdzZheXZkU3dqM3NVTmQ1ckRITmRicThYK0pMUUE5bjhn?= =?utf-8?B?Zyt1cW9Xbjc5QU9qTDdzdFFBd2FyNW5EVkJFZU5qNkZkalRBSThkZGF3Q0R1?= =?utf-8?B?b3Z2VTFWeFY4R2dJbzAydnJ2RGxCbjBkWTJObmdTa1QxNDgybGZHeVV2QTNT?= =?utf-8?B?K1VFUzZYWnh4WTBSaWthT0Nqa1c4RlZWYnZ2VmdTM0R4LzR5Z0JFNkRrekV6?= =?utf-8?B?cG5PdFR4Nlc2OXNJYVR2QVowOXliYTMyMVczbzVpRnk2Y0tPR2F0b2phNW16?= =?utf-8?B?WGZyVWRJWnM5bFl5dmlFMzhabkZTSENobTBZcmZ2OTJ3eHYwMExudTUrWTRk?= =?utf-8?B?WHBDVnYyNk9aVWRrU0dqVTJwK2tsY2p4MmtaVEY1dFp5TnVCckZ1RjZZQy82?= =?utf-8?B?MzFIR29RM2toVWcvOHp4TWp5Q292b3RaWW1tMnMzYjZ6V25OZkRZdzRMNmVo?= =?utf-8?B?UVp3dmpxV3hmUXFmRlR5MitQbUxPNGQrREpocGM5ZUp0ZW9Ia1ZYRzMvTmlM?= =?utf-8?B?VkhDM25aTG1INWNVQjA2Q1daZGpOYktabW8zanpoQzFQQmE3azVHdmVSVjls?= =?utf-8?B?SDE5bWNvYWhYaFpUVUk2THJDTVl1V2pKMG5ldE5ib0hnQmFIRmZ0NXNkNEV5?= =?utf-8?B?SGljTThqVFpEU2JDdkVUZWxYVTJRVW9MMDc4bTNYQlMwcEYxcU1WSzFyU202?= =?utf-8?B?SkVMWlVMNjVhWGxrK0hNQWVwa3d1eXVHZGltNG45SlNRaXpjNFZteUUwb0l1?= =?utf-8?B?TkhIOGFFQmxOeVdUVWxBSjJmTjNYeTVOTlA0aWZDdmYreFJLTTVTZWIvVTV0?= =?utf-8?Q?DSL7VQp6Mjf/6yEGs/V3Geg=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: d39130e3-75ef-49a7-b047-08d9df1e9b0b X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jan 2022 09:47:59.5226 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: TYaKc50pd0ET0B/B6As7y7eIW4qXpA8O4e0oRvWX/P+oa05IaT+dtFesx2TRyq9XQWriE6IvIcGKvv2EKzHPMg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB3837 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 1/21/2022 4:29 AM, Kumara Parameshwaran wrote: > From: Kumara Parameshwaran > > When a tap device is hotplugged to primary process which in turn > adds the device to all secondary process, the secondary process > does a tap_mp_attach_queues, but the fds are not populated in > the primary during the probe they are populated during the queue_setup, > added a fix to sync the queues during rte_eth_dev_start > > Signed-off-by: Kumara Parameshwaran > --- > drivers/net/tap/rte_eth_tap.c | 196 +++++++++++++--------------------- > lib/ethdev/rte_ethdev.c | 11 ++ > lib/ethdev/rte_ethdev.h | 17 +++ > lib/ethdev/version.map | 2 + > 4 files changed, 102 insertions(+), 124 deletions(-) Hi Kumara, I see you have sent multiple version of the patch, but it is very hard to follow them in the way you did it, can you please check: https://doc.dpdk.org/guides/contributing/patches.html And briefly: - Please put a version information in the patch title, like: [PATCH v2] .... There are "git format-patch" or "git send-email" argument to do this easily - Keep a changelog in the patch, as a note (after "---" in the commit log), like: Signed-off-by: ... --- V3: * Added this, removed that v2: * Rewrite from scratch - Keep all version of your patches in same email thread, this can be done via "git sent-email", '--in-reply-to' argument, please check documents. This helps to keep all version and change requests and changes grouped, so makes it easy to manage. Also for archives, it makes easier to find out all versions and see the stages of improvement, otherwise it is very hard to trace a past feature from archives. And as far as I got, last patch you send makes the API experimental, but the API is for drivers (not applications), so it should be defined in 'ethdev_driver.h' and marked as internal, also in INTERNAL group. (I already commented this one of the other version of the patch) Another thing is, there are some checkpatch warnings, you can see check results in the "Checks" box of: https://patches.dpdk.org/project/dpdk/patch/20220121042944.23929-1-kumaraparamesh92@gmail.com/ The "ci/checkpatch" test is colored as yellow, if you click it you will see the warning. And I am pretty sure internal tool './devtools/check-git-log.sh' will have a few things to complain. Can you please solve above checkpatch and check-git-log warnings in next version? Thanks, ferruh