From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CBD63A0545; Tue, 20 Dec 2022 15:05:14 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 746C840685; Tue, 20 Dec 2022 15:05:14 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 7B22540395 for ; Tue, 20 Dec 2022 15:05:13 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1671545112; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qXLjK4+6Qa8TwTo9IpSohgvJLTyfloBypZhzcQqFAC8=; b=Wa/cemwkrQVbYZBCyuzhZnsyI5JBviLGjT09kzSkD+XmAosXLMX3LS4sTy+OnI7cuIWZiT ZtJgib7TxBxKYWjVS3u5lrPxu3Kc4u4dnBS++4JlfTfBVUiyEpsr8SVIHzmim4q8hDYoWg TK7HCFQ0ua8qv6vHFOkm1TpyMCfrLQQ= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-460-VKIveF6FNpaqwEYw8gi3wQ-1; Tue, 20 Dec 2022 09:05:11 -0500 X-MC-Unique: VKIveF6FNpaqwEYw8gi3wQ-1 Received: by mail-wm1-f69.google.com with SMTP id q21-20020a7bce95000000b003d236c91639so2667881wmj.8 for ; Tue, 20 Dec 2022 06:05:11 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:subject:from:references:cc:to :content-language:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qXLjK4+6Qa8TwTo9IpSohgvJLTyfloBypZhzcQqFAC8=; b=mex2ifCusLonllG7F0Z+pimrDNM+zGVSZh4xKkAvqD5H1tSKfkWy6+VMt+jMDWy5he Oo5ts4uOT34bo5kiJyC08797nV3g1DNad83pTPXqEo43GJg8yEyjlti94bq7ICvFOqN0 MkRdHaO0zSJ57BV+BbuAzMVyM/WIEH/h00BgujWbljDysyZKYePwJNXTQHdc2vPHqwtz b0PgmAy+Yb1Pc8Cr2aA6ka1dFvsRK+Ldvbon6r9CatzEl6XJLvQEmPTXNYrV1tqHY65w xb+bXKmaig8Ra2fq8Mwbncd3Qkpnv5D/yTmXZOW+fsBjqAx8leoOYLEZ4zQjJDIigifo u2qA== X-Gm-Message-State: ANoB5pnCfBrRk2KaEGhdGT69Ta19LEvOx3peJJZFYALUY/iAqASyAbLR 0M1pOB+SLzdT0CPJ4F/JgEvochT9eZk/5f9YZZdwkgwlmSQfKWDAoshizxadGE3bA5cc6fpRYYa I1ig= X-Received: by 2002:adf:ef42:0:b0:242:647d:9c57 with SMTP id c2-20020adfef42000000b00242647d9c57mr29142941wrp.36.1671545109673; Tue, 20 Dec 2022 06:05:09 -0800 (PST) X-Google-Smtp-Source: AA0mqf6KARcpxjb8BUD/bJemT10w7Qn6xWtC+RXxH1nBNVDOKQHozkAu2SjTkO5Q0UwjP21rstewaQ== X-Received: by 2002:adf:ef42:0:b0:242:647d:9c57 with SMTP id c2-20020adfef42000000b00242647d9c57mr29142924wrp.36.1671545109431; Tue, 20 Dec 2022 06:05:09 -0800 (PST) Received: from [192.168.0.36] ([78.17.251.111]) by smtp.gmail.com with ESMTPSA id d7-20020a5d5387000000b00241e4bff85asm12757986wrv.100.2022.12.20.06.05.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Dec 2022 06:05:08 -0800 (PST) Message-ID: Date: Tue, 20 Dec 2022 14:05:06 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 To: Ciara Loftus , dev@dpdk.org, Andrew Rybchenko , "Zhang, Qi Z" Cc: thomas@monjalon.net, ferruh.yigit@xilinx.com References: <20220624102354.1516606-1-ciara.loftus@intel.com> From: Kevin Traynor Subject: Re: [PATCH] net/af_xdp: make compatible with libbpf v0.8.0 In-Reply-To: <20220624102354.1516606-1-ciara.loftus@intel.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 24/06/2022 11:23, Ciara Loftus wrote: > libbpf v0.8.0 deprecates the bpf_get_link_xdp_id and bpf_set_link_xdp_fd > functions. Use meson to detect if libbpf >= v0.7.0 is linked and if so, use > the recommended replacement functions bpf_xdp_query_id, bpf_xdp_attach > and bpf_xdp_detach which are available to use since libbpf v0.7.0. > > Also prevent linking with libbpf versions > v0.8.0. > > Signed-off-by: Ciara Loftus Hi Andrew/Qi (assuming Ciara is still out of office), I am seeing a similar issue [1] on 21.11 branch with Fedora 37 (libbpf-0.8.0-2.fc37.x86_64 and libxdp-1.2.6-1.fc37.x86_64). This patch alone won't apply as there are other dependencies. Looking at the commits in main branch, it seems like I could take all these [2] to resolve the issue. With these cherry-picked the build warnings on Fedora 37 are removed. It's a bit late to take these for DPDK 21.11.3 as I intend to release later today/tomorrow, so it can be resolved for DPDK 21.11.4. Do the commits below look ok for backport? Main branch might be able to demand user uses new libbpf/libxdp versions etc, but with stable we never want to break the users existing setup when they upgrade from 2X.11.n to 2X.11.n+1. Let me know what you think? thanks, Kevin. [1] https://paste.centos.org/view/e4eec764 [2] 1eb1846b1a net/af_xdp: make compatible with libbpf 0.8.0 5ff3dbe6ce net/af_xdp: add log on XDP program removal failures 0ed0bc3834 net/af_xdp: avoid version-based check for program load e024c7e838 net/af_xdp: avoid version-based check for shared UMEM f76dc44ded net/af_xdp: make clear which libxdp version is required 50b855fc47 net/af_xdp: move XDP library presence flag setting