From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 350191B251 for ; Tue, 10 Oct 2017 10:53:24 +0200 (CEST) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Oct 2017 01:53:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,504,1500966000"; d="scan'208";a="160904080" Received: from dwdohert-mobl.ger.corp.intel.com (HELO [163.33.228.229]) ([163.33.228.229]) by fmsmga005.fm.intel.com with ESMTP; 10 Oct 2017 01:53:23 -0700 To: Ferruh Yigit , zengganghui , "dev@dpdk.org" References: <1504064774-6340-1-git-send-email-zengganghui@huawei.com> <8ae48210-7291-7ee5-a17c-c82f9ed116cd@intel.com> <7683DD995282C14797C50C5AB01DF6D6B8C010@DGGEMA504-MBX.china.huawei.com> <2cbd474d-6505-9188-97ae-476a5edb16ef@intel.com> <7683DD995282C14797C50C5AB01DF6D6B8D124@DGGEMA504-MBX.china.huawei.com> <029f043f-7e7d-e638-d718-c61e34100e56@intel.com> <7683DD995282C14797C50C5AB01DF6D6B8D84F@DGGEMA504-MBX.china.huawei.com> <972b7ffc-8eb4-86e3-5e80-a57025c00407@intel.com> From: "Doherty, Declan" Message-ID: Date: Tue, 10 Oct 2017 09:53:22 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <972b7ffc-8eb4-86e3-5e80-a57025c00407@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] net/bonding: strengthen the judgment of lacp packets X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Oct 2017 08:53:25 -0000 On 03/10/2017 4:49 PM, Ferruh Yigit wrote: > On 9/19/2017 5:09 AM, zengganghui wrote: >> Local LACP packets do not have VLANs, and ethertype must be ETHER_TYPE_SLOW. But when the PMD supports VLAN strip, you cannot directly determine the ethertype from the packet, but depends on whether the VLAN is stripped. If a VLAN is stripped, then this is not a local LACP packet, but it may be a need to pass through packet. The previous code was not rigorous in determining whether the VLAN was being stripped. >> Did I answer your question? > > Hi Declan, > > Are you OK with the patch? > You already have your ack on patch but discussion was going on... > > ... > Hey Ferruh, sorry I missed this mail, yes I'm happy for this to be applied.