From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id ED9B1A034F; Mon, 11 Oct 2021 14:21:12 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AFBAE40142; Mon, 11 Oct 2021 14:21:12 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id CC5284003C for ; Mon, 11 Oct 2021 14:21:10 +0200 (CEST) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 1B1A97F514; Mon, 11 Oct 2021 15:21:10 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 1B1A97F514 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1633954870; bh=FNmShQv51HMGLa9qBSbhrB9GIO6sn5PeAncyINP2vDA=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=rJzgWHgJMg3cJrqv5iJlaXK9SL//aL3MS682UJlueaFznVqdBinwu1+mRCrXkOHWa F/1WmiBTdWoGdwhNL+pwZQl9e8OJwxLl6Y2fsWEBMp9+kwxJFFD+BZ7RmiW4Y2Pv42 vaZazSpVuaKDwTjbk2wEc7KZFrJGUQEkHxEQbpJU= To: Jie Wang , dev@dpdk.org Cc: ferruh.yigit@intel.com, thomas@monjalon.net, xiaoyun.li@intel.com, stevex.yang@intel.com References: <20211008034111.14121-1-jie1x.wang@intel.com> <20211011180111.99281-1-jie1x.wang@intel.com> <20211011180111.99281-2-jie1x.wang@intel.com> From: Andrew Rybchenko Organization: OKTET Labs Message-ID: Date: Mon, 11 Oct 2021 15:21:10 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20211011180111.99281-2-jie1x.wang@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v11 1/2] ethdev: add an API to get device configuration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/11/21 9:01 PM, Jie Wang wrote: > The driver may change offloads info into dev->data->dev_conf > in dev_configure which may cause port->dev_conf and port->rx_conf port->dev_conf does not make sense outside of testpmd. So, it should not be mentioned in the description here. > contain outdated values. > > This patch adds a new API "rte_eth_dev_conf_get()" to help users > get device configuration. May be: Add a new API to get actual device configuration. > > Add information about the new API in release notes. It should not be in the changeset description. > > Signed-off-by: Jie Wang > --- > doc/guides/rel_notes/release_21_11.rst | 5 +++++ > lib/ethdev/rte_ethdev.c | 20 ++++++++++++++++++++ > lib/ethdev/rte_ethdev.h | 20 ++++++++++++++++++++ > lib/ethdev/version.map | 3 +++ > 4 files changed, 48 insertions(+) > > diff --git a/doc/guides/rel_notes/release_21_11.rst b/doc/guides/rel_notes/release_21_11.rst > index 93082723cf..789fc2d4ba 100644 > --- a/doc/guides/rel_notes/release_21_11.rst > +++ b/doc/guides/rel_notes/release_21_11.rst > @@ -67,6 +67,11 @@ New Features > Added macros ETH_RSS_IPV4_CHKSUM and ETH_RSS_L4_CHKSUM, now IPv4 and > TCP/UDP/SCTP header checksum field can be used as input set for RSS. > > +* **Added support for users get device configuration in ethdev.** > + > + Added an ethdev API which can help users get device configuration. > + The declarations for the API's can be found in ``rte_ethdev.h``. The second line is not necessary since it is a well-known location of the ethdev API declarations. > + > * **Updated Broadcom bnxt PMD.** > > * Added flow offload support for Thor. > diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c > index 028907bc4b..be3ceb8131 100644 > --- a/lib/ethdev/rte_ethdev.c > +++ b/lib/ethdev/rte_ethdev.c > @@ -3437,6 +3437,26 @@ rte_eth_dev_info_get(uint16_t port_id, struct rte_eth_dev_info *dev_info) > return 0; > } > > +int > +rte_eth_dev_conf_get(uint16_t port_id, struct rte_eth_conf *dev_conf) > +{ > + struct rte_eth_dev *dev; > + > + RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV); > + dev = &rte_eth_devices[port_id]; > + > + if (dev_conf == NULL) { > + RTE_ETHDEV_LOG(ERR, > + "Cannot get ethdev port %u configuration to NULL\n", > + port_id); > + return -EINVAL; > + } > + > + memcpy(dev_conf, &dev->data->dev_conf, sizeof(struct rte_eth_conf)); > + > + return 0; > +} > + > int > rte_eth_dev_get_supported_ptypes(uint16_t port_id, uint32_t ptype_mask, > uint32_t *ptypes, int num) > diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h > index 6d80514ba7..f42f950fea 100644 > --- a/lib/ethdev/rte_ethdev.h > +++ b/lib/ethdev/rte_ethdev.h > @@ -3052,6 +3052,26 @@ int rte_eth_macaddr_get(uint16_t port_id, struct rte_ether_addr *mac_addr); > */ > int rte_eth_dev_info_get(uint16_t port_id, struct rte_eth_dev_info *dev_info); > > +/** > + * @warning > + * @b EXPERIMENTAL: this API may change without prior notice. > + * > + * Retrieve the configuration of an Ethernet device. > + * > + * @param port_id > + * The port identifier of the Ethernet device. > + * @param dev_conf > + * A pointer to a structure of type *rte_eth_conf* to be filled with I think there is no point to duplicate type in the parameter description. > + * the configuration of the Ethernet device. > + * And the memory of the structure should be allocated by the caller. May be just: Location for Ethernet device configuration to be filled in. > + * @return > + * - (0) if successful. > + * - (-ENODEV) if *port_id* invalid. > + * - (-EINVAL) if bad parameter. > + */ > +__rte_experimental > +int rte_eth_dev_conf_get(uint16_t port_id, struct rte_eth_conf *dev_conf); > + > /** > * Retrieve the firmware version of a device. > * > diff --git a/lib/ethdev/version.map b/lib/ethdev/version.map > index efd729c0f2..c516837723 100644 > --- a/lib/ethdev/version.map > +++ b/lib/ethdev/version.map > @@ -245,6 +245,9 @@ EXPERIMENTAL { > rte_mtr_meter_policy_delete; > rte_mtr_meter_policy_update; > rte_mtr_meter_policy_validate; > + > + # added in 21.11 > + rte_eth_dev_conf_get; > }; > > INTERNAL { >