From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 07F79A0C4B; Sun, 12 Sep 2021 14:44:48 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 78DE740041; Sun, 12 Sep 2021 14:44:48 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 764734003D for ; Sun, 12 Sep 2021 14:44:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1631450686; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wM8vGuIDWtQPCSF9DM+tw9B4WPFSkjpOZtLiZj6dpwY=; b=V5DrtkR+/RKY6WE/uhpdihVf5n4W05zoHEl0dt3wuzEeZNE5YWplco35/63E4CNETGMaEF RP6cYQ3DEZWYx2Rb67rG0mLcRXWftnNkjo4IIvZ2l28sAwsbSVZySM7WXWzvpcVwKo3iI9 6xyhUHSL1CH3TOUhPuSbPUWkIGV9yRY= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-126-Cfzfj6VfPDeFeWRGS_BDgQ-1; Sun, 12 Sep 2021 08:44:45 -0400 X-MC-Unique: Cfzfj6VfPDeFeWRGS_BDgQ-1 Received: by mail-qv1-f69.google.com with SMTP id e8-20020a0cf348000000b0037a350958f2so53731362qvm.7 for ; Sun, 12 Sep 2021 05:44:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=wM8vGuIDWtQPCSF9DM+tw9B4WPFSkjpOZtLiZj6dpwY=; b=dCv44jjU6dR5sW95dQBU7ZNSg7Y9cEsDnAN7G/5PCWFCorQXuSapu2Dr+A9FHXg/gp 2CMzRpGVRGzylHHiaDYQKTfQgPWMcVMKWhn03oVFSd9qt1j+4fn2gSMCPJiTWU+lHpd+ mylVoAv7pRpjKvvUDUwLrmvkprA4qZEnxgsCFdcR/dLhTxld0dz30eTrJy53u/s7h1kM d1EUE7UiOa5dOybS4mJTEOIuzffyzRGV2PCgfLRkPvAneGoUhckE8UrEizopfsEzL9B1 9sujm1R/FoyaXs6gaCQGDS+4Yxuls4Dns4jZrBLMcUCci7A9oVgJZZnceLETLXySwzi3 ++Ew== X-Gm-Message-State: AOAM531qia6pWp2ZhrvJQ3B8Xa49fSgUjg3muQHh1aZDvB4EnyP2nkwE Gj9IV8Nh3i7GXdn/+t3ElJbd54H1SJqaHtgDg43Zrb575YiAZ6mFxfCWJFRb57BmuCGxpAtK1KI UnY0= X-Received: by 2002:ac8:4892:: with SMTP id i18mr5590915qtq.13.1631450684430; Sun, 12 Sep 2021 05:44:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyuUxXPWFNjv6xrmKt4ciCvHw3/0CTZvs0Uq5CdTPMiRVHRXl4iODT3wCx0LK8MKV3sk1+O8w== X-Received: by 2002:ac8:4892:: with SMTP id i18mr5590905qtq.13.1631450684257; Sun, 12 Sep 2021 05:44:44 -0700 (PDT) Received: from localhost.localdomain (075-142-250-213.res.spectrum.com. [75.142.250.213]) by smtp.gmail.com with ESMTPSA id p123sm3215790qke.94.2021.09.12.05.44.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 12 Sep 2021 05:44:43 -0700 (PDT) To: Nicolas Chautru , dev@dpdk.org, gakhil@marvell.com Cc: thomas@monjalon.net, hemant.agrawal@nxp.com, mingshan.zhang@intel.com, arun.joshi@intel.com References: <1631063741-28631-1-git-send-email-nicolas.chautru@intel.com> <1631063741-28631-6-git-send-email-nicolas.chautru@intel.com> From: Tom Rix Message-ID: Date: Sun, 12 Sep 2021 05:44:41 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <1631063741-28631-6-git-send-email-nicolas.chautru@intel.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=trix@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH v3 5/6] doc: clarification of usage of HARQ in bbdev doc X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/7/21 6:15 PM, Nicolas Chautru wrote: > New paragraph detailing typical VRAN usecase and mapping > to bbdev API usage. > > Signed-off-by: Nicolas Chautru > --- > doc/guides/prog_guide/bbdev.rst | 23 +++++++++++++++++++++++ > 1 file changed, 23 insertions(+) > > diff --git a/doc/guides/prog_guide/bbdev.rst b/doc/guides/prog_guide/bbdev.rst > index 8bd7cba..f39b62f 100644 > --- a/doc/guides/prog_guide/bbdev.rst > +++ b/doc/guides/prog_guide/bbdev.rst > @@ -1054,6 +1054,29 @@ capability RTE_BBDEV_LDPC_INTERNAL_HARQ_MEMORY_OUT_ENABLE is set > then the HARQ is stored in memory internal to the device and not visible > to BBDEV. > > +.. note:: > + More explicitly for a typical usage of HARQ retransmission in a VRAN > + application using a HW PMD, there will be 2 cases. > + > + For 1st transmission, only the HARQ output is enabled : > + > + - the harq_combined_output.offset is provided to a given address. ie. typically an integer index * 32K, where the index is tracked by the application based on code block index for a given UE and HARQ process. > + > + - the related operation flag would notably include RTE_BBDEV_LDPC_HQ_COMBINE_OUT_ENABLE and RTE_BBDEV_LDPC_HARQ_6BIT_COMPRESSION. > + > + - note that not explicit flush or reset of the memory is required. > + > + For 2nd transmission, an input is also required to benefit from HARQ combination gain: > + > + - the changes mentioned above are the same (note that rvIndex may be adjusted). > + > + - the operation flag would additionally include the LDPC_HQ_COMBINE_IN_ENABLE flag. > + > + - the harq_combined_input.offset must set to the address of the related code block (ie. same as the harq_combine_output index above for the same code block, HARQ process, UE). > + > + - the harq_combined_input.length must be set to the length which was provided back in the related harq_combined_output.length when it has processed and dequeued (previous HARQ iteration). > + > + > The output mbuf data structures are expected to be allocated by the > application with enough room for the output data. > Fine. Reviewed-by: Tom Rix