From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A1999A04B5; Wed, 30 Sep 2020 10:45:45 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C5EBF1D6FE; Wed, 30 Sep 2020 10:45:43 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by dpdk.org (Postfix) with ESMTP id 6D4341D6F6 for ; Wed, 30 Sep 2020 10:45:41 +0200 (CEST) Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1601455539; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=nryLqsuMVBMqbqkgSfpgZGbQBNCyvJ2Sm9Q271hsWRQ=; b=eM5bf9XVeaGGqPSyTSSw/Ck34Z4/McrLEFeIZ0rI1+MZgpMWvXYqELDSAfjZtNO4smnNdc I24OFZURDg5lZxtzlZePNGVfd1wP3+2ZZ224fBk61CRklNEiE2/6Bk6gh+i/aZlTpBv8RE GDaqd4KMhKscsE4PEgUkW4W7K05OFRg= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-369-w6gFpXBzOLSVid6cVMDMRw-1; Wed, 30 Sep 2020 04:45:37 -0400 X-MC-Unique: w6gFpXBzOLSVid6cVMDMRw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7B74764083; Wed, 30 Sep 2020 08:45:36 +0000 (UTC) Received: from [10.33.36.225] (unknown [10.33.36.225]) by smtp.corp.redhat.com (Postfix) with ESMTP id CE9D919D61; Wed, 30 Sep 2020 08:45:34 +0000 (UTC) To: Ruifeng Wang , "Medvedkin, Vladimir" , Bruce Richardson Cc: "dev@dpdk.org" , Honnappa Nagarahalli , nd References: <20200907081518.46350-1-ruifeng.wang@arm.com> <20200907081518.46350-3-ruifeng.wang@arm.com> <20200915160224.GA825@bricha3-MOBL.ger.corp.intel.com> <81eb8fde-cd4f-1df9-0ebb-05c902b30fe3@intel.com> From: Kevin Traynor Autocrypt: addr=ktraynor@redhat.com; keydata= mQINBF2J2awBEADUEPNhgNI+nJNgiTAUcw4YIgVXEoHlsNPyyzG1BEXkWXALy0Y3fNTiw6+r ltWDkF9jzL9kfkecgQ67itGfk1OaBXgSGKuw1PUpxAwX2Bi76LAR6M5OsyGM9TSVVQwARalz hMwRBIZPzPc7or6Pw7jAOJ8SQGJ1Zlp1YJCjrvpe87V1tH/LY8Wnxn/EuoseFmWILAQZAtYS tGjcrAgYn3SPMLR1B0BP5bTBY06vWQjiufH8drenfDnMJAzuBdG1mqjnTqCjULZ3Hunv4xqZ aMnkvL/K5Tj1c12Oe4930EE53LrXIBUltRg5mBudSWHnC7twjH0082HH9f963Z/2UI63SFIT iUvRvAzJYytgy7XnWLQ0+goZBADKYfolOuC0H8VgCaux8u8KFF28Dy+N6TV2KI58jTlyg1Zu l7QwykZpnOkJFiy37Gfbu3YEOzO72cP/S7/A+zvuqkxi63jyEkd+FY99vLt/HN2MUZwRmKDw UPbLkmrs8WU01/POVsqDcfvz7vu2St8hqqTiSIdQGS2zyTKB2/DvPSM3jws3udkIYSuhn+X4 QBiV6lkVZ7DSE6a065gnAauAql+b32Eymy+xnG5jCt1tR+0Cp2VZYCR9OU2gmomUKBDoX/He pSgED01CqYPNjN+TddirwmQX7ep4DtXc8FWvv2g/pq9WZFQk2QARAQABtCNLZXZpbiBUcmF5 bm9yIDxrdHJheW5vckByZWRoYXQuY29tPokCTgQTAQgAOBYhBAoiOaH51tHF7VYtEI9CINER a+yJBQJdidmsAhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEI9CINERa+yJoxIP/3VF 2TIgW4ckxhRFCvFu/606bnvCPie88ake4uWVWMAWwcMc4fKEltRWRCpkSVOwgqoMHnyHxK5r kOKzx2CLJMX5TgTMfKzPuaBDHngHLUzl2DStpBzrod0cVg5TShdmmfjY61uxRJKz+DlSkwgJ riADdVF5PPosQXTkKSGf2ombpTGpx/pue9ocjnr3x4SDpRLlnooM6Jf/3Y3Ib4jX6HPEyWuY b+owIIk9y2nRRGPQ6jbqAhsrXd9V+77UL0QuGWloMuKMZFbNg8hbu7X5aFijAbfxj4YUgojS ba7gfGZQan8h32A9KGQWrmsCBc3j2GqEPsX0r05X7cn7WL6IOPgQJ5EiQ7PlazQYVLrvZg9B n0GKK0k6895mLG0ZZ5v/qajOPF52etSmvFD1WUPb4OqaHqGA9ZtMpaKFRt7Y6rpXqKNU1xzW F5KjbTPtTb9WF3An8dciVv+AYUI7totkZYkWvQtgss8lfaX3NKUvXLVxqK0z3dQyr7rF/tYz PneTKypSksjCgaEBLSrsRmM5zKfe7tSNF/fDntfIq/029Jtcw29TcWEP57peNu6TtejewQD9 sTI+oqiXvW2D5l7LNUDYG8eMJp2oT7I0ZSBRvwcbmjH0DtN/bXCCFfCvk8Yic68F3tV1ctix wQARVKDBhT30uCxycRWojCYqTgNJJS71uQINBF2J2awBEADP57PR2IpSYBeNSrsAjeIcsahE N4SQP2C4s50S8QEWAUhqMRI7WNv5cfeef0nDvcl1IUA6oz5SokbcsbMa+mRgaNF4N5KikWTO LPYxq2YVJoXwJ+tKmNzyOLFUIfFJ4NBJZple5dTfWzD00Dbb19Mri1hy1mWMqNTPGBee1+hw Qcp6n3mmGECvajs8G5A7NyXbwL8ihN7HX9D01ucD62b4G03yKe2g/hvKgcdUVmhCldJlF27I 2fSR9tDxH9pZqRODY4rjbFZEey/vWKXqjE+DQ8AtMSEaDfFe5D+i4Aw6erWQ3Wr+DwZt1/7G dIAElGA/q90T1ENVwJX9y7fsQssawKYYdDqURHCl5JuDXI+VXUypExipUUT5SPycMmbLsx0D iKEqPPDQWKxkIDVKqj2+EhamSuJznZUwBLJKn0h4zrIWiXWUy07lRwtVuhaDXhF3GfW+5W/x wAg7Qg3w00ASsb/XTHBIhMnenKDfS7ihtQA8SacwX8ySdxb+15XPyiplM979qBQ0mhnilulm MIJzEf/JxoYR5huuj4f1PFqqrsP06Dl+YGB7dQZp3IKggS5c3/TAynARRg9N89UsDXNtp7X0 tgIPFF5k6fnHE0J5O64GYHeTqN/1aE6dAEOV9WrGzQAJxU9ipikb8jKAWXzLewRIKGmoPcRZ WdB0NmIjmQARAQABiQI2BBgBCAAgFiEECiI5ofnW0cXtVi0Qj0Ig0RFr7IkFAl2J2awCGwwA CgkQj0Ig0RFr7IkkORAAl/NbX93WK5MEoRw7/DaPTo/Lo6Pj1XMeSqGyACigHK/452UDvlEH NjNJMzYYrNIjMtEmN9VVCfjT38CSca7mpGQVwchc0mC7QSPAETLCS+UacVf/Kwxz5FfkEUUw UT7A+uyVOIgW3d9ldlRzkHA2czonSSgTQU+i2g6DM4ha+BuQb4byAXH6HQHt/Zh1J64z0ohH v6iGsCzCY/sMWF8+LEGSnzMGRCLiiwSF0vJBHbzWK68fANaF4gBV0Z/+6tQRFN7YMhj/INmk qgvHj1ZzHFNtirjMGPRxoZs51YoLQM/aBPxKrnmXThx1ufH+0L6sGmFTugiDt0XSEkC5reH7 a+VhQ1VTFFQrClA8NmDSPzFeuhru4ryaaDHO+uEB16cNHxHrQtlP/2hts2JM5lwkZRWJ5A57 h8eDEIK5be47T85NVHfuTaboNRmgg1HygVejhGUtt69u/0MVRg/roUTa0FyEbNsvz4qAecyW yWzMcVrcGJDQLC9JLKEpoyUF6gdTKaiDL2Vao4+XRIA3Y57b6MO35a3HuzAv7+i5Z0mnDEJO XxXqTOmKYpMIGexzM/PtuA0712sT1abG9tAJ17ao/B7cqMW5IkKkalemFbWfI2unns4Papvo tk9igVqyp6EJDU98z5TJioCVojwK2laDaoIjTJk9YYv3iwCsqPd5feU= Message-ID: Date: Wed, 30 Sep 2020 09:45:33 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 2/2] lpm: hide internal data X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 16/09/2020 04:17, Ruifeng Wang wrote: > >> -----Original Message----- >> From: Medvedkin, Vladimir >> Sent: Wednesday, September 16, 2020 12:28 AM >> To: Bruce Richardson ; Ruifeng Wang >> >> Cc: dev@dpdk.org; Honnappa Nagarahalli >> ; nd >> Subject: Re: [PATCH 2/2] lpm: hide internal data >> >> Hi Ruifeng, >> >> On 15/09/2020 17:02, Bruce Richardson wrote: >>> On Mon, Sep 07, 2020 at 04:15:17PM +0800, Ruifeng Wang wrote: >>>> Fields except tbl24 and tbl8 in rte_lpm structure have no need to be >>>> exposed to the user. >>>> Hide the unneeded exposure of structure fields for better ABI >>>> maintainability. >>>> >>>> Suggested-by: David Marchand >>>> Signed-off-by: Ruifeng Wang >>>> Reviewed-by: Phil Yang >>>> --- >>>> lib/librte_lpm/rte_lpm.c | 152 +++++++++++++++++++++++--------------- >> - >>>> lib/librte_lpm/rte_lpm.h | 7 -- >>>> 2 files changed, 91 insertions(+), 68 deletions(-) >>>> >>> >>>> diff --git a/lib/librte_lpm/rte_lpm.h b/lib/librte_lpm/rte_lpm.h >>>> index 03da2d37e..112d96f37 100644 >>>> --- a/lib/librte_lpm/rte_lpm.h >>>> +++ b/lib/librte_lpm/rte_lpm.h >>>> @@ -132,17 +132,10 @@ struct rte_lpm_rule_info { >>>> >>>> /** @internal LPM structure. */ >>>> struct rte_lpm { >>>> - /* LPM metadata. */ >>>> - char name[RTE_LPM_NAMESIZE]; /**< Name of the lpm. */ >>>> - uint32_t max_rules; /**< Max. balanced rules per lpm. */ >>>> - uint32_t number_tbl8s; /**< Number of tbl8s. */ >>>> - struct rte_lpm_rule_info rule_info[RTE_LPM_MAX_DEPTH]; /**< >> Rule info table. */ >>>> - >>>> /* LPM Tables. */ >>>> struct rte_lpm_tbl_entry tbl24[RTE_LPM_TBL24_NUM_ENTRIES] >>>> __rte_cache_aligned; /**< LPM tbl24 table. */ >>>> struct rte_lpm_tbl_entry *tbl8; /**< LPM tbl8 table. */ >>>> - struct rte_lpm_rule *rules_tbl; /**< LPM rules. */ >>>> }; >>>> >>> >>> Since this changes the ABI, does it not need advance notice? >>> >>> [Basically the return value point from rte_lpm_create() will be >>> different, and that return value could be used by rte_lpm_lookup() >>> which as a static inline function will be in the binary and using the >>> old structure offsets.] >>> >> >> Agree with Bruce, this patch breaks ABI, so it can't be accepted without prior >> notice. >> > So if the change wants to happen in 20.11, a deprecation notice should have been > added in 20.08. > I should have added a deprecation notice. This change will have to wait for next ABI update window. > Do you plan to extend? or is this just speculative? A quick scan and there seems to be several projects using some of these members that you are proposing to hide. e.g. BESS, NFF-Go, DPVS, gatekeeper. I didn't look at the details to see if they are really needed. Not sure how much notice they'd need or if they update DPDK much, but I think it's worth having a closer look as to how they use lpm and what the impact to them is. > Thanks. > Ruifeng >>>> /** LPM RCU QSBR configuration structure. */ >>>> -- >>>> 2.17.1 >>>> >> >> -- >> Regards, >> Vladimir