From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E00FA459C6; Wed, 18 Sep 2024 09:23:10 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AD7714029B; Wed, 18 Sep 2024 09:23:10 +0200 (CEST) Received: from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190]) by mails.dpdk.org (Postfix) with ESMTP id 300A24029B for ; Wed, 18 Sep 2024 09:23:09 +0200 (CEST) Received: from mail.maildlp.com (unknown [172.19.163.17]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4X7qqf0MMHz20p4X; Wed, 18 Sep 2024 15:22:54 +0800 (CST) Received: from dggpeml500024.china.huawei.com (unknown [7.185.36.10]) by mail.maildlp.com (Postfix) with ESMTPS id 882AC1A0188; Wed, 18 Sep 2024 15:23:07 +0800 (CST) Received: from [10.67.121.161] (10.67.121.161) by dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Wed, 18 Sep 2024 15:23:07 +0800 Message-ID: Date: Wed, 18 Sep 2024 15:23:07 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v23 06/15] eal: change rte_exit() output to match rte_log() To: Stephen Hemminger , CC: Tyler Retzlaff , =?UTF-8?Q?Morten_Br=C3=B8rup?= References: <20200814173441.23086-1-stephen@networkplumber.org> <20240918045830.3798-1-stephen@networkplumber.org> <20240918045830.3798-7-stephen@networkplumber.org> Content-Language: en-US From: fengchengwen In-Reply-To: <20240918045830.3798-7-stephen@networkplumber.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.121.161] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To dggpeml500024.china.huawei.com (7.185.36.10) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2024/9/18 12:56, Stephen Hemminger wrote: > The rte_exit() output format confuses the timestamp and coloring > options. Change it to use be a single line with proper prefix. > > Before: > [ 0.006481] EAL: Error - exiting with code: 1 > Cause: [ 0.006489] Cannot init EAL: Permission denied > > After: > [ 0.006238] EAL: Error - exiting with code: 1 > [ 0.006250] EAL: Cause - Cannot init EAL: Permission denied > > Signed-off-by: Stephen Hemminger > Acked-by: Tyler Retzlaff > Acked-by: Morten Brørup > --- > lib/eal/common/eal_common_debug.c | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/lib/eal/common/eal_common_debug.c b/lib/eal/common/eal_common_debug.c > index 3e77995896..ad2be63cbb 100644 > --- a/lib/eal/common/eal_common_debug.c > +++ b/lib/eal/common/eal_common_debug.c > @@ -34,17 +34,18 @@ void > rte_exit(int exit_code, const char *format, ...) > { > va_list ap; > + char msg[256]; the length maybe too short. > > if (exit_code != 0) > - RTE_LOG(CRIT, EAL, "Error - exiting with code: %d\n" > - " Cause: ", exit_code); > + EAL_LOG(CRIT, "Error - exiting with code: %d", exit_code); > > va_start(ap, format); > - rte_vlog(RTE_LOG_CRIT, RTE_LOGTYPE_EAL, format, ap); > + vsnprintf(msg, sizeof(msg), format, ap); should handle the vsnprintf return negative value. > va_end(ap); > > + rte_log(RTE_LOG_CRIT, RTE_LOGTYPE_EAL, "EAL: Cause - %s", msg); > + > if (rte_eal_cleanup() != 0 && rte_errno != EALREADY) > - EAL_LOG(CRIT, > - "EAL could not release all resources"); > + EAL_LOG(CRIT, "EAL could not release all resources"); > exit(exit_code); > }