From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 20C52F618 for ; Thu, 12 Jan 2017 15:44:33 +0100 (CET) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP; 12 Jan 2017 06:44:33 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,349,1477983600"; d="scan'208";a="29526033" Received: from rhorton-mobl.ger.corp.intel.com (HELO [10.252.14.42]) ([10.252.14.42]) by orsmga002.jf.intel.com with ESMTP; 12 Jan 2017 06:44:30 -0800 To: Thomas Monjalon , Reshma Pattan References: <1484150594-3758-1-git-send-email-remy.horton@intel.com> <1484150594-3758-5-git-send-email-remy.horton@intel.com> <8494765.8zaa745I9T@xps13> Cc: dev@dpdk.org, olivier.matz@6wind.com From: Remy Horton Organization: Intel Shannon Limited Message-ID: Date: Thu, 12 Jan 2017 14:44:29 +0000 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <8494765.8zaa745I9T@xps13> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v6 4/4] latencystats: added new library for latency stats X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Jan 2017 14:44:34 -0000 On 12/01/2017 13:41, Thomas Monjalon wrote: > 2017-01-12 00:03, Remy Horton: >> Add a library designed to calculate latency statistics and report them >> to the application when queried. The library measures minimum, average and >> maximum latencies, and jitter in nano seconds. The current implementation >> supports global latency stats, i.e. per application stats. > > Is it specific to ethdev ports? No (or at least not at the moment). >> Added new field to mbuf struct to mark the packet arrival time on Rx. > > There was another patch adding a timestamp in mbuf: > http://dpdk.org/ml/archives/dev/2016-October/048809.html Will look into it. Since time is tight will have internal discussion whether latency will make it into 17.02.. >> APIs: >> >> * Added APIs to initialize and un initialize latency stats >> calculation. >> * Added API to retrieve latency stats names and values. > > Why bitrate and latencies are separate libs? They were developed independently by different people in response to seperate requirements. Reshma went on extended leave, so I took over the latency patch at the last moment when development was complete. Aside from rebase-related fixups and one printf change it is the last version of her seperate patch included verbatim. ..Remy