From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 604F1A09FF; Mon, 11 Jan 2021 16:43:34 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D50BC140EF6; Mon, 11 Jan 2021 16:43:33 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 76FA7140EBA for ; Mon, 11 Jan 2021 16:43:32 +0100 (CET) IronPort-SDR: dg1vRhc2PhM5DoSIYv1UApgedw39AJSJzjFkgaxSFfpRUoe7gzATv4DbjspS5HuO4mV3Ca/hwM UhxHJdfQ437Q== X-IronPort-AV: E=McAfee;i="6000,8403,9860"; a="241954058" X-IronPort-AV: E=Sophos;i="5.79,338,1602572400"; d="scan'208";a="241954058" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jan 2021 07:43:29 -0800 IronPort-SDR: tXDIxMAGiSUwCoeGQUAb8fGsDpjS91fOz9EOWSGhzvNZ+/TyuAxEyxoQ4ifXGRKKXGXAemORzs pjK8Zl61i5IA== X-IronPort-AV: E=Sophos;i="5.79,338,1602572400"; d="scan'208";a="352645137" Received: from dwdohert-mobl.ger.corp.intel.com (HELO [10.213.207.99]) ([10.213.207.99]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jan 2021 07:43:28 -0800 To: Ciara Power , dev@dpdk.org Cc: akhil.goyal@nxp.com References: <20201211173114.1924772-1-ciara.power@intel.com> <20201211173114.1924772-3-ciara.power@intel.com> From: "Doherty, Declan" Message-ID: Date: Mon, 11 Jan 2021 15:43:23 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20201211173114.1924772-3-ciara.power@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 2/4] test/cryptodev: improve csv output for perf tests X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/12/2020 5:31 PM, Ciara Power wrote: > The csv outputs for performance tests were not easily consumed, due to > unnecessary whitespaces and capitals. The delimiter is modified to now > be "," instead of ";" which was present in some cases. Some unnecessary > values were also removed from the output. > > Signed-off-by: Ciara Power > --- > app/test-crypto-perf/cperf_test_latency.c | 13 +++++-------- > app/test-crypto-perf/cperf_test_throughput.c | 12 ++++++------ > 2 files changed, 11 insertions(+), 14 deletions(-) > > diff --git a/app/test-crypto-perf/cperf_test_latency.c b/app/test-crypto-perf/cperf_test_latency.c > index c2590a4dcf..f3c09b8c1c 100644 > --- a/app/test-crypto-perf/cperf_test_latency.c > +++ b/app/test-crypto-perf/cperf_test_latency.c > @@ -309,18 +309,15 @@ cperf_latency_test_runner(void *arg) > > if (ctx->options->csv) { > if (rte_atomic16_test_and_set(&display_once)) > - printf("\n# lcore, Buffer Size, Burst Size, Pakt Seq #, " > - "cycles, time (us)"); > + printf("\n#buffer_size(b),burst_size,time(us)"); > > for (i = 0; i < ctx->options->total_ops; i++) { > > - printf("\n%u;%u;%u;%"PRIu64";%"PRIu64";%.3f", > - ctx->lcore_id, ctx->options->test_buffer_size, > - test_burst_size, i + 1, > - ctx->res[i].tsc_end - ctx->res[i].tsc_start, > + printf("\n%u,%u,%.3f", > + ctx->options->test_buffer_size, > + test_burst_size, > tunit * (double) (ctx->res[i].tsc_end > - - ctx->res[i].tsc_start) > - / tsc_hz); > + - ctx->res[i].tsc_start) / tsc_hz); > > } > } else { > diff --git a/app/test-crypto-perf/cperf_test_throughput.c b/app/test-crypto-perf/cperf_test_throughput.c > index f30f7d5c2c..a841a890b9 100644 > --- a/app/test-crypto-perf/cperf_test_throughput.c > +++ b/app/test-crypto-perf/cperf_test_throughput.c > @@ -294,13 +294,13 @@ cperf_throughput_test_runner(void *test_ctx) > cycles_per_packet); > } else { > if (rte_atomic16_test_and_set(&display_once)) > - printf("#lcore id,Buffer Size(B)," > - "Burst Size,Enqueued,Dequeued,Failed Enq," > - "Failed Deq,Ops(Millions),Throughput(Gbps)," > - "Cycles/Buf\n\n"); > + printf("#lcore_id,buffer_size(b)," > + "burst_size,enqueued,dequeued,failed_enq," > + "failed_deq,ops(millions),throughput(gbps)," > + "cycles_per_buf\n\n"); > > - printf("%u;%u;%u;%"PRIu64";%"PRIu64";%"PRIu64";%"PRIu64";" > - "%.3f;%.3f;%.3f\n", > + printf("%u,%u,%u,%"PRIu64",%"PRIu64",%"PRIu64",%"PRIu64"," > + "%.3f,%.3f,%.3f\n", > ctx->lcore_id, > ctx->options->test_buffer_size, > test_burst_size, > I would suggest limiting the changes here to just fixing the delimiter here to being comma's instead of semi-colon's, that way it should be possible to make the python script support only versions of the output which wouldn't be possible if we change column names.