From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id C48512BD5 for ; Tue, 13 Nov 2018 11:21:51 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Nov 2018 02:21:50 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,498,1534834800"; d="scan'208";a="103946820" Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.252.9.8]) ([10.252.9.8]) by fmsmga002.fm.intel.com with ESMTP; 13 Nov 2018 02:21:49 -0800 To: Herakliusz Lipiec , dev@dpdk.org Cc: konstantin.ananyev@intel.com References: <20181112204650.7175-1-herakliusz.lipiec@intel.com> From: "Burakov, Anatoly" Message-ID: Date: Tue, 13 Nov 2018 10:21:49 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20181112204650.7175-1-herakliusz.lipiec@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] example/ipv4_multicast: fix app hanging when using clone X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Nov 2018 10:21:52 -0000 On 12-Nov-18 8:46 PM, Herakliusz Lipiec wrote: > This example was dropping packets when using clone (ip 224.0.0.103). > The problem was that mbufs were not freed. This was caused by coping > ol_flags from cloned mbuf to header mbufs. > > Signed-off-by: Herakliusz Lipiec > --- I agree with Thomas, needs clearer description. Suggest using some of the wording provided by Konstantin in later replies. Also, needs a Fixes: tag and a CC: stable, because it appears that this bug has been around for a few releases. -- Thanks, Anatoly