From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B1EC1A00D7; Thu, 31 Oct 2019 10:50:43 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 810381C1F4; Thu, 31 Oct 2019 10:50:43 +0100 (CET) Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by dpdk.org (Postfix) with ESMTP id B85971C1D2 for ; Thu, 31 Oct 2019 10:50:42 +0100 (CET) Received: by mail-wm1-f68.google.com with SMTP id x5so5179511wmi.0 for ; Thu, 31 Oct 2019 02:50:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=D38QW2Ctiemcqsvx6mPHW24DRiiFlN48bbzHmhOQjRQ=; b=Syq02qcJ36f7MFW+gmqDUizgMxaA4d3NNgQvN91EfuLBL7C6JtFaEye/PQm6GiwkCT MMTnZNC655oluOSwUUW37Kg39ac8Dwre/A00WUzsQlPAbceSuyzTRgCnTTwQ2+dekAeV cLqeeOipFI2x/Vvuc9v6W/vOtSZv7/WurO4w0lTnGk0wohwBvq/0vNaZDWh2MDv7W4BK IBO8bA5DTxxKjmoJqx6e8Z+vWkXd7q7nIcqmWvKyytRQ8bCZ8Cy6jCP3gXzYOcK1J1iX l+q9myZOzReyYQVIprn959T+1AsXRu0vpKVKHPWob7Cfk8oIhxVZ/WXYYThKTxhFBzt5 gT0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=D38QW2Ctiemcqsvx6mPHW24DRiiFlN48bbzHmhOQjRQ=; b=EuVZBW+3cFj9VyylSJNNhNDTyIspudtnAf+N8KuEKsoUL1P2p1BUkLmpo98eIGv4Uo vPoIM/Yqu+8FDap2Xo+ZDGwUMRbcwcwq0WQX1DcPNyeRjuoUTkTC7CM+tlmA5Bhvbs+1 NtAh3tiI7Bv5bBUIMP/QW3XlwTReUOWKQMSgZm23iwwuGH94f5uz22ALdrVSKrNBT2r4 kcXCts5x6CJ1o2pKYPqOHF0jIT/Sp7UOW8p0Y02aYlyynPLOu1+VHTktx2/Nb+d8I9JA hQjph3q3dnaKSWlJiBcnAbb2uk3ku2l8f4cjBBQbpmzSgM/y7TbgBxGaiaoxchog2r5j eKWQ== X-Gm-Message-State: APjAAAXqoGyrCgu8+1KPtgT/HF67QXjyp17/3K5q+q9QpT/ysOqFNKwu vJX69q1P+8TNz+fjH66E2nVc X-Google-Smtp-Source: APXvYqyysJ3o1gZQgxl76ngyjh32BYdn9Gy/vE1hxtlNWZEkAYLv80ooV4hrui5mq5IuddIGg/A7Og== X-Received: by 2002:a7b:c846:: with SMTP id c6mr4395554wml.68.1572515442183; Thu, 31 Oct 2019 02:50:42 -0700 (PDT) Received: from [10.16.0.208] (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id o1sm2468608wmc.38.2019.10.31.02.50.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 31 Oct 2019 02:50:41 -0700 (PDT) To: Gagandeep Singh , dev@dpdk.org, ferruh.yigit@intel.com Cc: thomas@monjalon.net References: <20191031071410.22632-1-g.singh@nxp.com> From: Thierry Herbelot Message-ID: Date: Thu, 31 Oct 2019 10:50:41 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20191031071410.22632-1-g.singh@nxp.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] mk: fix dpaax library dependency X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/31/19 8:14 AM, Gagandeep Singh wrote: > This patch fixes dpaax library dependency for > NXP's PMDs. > > Fixes: e56463ec47f0 ('net/enetc: enable dpaax library') > Fixes: 67fc3ff97c39 ('net/pfe: introduce basic functions') > Fixes: 9e727d4a3fd4 ('crypto/caam_jr: integrate DPAAX table') > > Suggested-by: Thierry Herbelot > Signed-off-by: Gagandeep Singh > --- > > The first suggested patch was > https://patchwork.dpdk.org/patch/62150/ , > which is not the right fix for this issue. > > This patch is a complete fix of compilation issues > because of NXP's PMDs. > > > drivers/net/pfe/meson.build | 2 +- > mk/rte.app.mk | 12 +++++++----- > 2 files changed, 8 insertions(+), 6 deletions(-) > > diff --git a/drivers/net/pfe/meson.build b/drivers/net/pfe/meson.build > index 799500b0a..678ce49a9 100644 > --- a/drivers/net/pfe/meson.build > +++ b/drivers/net/pfe/meson.build > @@ -4,7 +4,7 @@ > if host_machine.system() != 'linux' > build = false > endif > -deps += ['bus_dpaa'] > +deps += ['common_dpaax'] > > sources = files('pfe_ethdev.c', > 'pfe_hal.c', > diff --git a/mk/rte.app.mk b/mk/rte.app.mk > index 1f5c74841..4416caca7 100644 > --- a/mk/rte.app.mk > +++ b/mk/rte.app.mk > @@ -126,11 +126,13 @@ ifneq (,$(findstring y,$(MVEP-y))) > _LDLIBS-y += -lrte_common_mvep -L$(LIBMUSDK_PATH)/lib -lmusdk > endif > > -ifeq ($(CONFIG_RTE_LIBRTE_DPAA_BUS),y) > -_LDLIBS-$(CONFIG_RTE_LIBRTE_COMMON_DPAAX) += -lrte_common_dpaax > -endif > -ifeq ($(CONFIG_RTE_LIBRTE_FSLMC_BUS),y) > -_LDLIBS-$(CONFIG_RTE_LIBRTE_COMMON_DPAAX) += -lrte_common_dpaax > +DPAAX-y := $(CONFIG_RTE_LIBRTE_DPAA_BUS) > +DPAAX-y += $(CONFIG_RTE_LIBRTE_FSLMC_BUS) > +DPAAX-y += $(CONFIG_RTE_LIBRTE_ENETC_PMD) > +DPAAX-y += $(CONFIG_RTE_LIBRTE_PMD_CAAM_JR) > +DPAAX-y += $(CONFIG_RTE_LIBRTE_PFE_PMD) > +ifeq ($(findstring y,$(DPAAX-y)),y) > + _LDLIBS-y += -lrte_common_dpaax > endif > > _LDLIBS-$(CONFIG_RTE_LIBRTE_PCI_BUS) += -lrte_bus_pci > Acked-by: Thierry Herbelot -- Thierry Herbelot 6WIND Senior Software Engineer