From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9ACFDA0597; Thu, 9 Apr 2020 04:04:09 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4E4A71C0C9; Thu, 9 Apr 2020 04:04:09 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id A79231C0BF for ; Thu, 9 Apr 2020 04:04:07 +0200 (CEST) IronPort-SDR: rwQ3UDpvQQ67MKtKq88Km7eI5LG3Ml+5LXmnUTb3A8jz62LhhoKM3hhYqw6ubwtdY7lHUpP5g7 WSRIYBWlFyJQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Apr 2020 19:04:06 -0700 IronPort-SDR: X7bP6QROTt0pRge4rysp5J622m4dqmv6SYfrXc3pOP8ehPGjPEf6GUHRJZ6fFygoaevnnJVqOn +JRoOkq9/6bQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,360,1580803200"; d="scan'208";a="451819642" Received: from jguo15x-mobl.ccr.corp.intel.com (HELO [10.67.68.155]) ([10.67.68.155]) by fmsmga005.fm.intel.com with ESMTP; 08 Apr 2020 19:04:05 -0700 To: "Zhang, Qi Z" , "Iremonger, Bernard" , "Ye, Xiaolong" Cc: "dev@dpdk.org" , "Wu, Jingjing" , "Cao, Yahui" , "Su, Simei" References: <20200318170401.7938-5-jia.guo@intel.com> <20200326164039.36687-1-jia.guo@intel.com> <20200326164039.36687-2-jia.guo@intel.com> <039ED4275CED7440929022BC67E70611547F50D6@SHSMSX103.ccr.corp.intel.com> From: Jeff Guo Message-ID: Date: Thu, 9 Apr 2020 10:04:04 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <039ED4275CED7440929022BC67E70611547F50D6@SHSMSX103.ccr.corp.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Subject: Re: [dpdk-dev] [dpdk-dev v2 1/4] ethdev: add new RSS offload types X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Bernard and qi On 4/8/2020 8:15 AM, Zhang, Qi Z wrote: > >> -----Original Message----- >> From: Iremonger, Bernard >> Sent: Wednesday, April 8, 2020 1:02 AM >> To: Guo, Jia ; Ye, Xiaolong ; >> Zhang, Qi Z >> Cc: dev@dpdk.org; Wu, Jingjing ; Cao, Yahui >> ; Su, Simei ; Guo, Jia >> >> Subject: RE: [dpdk-dev] [dpdk-dev v2 1/4] ethdev: add new RSS offload types >> >> Hi Jeff, >> >>> -----Original Message----- >>> From: dev On Behalf Of Jeff Guo >>> Sent: Thursday, March 26, 2020 4:41 PM >>> To: Ye, Xiaolong ; Zhang, Qi Z >>> >>> Cc: dev@dpdk.org; Wu, Jingjing ; Cao, Yahui >>> ; Su, Simei ; Guo, Jia >>> >>> Subject: [dpdk-dev] [dpdk-dev v2 1/4] ethdev: add new RSS offload >>> types >>> >>> Defines some new RSS offload types for ETH/SVLAN/CVLAN/GTPU/L2TPV3/ >>> ESP/AH/PFCP. >>> >>> Signed-off-by: Jeff Guo >>> --- >>> v1: >>> 1.refine some rte eth rss offload types. >>> --- >>> lib/librte_ethdev/rte_ethdev.h | 11 ++++++++++- >>> 1 file changed, 10 insertions(+), 1 deletion(-) >>> >>> diff --git a/lib/librte_ethdev/rte_ethdev.h >>> b/lib/librte_ethdev/rte_ethdev.h index d1a593ad1..29cdf07cd 100644 >>> --- a/lib/librte_ethdev/rte_ethdev.h >>> +++ b/lib/librte_ethdev/rte_ethdev.h >>> @@ -511,6 +511,13 @@ struct rte_eth_rss_conf { >>> #define ETH_RSS_GENEVE (1ULL << 20) >>> #define ETH_RSS_NVGRE (1ULL << 21) >>> #define ETH_RSS_GTPU (1ULL << 23) >>> +#define ETH_RSS_ETH (1ULL << 24) >>> +#define ETH_RSS_S_VLAN (1ULL << 25) >>> +#define ETH_RSS_C_VLAN (1ULL << 26) >>> +#define ETH_RSS_IPSEC_ESP (1ULL << 27) >>> +#define ETH_RSS_IPSEC_AH (1ULL << 28) >> Is IPSEC needed in above ESP and AH macros? >> Would ETH_RSS_ESP and ETH_RSS_AH be sufficient ? > +1 It sounds good and sufficient, ESP identify the IP Encapsulating Security Payload  while AH means IP Authentication Header for IPsec, will modify it in next version. >>> +#define ETH_RSS_L2TPV3 (1ULL << 29) >>> +#define ETH_RSS_PFCP (1ULL << 30) >>> >>> /* >>> * We use the following macros to combine with above ETH_RSS_* for >> @@ >>> - >>> 524,7 +531,9 @@ struct rte_eth_rss_conf { >>> #define ETH_RSS_L3_SRC_ONLY (1ULL << 63) >>> #define ETH_RSS_L3_DST_ONLY (1ULL << 62) >>> #define ETH_RSS_L4_SRC_ONLY (1ULL << 61) >>> -#define ETH_RSS_L4_DST_ONLY (1ULL << 60) >>> +#define ETH_RSS_L4_DST_ONLY (1ULL << 60) >>> +#define ETH_RSS_ETH_SRC_ONLY (1ULL << 59) >>> +#define ETH_RSS_ETH_DST_ONLY (1ULL << 58) >>> >>> /** >>> * For input set change of hash filter, if SRC_ONLY and DST_ONLY of >>> -- >>> 2.20.1 >> Regards, >> >> Bernard.