DPDK patches and discussions
 help / color / Atom feed
From: "Di, ChenxuX" <chenxux.di@intel.com>
To: "Yang, Qiming" <qiming.yang@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Xing, Beilei" <beilei.xing@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2 4/5] net/i40e: enable flow query RSS
Date: Wed, 1 Jul 2020 01:15:59 +0000
Message-ID: <d780a700e8214fb691686bf865a3d4ae@intel.com> (raw)
In-Reply-To: <BN6PR11MB001760EED2AB5C82AED312F9E56F0@BN6PR11MB0017.namprd11.prod.outlook.com>

Hi,

> -----Original Message-----
> From: Yang, Qiming
> Sent: Tuesday, June 30, 2020 6:27 PM
> To: Di, ChenxuX <chenxux.di@intel.com>; dev@dpdk.org
> Cc: Xing, Beilei <beilei.xing@intel.com>
> Subject: RE: [PATCH v2 4/5] net/i40e: enable flow query RSS
> 
> 
> 
> > -----Original Message-----
> > From: Di, ChenxuX <chenxux.di@intel.com>
> > Sent: Monday, June 15, 2020 10:19
> > To: dev@dpdk.org
> > Cc: Xing, Beilei <beilei.xing@intel.com>; Yang, Qiming
> > <qiming.yang@intel.com>; Di, ChenxuX <chenxux.di@intel.com>
> > Subject: [PATCH v2 4/5] net/i40e: enable flow query RSS
> >
> > This patch enables flow query function to get the configuration ofthe
> > specified rule.
> >
> > Signed-off-by: Chenxu Di <chenxux.di@intel.com>
> > ---
> >  drivers/net/i40e/i40e_flow.c | 51
> > ++++++++++++++++++++++++++++++++++++
> >  1 file changed, 51 insertions(+)
> >
> > diff --git a/drivers/net/i40e/i40e_flow.c
> > b/drivers/net/i40e/i40e_flow.c index 8f8df6fae..b070802bd 100644
> > --- a/drivers/net/i40e/i40e_flow.c
> > +++ b/drivers/net/i40e/i40e_flow.c
> > @@ -43,6 +43,11 @@ static int i40e_flow_destroy(struct rte_eth_dev *dev,
> >       struct rte_flow_error *error);
> >  static int i40e_flow_flush(struct rte_eth_dev *dev,
> >     struct rte_flow_error *error);
> > +static int i40e_flow_query(struct rte_eth_dev *dev,
> > +   struct rte_flow *flow,
> > +   const struct rte_flow_action *actions,
> > +   void *data,
> > +   struct rte_flow_error *error);
> >  static int
> >  i40e_flow_parse_ethertype_pattern(struct rte_eth_dev *dev,
> >    const struct rte_flow_item *pattern, @@ -
> > 129,6 +134,7 @@ const struct rte_flow_ops i40e_flow_ops = {  .create =
> > i40e_flow_create,  .destroy = i40e_flow_destroy,  .flush =
> > i40e_flow_flush,
> > +.query = i40e_flow_query,
> >  };
> >
> >  static union i40e_filter_t cons_filter; @@ -5462,3 +5468,48 @@
> > i40e_flow_flush_rss_filter(struct rte_eth_dev *dev)
> >
> >  return ret;
> >  }
> > +
> > +static int
> > +i40e_flow_query(struct rte_eth_dev *dev __rte_unused, struct rte_flow
> > +*flow, const struct rte_flow_action *actions, void *data, struct
> > +rte_flow_error *error) { struct i40e_rss_filter *rss_rule = (struct
> > +i40e_rss_filter *)flow->rule; enum rte_filter_type filter_type =
> > +flow->filter_type; struct rte_flow_action_rss *rss_conf = data;
> > +
> > +if (!rss_rule) {
> > +rte_flow_error_set(error, EINVAL,
> > +   RTE_FLOW_ERROR_TYPE_HANDLE,
> > +   NULL, "Invalid rule");
> > +return -rte_errno;
> > +}
> > +
> > +for (; actions->type != RTE_FLOW_ACTION_TYPE_END; actions++) { switch
> > +(actions->type) { case RTE_FLOW_ACTION_TYPE_VOID:
> > +break;
> > +case RTE_FLOW_ACTION_TYPE_RSS:
> > +if (filter_type != RTE_ETH_FILTER_HASH) { rte_flow_error_set(error,
> > +ENOTSUP,
> > +
> > RTE_FLOW_ERROR_TYPE_ACTION,
> > +   actions,
> > +   "action not supported");
> > +return -rte_errno;
> > +}
> > +rte_memcpy(rss_conf,
> > +   &rss_rule->rss_filter_info.conf,
> > +   sizeof(struct rte_flow_action_rss));
> 
> Don't understand the behavior, what's action means? What's the things this
> commend query?
> 

By zhangqi's comment, it will query the configuration of rss rule.
It just return the config and display it.

> > +break;
> > +default:
> > +return rte_flow_error_set(error, ENOTSUP,
> > +
> > RTE_FLOW_ERROR_TYPE_ACTION,
> > +  actions,
> > +  "action not supported");
> > +}
> > +}
> > +
> > +return 0;
> > +}
> > --
> > 2.17.1
> 


  reply index

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-11  6:01 [dpdk-dev] [PATCH 0/5] re-implement legacy filter functions by private API Chenxu Di
2020-06-11  6:01 ` [dpdk-dev] [PATCH 1/5] net/i40e: add private APIs Chenxu Di
2020-06-11  6:01 ` [dpdk-dev] [PATCH 2/5] net/ixgbe: " Chenxu Di
2020-06-11  6:01 ` [dpdk-dev] [PATCH 3/5] app/testpmd: re-implement commands by using private API Chenxu Di
2020-06-16 20:12   ` Kevin Traynor
2020-06-17 10:12     ` Di, ChenxuX
2020-06-30  6:20       ` Jeff Guo
2020-06-11  6:01 ` [dpdk-dev] [PATCH 4/5] net/i40e: enable flow query RSS Chenxu Di
2020-06-11  6:01 ` [dpdk-dev] [PATCH 5/5] app/testpmd: support query RSS config in flow query Chenxu Di
2020-06-15  2:18 ` [dpdk-dev] [PATCH v2 0/5] re-implement legacy filter functions by private API Chenxu Di
2020-06-15  2:18   ` [dpdk-dev] [PATCH v2 1/5] net/i40e: add private APIs Chenxu Di
2020-06-30  4:22     ` Jeff Guo
2020-06-30 10:24     ` Yang, Qiming
2020-07-01  1:30       ` Di, ChenxuX
2020-06-15  2:18   ` [dpdk-dev] [PATCH v2 2/5] net/ixgbe: " Chenxu Di
2020-06-30  5:25     ` Jeff Guo
2020-06-30 10:25     ` Yang, Qiming
2020-06-15  2:18   ` [dpdk-dev] [PATCH v2 3/5] app/testpmd: re-implement commands by using private API Chenxu Di
2020-06-30 10:34     ` Yang, Qiming
2020-06-15  2:18   ` [dpdk-dev] [PATCH v2 4/5] net/i40e: enable flow query RSS Chenxu Di
2020-06-30  6:48     ` Jeff Guo
2020-06-30 10:27     ` Yang, Qiming
2020-07-01  1:15       ` Di, ChenxuX [this message]
2020-06-15  2:18   ` [dpdk-dev] [PATCH v2 5/5] app/testpmd: support query RSS config in flow query Chenxu Di
2020-06-30  6:37     ` Jeff Guo
2020-06-30 10:40     ` Yang, Qiming
2020-07-01  1:25       ` Di, ChenxuX
2020-07-01  8:24 ` [dpdk-dev] [PATCH v3 0/5] re-implement legacy filter functions by private API Chenxu Di
2020-07-01  8:24   ` [dpdk-dev] [PATCH v3 1/5] net/i40e: add private APIs Chenxu Di
2020-07-03  5:44     ` Jeff Guo
2020-07-01  8:24   ` [dpdk-dev] [PATCH v3 2/5] net/ixgbe: " Chenxu Di
2020-07-03  5:44     ` Jeff Guo
2020-07-01  8:24   ` [dpdk-dev] [PATCH v3 3/5] app/testpmd: re-implement commands by using private API Chenxu Di
2020-07-03  5:54     ` Jeff Guo
2020-07-06  9:10     ` Yang, Qiming
2020-07-01  8:24   ` [dpdk-dev] [PATCH v3 4/5] net/i40e: enable flow query RSS Chenxu Di
2020-07-03  5:57     ` Jeff Guo
2020-07-01  8:24   ` [dpdk-dev] [PATCH v3 5/5] app/testpmd: support query RSS config in flow query Chenxu Di
2020-07-08  1:18 ` [dpdk-dev] [PATCH v4 0/5] re-implement legacy filter functions by private API Chenxu Di
2020-07-08  1:18   ` [dpdk-dev] [PATCH v4 1/5] net/i40e: add private APIs Chenxu Di
2020-07-08  1:18   ` [dpdk-dev] [PATCH v4 2/5] net/ixgbe: " Chenxu Di
2020-07-08  1:18   ` [dpdk-dev] [PATCH v4 3/5] app/testpmd: re-implement commands by using private API Chenxu Di
2020-07-08  3:31     ` Yang, Qiming
2020-07-08  1:18   ` [dpdk-dev] [PATCH v4 4/5] net/i40e: enable flow query RSS Chenxu Di
2020-07-08  1:18   ` [dpdk-dev] [PATCH v4 5/5] app/testpmd: support query RSS config in flow query Chenxu Di
2020-07-08  3:32     ` Yang, Qiming
2020-07-08  9:05   ` [dpdk-dev] [PATCH v4 0/5] re-implement legacy filter functions by private API Zhang, Qi Z

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d780a700e8214fb691686bf865a3d4ae@intel.com \
    --to=chenxux.di@intel.com \
    --cc=beilei.xing@intel.com \
    --cc=dev@dpdk.org \
    --cc=qiming.yang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/ public-inbox