From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A6584A0563; Wed, 15 Apr 2020 11:47:15 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A48D91D57F; Wed, 15 Apr 2020 11:47:14 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id 33B041D579 for ; Wed, 15 Apr 2020 11:47:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1586944032; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=k1zhzbOcF1w55HerZuWTRLpdmwkXeec206RjdxoQI3Y=; b=WNhJ7IxD+Fw0JrZ2i6v06nfyjiH9vAFoUu1yWor2ocKubi5GvjxFChI5gjMnH2PMIqfIEH 3zLrcn9Qq7ZFVYtQU9+7Hc9T/II6PopYYnPaIt1uG1CX7x0UAgGszKn+GiImylpU8RyjEk gQQ2s2G2iBfI6NLwNRIfkVTnKKLquIc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-403-eF6Y6dgZPy6AaW9aipHCgQ-1; Wed, 15 Apr 2020 05:47:09 -0400 X-MC-Unique: eF6Y6dgZPy6AaW9aipHCgQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id CDFA4107ACC7; Wed, 15 Apr 2020 09:47:07 +0000 (UTC) Received: from [10.36.110.44] (unknown [10.36.110.44]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 44FEC1001B2B; Wed, 15 Apr 2020 09:47:06 +0000 (UTC) To: Asaf Penso , dev@dpdk.org Cc: Viacheslav Ovsiienko , Shahaf Shuler , Matan Azrad References: <1585059877-2369-1-git-send-email-asafp@mellanox.com> <1585059877-2369-3-git-send-email-asafp@mellanox.com> From: Maxime Coquelin Autocrypt: addr=maxime.coquelin@redhat.com; keydata= mQINBFOEQQIBEADjNLYZZqghYuWv1nlLisptPJp+TSxE/KuP7x47e1Gr5/oMDJ1OKNG8rlNg kLgBQUki3voWhUbMb69ybqdMUHOl21DGCj0BTU3lXwapYXOAnsh8q6RRM+deUpasyT+Jvf3a gU35dgZcomRh5HPmKMU4KfeA38cVUebsFec1HuJAWzOb/UdtQkYyZR4rbzw8SbsOemtMtwOx YdXodneQD7KuRU9IhJKiEfipwqk2pufm2VSGl570l5ANyWMA/XADNhcEXhpkZ1Iwj3TWO7XR uH4xfvPl8nBsLo/EbEI7fbuUULcAnHfowQslPUm6/yaGv6cT5160SPXT1t8U9QDO6aTSo59N jH519JS8oeKZB1n1eLDslCfBpIpWkW8ZElGkOGWAN0vmpLfdyiqBNNyS3eGAfMkJ6b1A24un /TKc6j2QxM0QK4yZGfAxDxtvDv9LFXec8ENJYsbiR6WHRHq7wXl/n8guyh5AuBNQ3LIK44x0 KjGXP1FJkUhUuruGyZsMrDLBRHYi+hhDAgRjqHgoXi5XGETA1PAiNBNnQwMf5aubt+mE2Q5r qLNTgwSo2dpTU3+mJ3y3KlsIfoaxYI7XNsPRXGnZi4hbxmeb2NSXgdCXhX3nELUNYm4ArKBP LugOIT/zRwk0H0+RVwL2zHdMO1Tht1UOFGfOZpvuBF60jhMzbQARAQABtCxNYXhpbWUgQ29x dWVsaW4gPG1heGltZS5jb3F1ZWxpbkByZWRoYXQuY29tPokCOAQTAQIAIgUCV3u/5QIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4AACgkQyjiNKEaHD4ma2g/+P+Hg9WkONPaY1J4AR7Uf kBneosS4NO3CRy0x4WYmUSLYMLx1I3VH6SVjqZ6uBoYy6Fs6TbF6SHNc7QbB6Qjo3neqnQR1 71Ua1MFvIob8vUEl3jAR/+oaE1UJKrxjWztpppQTukIk4oJOmXbL0nj3d8dA2QgHdTyttZ1H xzZJWWz6vqxCrUqHU7RSH9iWg9R2iuTzii4/vk1oi4Qz7y/q8ONOq6ffOy/t5xSZOMtZCspu Mll2Szzpc/trFO0pLH4LZZfz/nXh2uuUbk8qRIJBIjZH3ZQfACffgfNefLe2PxMqJZ8mFJXc RQO0ONZvwoOoHL6CcnFZp2i0P5ddduzwPdGsPq1bnIXnZqJSl3dUfh3xG5ArkliZ/++zGF1O wvpGvpIuOgLqjyCNNRoR7cP7y8F24gWE/HqJBXs1qzdj/5Hr68NVPV1Tu/l2D1KMOcL5sOrz 2jLXauqDWn1Okk9hkXAP7+0Cmi6QwAPuBT3i6t2e8UdtMtCE4sLesWS/XohnSFFscZR6Vaf3 gKdWiJ/fW64L6b9gjkWtHd4jAJBAIAx1JM6xcA1xMbAFsD8gA2oDBWogHGYcScY/4riDNKXi lw92d6IEHnSf6y7KJCKq8F+Jrj2BwRJiFKTJ6ChbOpyyR6nGTckzsLgday2KxBIyuh4w+hMq TGDSp2rmWGJjASq5Ag0EVPSbkwEQAMkaNc084Qvql+XW+wcUIY+Dn9A2D1gMr2BVwdSfVDN7 0ZYxo9PvSkzh6eQmnZNQtl8WSHl3VG3IEDQzsMQ2ftZn2sxjcCadexrQQv3Lu60Tgj7YVYRM H+fLYt9W5YuWduJ+FPLbjIKynBf6JCRMWr75QAOhhhaI0tsie3eDsKQBA0w7WCuPiZiheJaL 4MDe9hcH4rM3ybnRW7K2dLszWNhHVoYSFlZGYh+MGpuODeQKDS035+4H2rEWgg+iaOwqD7bg CQXwTZ1kSrm8NxIRVD3MBtzp9SZdUHLfmBl/tLVwDSZvHZhhvJHC6Lj6VL4jPXF5K2+Nn/Su CQmEBisOmwnXZhhu8ulAZ7S2tcl94DCo60ReheDoPBU8PR2TLg8rS5f9w6mLYarvQWL7cDtT d2eX3Z6TggfNINr/RTFrrAd7NHl5h3OnlXj7PQ1f0kfufduOeCQddJN4gsQfxo/qvWVB7PaE 1WTIggPmWS+Xxijk7xG6x9McTdmGhYaPZBpAxewK8ypl5+yubVsE9yOOhKMVo9DoVCjh5To5 aph7CQWfQsV7cd9PfSJjI2lXI0dhEXhQ7lRCFpf3V3mD6CyrhpcJpV6XVGjxJvGUale7+IOp sQIbPKUHpB2F+ZUPWds9yyVxGwDxD8WLqKKy0WLIjkkSsOb9UBNzgRyzrEC9lgQ/ABEBAAGJ Ah8EGAECAAkFAlT0m5MCGwwACgkQyjiNKEaHD4nU8hAAtt0xFJAy0sOWqSmyxTc7FUcX+pbD KVyPlpl6urKKMk1XtVMUPuae/+UwvIt0urk1mXi6DnrAN50TmQqvdjcPTQ6uoZ8zjgGeASZg jj0/bJGhgUr9U7oG7Hh2F8vzpOqZrdd65MRkxmc7bWj1k81tOU2woR/Gy8xLzi0k0KUa8ueB iYOcZcIGTcs9CssVwQjYaXRoeT65LJnTxYZif2pfNxfINFzCGw42s3EtZFteczClKcVSJ1+L +QUY/J24x0/ocQX/M1PwtZbB4c/2Pg/t5FS+s6UB1Ce08xsJDcwyOPIH6O3tccZuriHgvqKP yKz/Ble76+NFlTK1mpUlfM7PVhD5XzrDUEHWRTeTJSvJ8TIPL4uyfzhjHhlkCU0mw7Pscyxn DE8G0UYMEaNgaZap8dcGMYH/96EfE5s/nTX0M6MXV0yots7U2BDb4soLCxLOJz4tAFDtNFtA wLBhXRSvWhdBJZiig/9CG3dXmKfi2H+wdUCSvEFHRpgo7GK8/Kh3vGhgKmnnxhl8ACBaGy9n fxjSxjSO6rj4/MeenmlJw1yebzkX8ZmaSi8BHe+n6jTGEFNrbiOdWpJgc5yHIZZnwXaW54QT UhhSjDL1rV2B4F28w30jYmlRmm2RdN7iCZfbyP3dvFQTzQ4ySquuPkIGcOOHrvZzxbRjzMx1 Mwqu3GQ= Message-ID: Date: Wed, 15 Apr 2020 11:47:04 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <1585059877-2369-3-git-send-email-asafp@mellanox.com> Content-Language: en-US X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 2/4] vdpa/mlx5: support direct HW notifications X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 3/24/20 3:24 PM, Asaf Penso wrote: > From: Matan Azrad > > Add support for the next 2 callbacks: > get_vfio_device_fd and get_notify_area. > > This will allow direct HW doorbell ringing from guest and will save CPU > usage in host. > > By this patch, the QEMU will map the physical address of the virtio > device in guest directly to the physical address of the HW device > doorbell. > > The guest doorbell write is 2 bytes transaction while some Mellanox nics > support only 4 bytes transactions. > > Remove ConnectX-5 and BF1 devices support which don't support 2B > doorbell writes for HW triggering. Couldn't we have different rte_vdpa_dev_ops depending on whether doorbell write support? > Signed-off-by: Matan Azrad > Acked-by: Viacheslav Ovsiienko > --- > drivers/vdpa/mlx5/mlx5_vdpa.c | 74 ++++++++++++++++++++++++++++++++++++------- > drivers/vdpa/mlx5/mlx5_vdpa.h | 1 + > 2 files changed, 63 insertions(+), 12 deletions(-) > > diff --git a/drivers/vdpa/mlx5/mlx5_vdpa.c b/drivers/vdpa/mlx5/mlx5_vdpa.c > index 5542c29..4eb6abf 100644 > --- a/drivers/vdpa/mlx5/mlx5_vdpa.c > +++ b/drivers/vdpa/mlx5/mlx5_vdpa.c > @@ -133,6 +133,29 @@ > } > > static int > +mlx5_vdpa_direct_db_prepare(struct mlx5_vdpa_priv *priv) > +{ > + int ret; > + > + if (priv->direct_notifier) { > + ret = rte_vhost_host_notifier_ctrl(priv->vid, false); > + if (ret != 0) { > + DRV_LOG(INFO, "Direct HW notifier FD cannot be " > + "destroyed for device %d: %d.", priv->vid, ret); > + return -1; > + } > + priv->direct_notifier = 0; > + } > + ret = rte_vhost_host_notifier_ctrl(priv->vid, true); > + if (ret != 0) > + DRV_LOG(INFO, "Direct HW notifier FD cannot be configured for" > + " device %d: %d.", priv->vid, ret); > + else > + priv->direct_notifier = 1; > + return 0; > +} > + > +static int > mlx5_vdpa_features_set(int vid) > { > int did = rte_vhost_get_vdpa_device_id(vid); > @@ -209,8 +232,9 @@ > return -1; > } > priv->vid = vid; > - if (mlx5_vdpa_mem_register(priv) || mlx5_vdpa_virtqs_prepare(priv) || > - mlx5_vdpa_steer_setup(priv) || mlx5_vdpa_cqe_event_setup(priv)) { > + if (mlx5_vdpa_mem_register(priv) || mlx5_vdpa_direct_db_prepare(priv) || > + mlx5_vdpa_virtqs_prepare(priv) || mlx5_vdpa_steer_setup(priv) || > + mlx5_vdpa_cqe_event_setup(priv)) { > mlx5_vdpa_dev_close(vid); > return -1; > } > @@ -218,6 +242,40 @@ > return 0; > } > > +static int > +mlx5_vdpa_get_device_fd(int vid) > +{ > + int did = rte_vhost_get_vdpa_device_id(vid); > + struct mlx5_vdpa_priv *priv = mlx5_vdpa_find_priv_resource_by_did(did); > + > + if (priv == NULL) { > + DRV_LOG(ERR, "Invalid device id: %d.", did); > + return -EINVAL; > + } > + return priv->ctx->cmd_fd; > +} > + > +static int > +mlx5_vdpa_get_notify_area(int vid, int qid, uint64_t *offset, uint64_t *size) > +{ > + int did = rte_vhost_get_vdpa_device_id(vid); > + struct mlx5_vdpa_priv *priv = mlx5_vdpa_find_priv_resource_by_did(did); > + > + RTE_SET_USED(qid); > + if (priv == NULL) { > + DRV_LOG(ERR, "Invalid device id: %d.", did); > + return -EINVAL; > + } > + if (!priv->var) { > + DRV_LOG(ERR, "VAR was not created for device %d, is the device" > + " configured?.", did); > + return -EINVAL; > + } > + *offset = priv->var->mmap_off; > + *size = priv->var->length; > + return 0; > +} > + > static struct rte_vdpa_dev_ops mlx5_vdpa_ops = { > .get_queue_num = mlx5_vdpa_get_queue_num, > .get_features = mlx5_vdpa_get_vdpa_features, > @@ -228,8 +286,8 @@ > .set_features = mlx5_vdpa_features_set, > .migration_done = NULL, > .get_vfio_group_fd = NULL, > - .get_vfio_device_fd = NULL, > - .get_notify_area = NULL, > + .get_vfio_device_fd = mlx5_vdpa_get_device_fd, > + .get_notify_area = mlx5_vdpa_get_notify_area, > }; > > static struct ibv_device * > @@ -520,14 +578,6 @@ > static const struct rte_pci_id mlx5_vdpa_pci_id_map[] = { > { > RTE_PCI_DEVICE(PCI_VENDOR_ID_MELLANOX, > - PCI_DEVICE_ID_MELLANOX_CONNECTX5BF) > - }, > - { > - RTE_PCI_DEVICE(PCI_VENDOR_ID_MELLANOX, > - PCI_DEVICE_ID_MELLANOX_CONNECTX5BFVF) > - }, > - { > - RTE_PCI_DEVICE(PCI_VENDOR_ID_MELLANOX, > PCI_DEVICE_ID_MELLANOX_CONNECTX6) > }, > { > diff --git a/drivers/vdpa/mlx5/mlx5_vdpa.h b/drivers/vdpa/mlx5/mlx5_vdpa.h > index 3324c9d..75af410 100644 > --- a/drivers/vdpa/mlx5/mlx5_vdpa.h > +++ b/drivers/vdpa/mlx5/mlx5_vdpa.h > @@ -100,6 +100,7 @@ struct mlx5_vdpa_steer { > struct mlx5_vdpa_priv { > TAILQ_ENTRY(mlx5_vdpa_priv) next; > uint8_t configured; > + uint8_t direct_notifier; /* Whether direct notifier is on or off. */ > int id; /* vDPA device id. */ > int vid; /* vhost device id. */ > struct ibv_context *ctx; /* Device context. */ >