From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <jianfeng.tan@intel.com>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by dpdk.org (Postfix) with ESMTP id 4F11B316B
 for <dev@dpdk.org>; Thu, 13 Apr 2017 09:39:45 +0200 (CEST)
Received: from fmsmga004.fm.intel.com ([10.253.24.48])
 by orsmga105.jf.intel.com with ESMTP; 13 Apr 2017 00:39:44 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.37,194,1488873600"; d="scan'208";a="248088122"
Received: from shwdeisgchi083.ccr.corp.intel.com (HELO [10.239.67.194])
 ([10.239.67.194])
 by fmsmga004.fm.intel.com with ESMTP; 13 Apr 2017 00:39:35 -0700
To: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Cc: dev@dpdk.org, Maxime Coquelin <maxime.coquelin@redhat.com>
References: <1491551860-15005-1-git-send-email-jianfeng.tan@intel.com>
 <20170413015812.GE7333@yliu-dev.sh.intel.com>
 <5e7b5876-0f98-9c42-965e-e91b318cd17f@intel.com>
 <20170413023623.GH7333@yliu-dev.sh.intel.com>
From: "Tan, Jianfeng" <jianfeng.tan@intel.com>
Message-ID: <d7a27459-fe47-63eb-8963-e8c0c554d418@intel.com>
Date: Thu, 13 Apr 2017 15:39:34 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.0
MIME-Version: 1.0
In-Reply-To: <20170413023623.GH7333@yliu-dev.sh.intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Subject: Re: [dpdk-dev] [PATCH] net/virtio-user: fix cannot get initialized
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 13 Apr 2017 07:39:45 -0000



On 4/13/2017 10:36 AM, Yuanhan Liu wrote:
> On Thu, Apr 13, 2017 at 10:18:43AM +0800, Tan, Jianfeng wrote:
>>
>> On 4/13/2017 9:58 AM, Yuanhan Liu wrote:
>>> On Fri, Apr 07, 2017 at 07:57:40AM +0000, Jianfeng Tan wrote:
>>>> After the introduction of vhost MTU, VIRTIO_NET_F_MTU is enabled
>>>> by default.
> Actually, that's my point. The vhost lib just claim he supports MTU
> feature and MTU is not enabled by the virtio-user device.  Meaning,
> the MTU feature bit should not be set after the negoitation.
>
> You were seeing the bug because you found the bit is set, right?
> If so, that means the virtio-user feature negotiation is broken.

Make sense. Then I'll use a macro to define all supported features by 
virtio-user as a filter, so that any new features will be disabled in 
virtio-user.

Thanks,
Jianfeng