From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Jiawen Wu <jiawenwu@trustnetic.com>, dev@dpdk.org
Subject: Re: [PATCH v2 2/2] net/ngbe: disable LLDP by default
Date: Wed, 17 Jul 2024 11:22:51 +0100 [thread overview]
Message-ID: <d7aa17d5-a5a4-4399-ae2f-dc46caa97e84@amd.com> (raw)
In-Reply-To: <02f401dad7ef$1f1e5c90$5d5b15b0$@trustnetic.com>
On 7/17/2024 3:14 AM, Jiawen Wu wrote:
> On Tue, Jul 16, 2024 7:06 PM, Ferruh Yigit wrote:
>> On 7/16/2024 9:16 AM, Jiawen Wu wrote:
>>> --- a/drivers/net/ngbe/base/ngbe_hw.h
>>> +++ b/drivers/net/ngbe/base/ngbe_hw.h
>>> @@ -84,8 +84,8 @@ s32 ngbe_enable_rx_dma(struct ngbe_hw *hw, u32 regval);
>>> void ngbe_map_device_id(struct ngbe_hw *hw);
>>>
>>> void ngbe_read_efuse(struct ngbe_hw *hw);
>>> -u32 ngbe_fmgr_cmd_op(struct ngbe_hw *hw, u32 cmd, u32 cmd_addr);
>>> -u32 ngbe_flash_read_dword(struct ngbe_hw *hw, u32 addr);
>>> +s32 ngbe_fmgr_cmd_op(struct ngbe_hw *hw, u32 cmd, u32 cmd_addr);
>>> +s32 ngbe_flash_read_dword(struct ngbe_hw *hw, u32 addr, u32 *data);
>>> void ngbe_set_ncsi_status(struct ngbe_hw *hw);
>>>
>>
>> Hi Jiawen,
>>
>> Are above changes, and related changed caused by it, relevant to this
>> patch? Changes seems unrelated with main functionality of this patch.
>
> These changes are due to a flash read failure in the flow of disabling LLDP.
> For the sake of this case, change the original flash read function.
>
ack
next prev parent reply other threads:[~2024-07-17 10:23 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-18 7:11 [PATCH 00/19] Wangxun fixes and supports Jiawen Wu
2024-06-18 7:11 ` [PATCH 01/19] net/txgbe: fix to parse tunnel packets Jiawen Wu
2024-06-18 7:11 ` [PATCH 02/19] net/txgbe: fix flow filters in VT mode Jiawen Wu
2024-06-18 7:11 ` [PATCH 03/19] net/txgbe: fix Tx hang on queue disable Jiawen Wu
2024-06-18 7:11 ` [PATCH 04/19] net/txgbe: restrict the configuration of VLAN strip offload Jiawen Wu
2024-06-18 7:11 ` [PATCH 05/19] net/txgbe: reconfigure more MAC Rx registers Jiawen Wu
2024-06-18 7:11 ` [PATCH 06/19] net/txgbe: fix VF promiscuous and allmulticast Jiawen Wu
2024-06-18 7:11 ` [PATCH 07/19] net/ngbe: special config for YT8531SH-CA PHY Jiawen Wu
2024-06-18 7:11 ` [PATCH 08/19] net/ngbe: keep PHY power down while device probing Jiawen Wu
2024-06-18 7:11 ` [PATCH 09/19] net/ngbe: add WOL and NCSI capability Jiawen Wu
2024-06-18 7:11 ` [PATCH 10/19] net/txgbe: fix hotplug remove Jiawen Wu
2024-06-18 7:11 ` [PATCH 11/19] net/ngbe: " Jiawen Wu
2024-06-18 7:11 ` [PATCH 12/19] net/txgbe: correct valid MTU range Jiawen Wu
2024-06-18 7:11 ` [PATCH 13/19] net/ngbe: " Jiawen Wu
2024-06-18 7:11 ` [PATCH 14/19] net/txgbe: fix memory leak Jiawen Wu
2024-06-18 7:11 ` [PATCH 15/19] net/ngbe: " Jiawen Wu
2024-06-18 7:11 ` [PATCH 16/19] net/txgbe: fix Rx interrupt Jiawen Wu
2024-06-18 7:11 ` [PATCH 17/19] net/ngbe: support " Jiawen Wu
2024-06-18 7:11 ` [PATCH 18/19] net/txgbe: disable LLDP by default Jiawen Wu
2024-06-18 7:11 ` [PATCH 19/19] net/ngbe: " Jiawen Wu
2024-06-25 1:51 ` [PATCH 00/19] Wangxun fixes and supports Jiawen Wu
2024-07-05 8:11 ` Jiawen Wu
2024-07-06 3:39 ` Ferruh Yigit
2024-07-11 11:53 ` David Marchand
2024-07-12 9:32 ` David Marchand
2024-07-12 12:47 ` Ferruh Yigit
2024-07-12 15:30 ` Ferruh Yigit
2024-07-13 2:16 ` Jiawen Wu
2024-07-12 16:50 ` Thomas Monjalon
2024-07-16 8:16 ` [PATCH v2 1/2] net/txgbe: disable LLDP by default Jiawen Wu
2024-07-16 8:16 ` [PATCH v2 2/2] net/ngbe: " Jiawen Wu
2024-07-16 11:05 ` Ferruh Yigit
2024-07-17 2:14 ` Jiawen Wu
2024-07-17 10:22 ` Ferruh Yigit [this message]
2024-07-17 11:28 ` [PATCH v2 1/2] net/txgbe: " Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d7aa17d5-a5a4-4399-ae2f-dc46caa97e84@amd.com \
--to=ferruh.yigit@amd.com \
--cc=dev@dpdk.org \
--cc=jiawenwu@trustnetic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).