From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 8ED163253; Tue, 18 Jul 2017 10:24:00 +0200 (CEST) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Jul 2017 01:23:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,377,1496127600"; d="scan'208";a="126364369" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.255.134.81]) ([10.255.134.81]) by orsmga005.jf.intel.com with ESMTP; 18 Jul 2017 01:23:54 -0700 To: Andrew Rybchenko , dev@dpdk.org Cc: Ivan Malov , stable@dpdk.org References: <1499527015-31958-1-git-send-email-arybchenko@solarflare.com> From: Ferruh Yigit Message-ID: Date: Tue, 18 Jul 2017 09:23:51 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <1499527015-31958-1-git-send-email-arybchenko@solarflare.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] net/sfc: request MAC stats upload immediately on port start X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Jul 2017 08:24:01 -0000 On 7/8/2017 4:16 PM, Andrew Rybchenko wrote: > From: Ivan Malov > > If MAC stats refresh is arranged to be done by periodic DMA, > the first DMA transaction is unlikely to occur right on the > port start; if the user tries to get stats right after port > start and before the transaction occurs, bogus figures will > be collected; a one-off stats upload on port start is a fix > > Fixes: 1caab2f1e684 ("net/sfc: add basic statistics") > Cc: stable@dpdk.org > > Signed-off-by: Ivan Malov > Signed-off-by: Andrew Rybchenko Applied to dpdk-next-net/master, thanks. (Another column aligned commit log from Ivan :), thanks!)