* [dpdk-dev] [PATCH] net/i40e: remove redundant statement and braces
@ 2017-01-09 13:48 Yong Wang
2017-01-09 13:30 ` Ferruh Yigit
0 siblings, 1 reply; 3+ messages in thread
From: Yong Wang @ 2017-01-09 13:48 UTC (permalink / raw)
To: helin.zhang, jingjing.wu; +Cc: dev, Yong Wang
In function "reassemble_packets()", the statement "end = secondlast;"
is redundant since there is another assignment "start = end = NULL;"
3 lines below. BTW, I removed the redundant braces in the conditional
statement "if (end->data_len > rxq->crc_len)".
Signed-off-by: Yong Wang <wang.yong19@zte.com.cn>
---
drivers/net/i40e/i40e_rxtx_vec_common.h | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/net/i40e/i40e_rxtx_vec_common.h b/drivers/net/i40e/i40e_rxtx_vec_common.h
index 6cb5dce..02d834a 100644
--- a/drivers/net/i40e/i40e_rxtx_vec_common.h
+++ b/drivers/net/i40e/i40e_rxtx_vec_common.h
@@ -65,9 +65,9 @@
start->ol_flags = end->ol_flags;
/* we need to strip crc for the whole packet */
start->pkt_len -= rxq->crc_len;
- if (end->data_len > rxq->crc_len) {
+ if (end->data_len > rxq->crc_len)
end->data_len -= rxq->crc_len;
- } else {
+ else {
/* free up last mbuf */
struct rte_mbuf *secondlast = start;
@@ -77,7 +77,6 @@
end->data_len);
secondlast->next = NULL;
rte_pktmbuf_free_seg(end);
- end = secondlast;
}
pkts[pkt_idx++] = start;
start = end = NULL;
--
1.8.3.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] net/i40e: remove redundant statement and braces
2017-01-09 13:48 [dpdk-dev] [PATCH] net/i40e: remove redundant statement and braces Yong Wang
@ 2017-01-09 13:30 ` Ferruh Yigit
2017-01-09 13:31 ` Ferruh Yigit
0 siblings, 1 reply; 3+ messages in thread
From: Ferruh Yigit @ 2017-01-09 13:30 UTC (permalink / raw)
To: Yong Wang, helin.zhang, jingjing.wu; +Cc: dev
On 1/9/2017 1:48 PM, Yong Wang wrote:
> In function "reassemble_packets()", the statement "end = secondlast;"
> is redundant since there is another assignment "start = end = NULL;"
> 3 lines below. BTW, I removed the redundant braces in the conditional
> statement "if (end->data_len > rxq->crc_len)".
>
> Signed-off-by: Yong Wang <wang.yong19@zte.com.cn>
Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] net/i40e: remove redundant statement and braces
2017-01-09 13:30 ` Ferruh Yigit
@ 2017-01-09 13:31 ` Ferruh Yigit
0 siblings, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2017-01-09 13:31 UTC (permalink / raw)
To: Yong Wang, helin.zhang, jingjing.wu; +Cc: dev
On 1/9/2017 1:30 PM, Ferruh Yigit wrote:
> On 1/9/2017 1:48 PM, Yong Wang wrote:
>> In function "reassemble_packets()", the statement "end = secondlast;"
>> is redundant since there is another assignment "start = end = NULL;"
>> 3 lines below. BTW, I removed the redundant braces in the conditional
>> statement "if (end->data_len > rxq->crc_len)".
>>
>> Signed-off-by: Yong Wang <wang.yong19@zte.com.cn>
>
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-01-09 13:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-09 13:48 [dpdk-dev] [PATCH] net/i40e: remove redundant statement and braces Yong Wang
2017-01-09 13:30 ` Ferruh Yigit
2017-01-09 13:31 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).