From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f65.google.com (mail-pg0-f65.google.com [74.125.83.65]) by dpdk.org (Postfix) with ESMTP id 1D07C1B1EF for ; Thu, 9 Nov 2017 05:45:33 +0100 (CET) Received: by mail-pg0-f65.google.com with SMTP id l19so1211904pgo.2 for ; Wed, 08 Nov 2017 20:45:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=rTaP2td4AlWxVz8T0T/jwokZ0kXDfDV1TIj2QFJ0pk4=; b=L0prufyOLof5ajzU87+0EWLfy1yxtQN/CR82LKY0hB6O9Gq4WasxdWUBYgrZ7WNnbV cpulNPnqeK1r3bQAhvOsUoufX9r9zzndysN9a+s3x+a9AQWueJpfgQwVIh4MbS6f83WZ ktEEYCWxuEQOaql4QM2o9esckIJsElhBAxOOXZTM74vUQMiIhwdoG4YFnfUOkBPpqJvJ 7G/QtUuUxPyA6X+MgtE59nbz3uJTUhq1npnM/quFiGXUhsVf1lg5ItHFir9dAKby13m7 Ip27/k/Sxsg5YYj7pOj5epeZlkmKZMEqhcidul1uqcHsjYhYOYkKuDKppfO/UGq1mBrT If+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=rTaP2td4AlWxVz8T0T/jwokZ0kXDfDV1TIj2QFJ0pk4=; b=QrTNai5Zv3LNYFB0ZrgOUilsPIsy/zPoVs8Q/g3JxnUy9ojBbYTAnXGJQvJx4O8lWO bpr2QIRN5sE0UgGXYAe0LsDKUJVxYUDpk+BWwjZgWxt/jw1VgrroJWu9EzhkFvyUuu83 jsouXV22QDBkFUHLnjKU3ZFhhDza18yHQArg6jA2sZHyq77YwyidguXdhr2fGQZGj56V JAVUudoEjM4EpjTt8EPnqDYX6nk6DriAstpQhVt/EoekMFjWXQRExrwBc1Sr+KGKzSPG sIbRMtRaRe1aez/lMtAIK5p6axjU5SuPylYecsDi727316VH+r43jnxeWftnaOXDd+z1 LA6A== X-Gm-Message-State: AJaThX5+yZsv/NJyxXHrokns/F/sNrm8yb33qTm+68S6uHJeuZIArXkf qm8BDWQQj8oKsNeKicOb8jUFLqSP X-Google-Smtp-Source: ABhQp+Q4dh6dk0ri+KurxXJEg0AqrynAtbCv8rzOxLrrAR2Qld2cAz0X5XPVMuC3YjdXZYsl+sEXsw== X-Received: by 10.101.67.73 with SMTP id k9mr2639686pgq.188.1510202732226; Wed, 08 Nov 2017 20:45:32 -0800 (PST) Received: from [0.0.0.0] (67.209.179.165.16clouds.com. [67.209.179.165]) by smtp.gmail.com with ESMTPSA id 9sm8591950pgg.42.2017.11.08.20.43.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 08 Nov 2017 20:45:31 -0800 (PST) To: Jianbo Liu Cc: Bruce Richardson , jerin.jacob@caviumnetworks.com, dev@dpdk.org, olivier.matz@6wind.com, konstantin.ananyev@intel.com, hemant.agrawal@nxp.com, jia.he@hxt-semitech.com References: <1510121832-16439-1-git-send-email-hejianet@gmail.com> <20171108102814.GA7552@bricha3-MOBL3.ger.corp.intel.com> <9086316b-c16b-c42b-2d85-9b01fa2f66e1@gmail.com> <028263d0-44de-bd0c-c495-081588a0ad20@gmail.com> <20171109032145.GA26939@arm.com> From: Jia He Message-ID: Date: Thu, 9 Nov 2017 12:43:20 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171109032145.GA26939@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 1/3] eal/arm64: remove the braces {} for dmb(), dsb() X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Nov 2017 04:45:33 -0000 Hi Jianbo On 11/9/2017 11:21 AM, Jianbo Liu Wrote: > The 11/09/2017 11:14, Jia He wrote: >> >> On 11/9/2017 9:22 AM, Jia He Wrote: >>> Hi Bruce >>> >>> >>> On 11/8/2017 6:28 PM, Bruce Richardson Wrote: >>>> On Wed, Nov 08, 2017 at 06:17:10AM +0000, Jia He wrote: >>>>> for the code as follows: >>>>> if (condition) >>>>>     rte_smp_rmb(); >>>>> else >>>>>     rte_smp_wmb(); >>>>> Without this patch, compiler will report this error: >>>>> error: 'else' without a previous 'if' >>>>> >>>>> Signed-off-by: Jia He >>>>> Signed-off-by: jia.he@hxt-semitech.com >>>>> --- >>>>>   lib/librte_eal/common/include/arch/arm/rte_atomic_64.h | 4 ++-- >>>>>   1 file changed, 2 insertions(+), 2 deletions(-) >>>>> >>>>> diff --git >>>>> a/lib/librte_eal/common/include/arch/arm/rte_atomic_64.h >>>>> b/lib/librte_eal/common/include/arch/arm/rte_atomic_64.h >>>>> index 0b70d62..38c3393 100644 >>>>> --- a/lib/librte_eal/common/include/arch/arm/rte_atomic_64.h >>>>> +++ b/lib/librte_eal/common/include/arch/arm/rte_atomic_64.h >>>>> @@ -43,8 +43,8 @@ extern "C" { >>>>>   #include "generic/rte_atomic.h" >>>>>   -#define dsb(opt) { asm volatile("dsb " #opt : : : "memory"); } >>>>> -#define dmb(opt) { asm volatile("dmb " #opt : : : "memory"); } >>>>> +#define dsb(opt) asm volatile("dsb " #opt : : : "memory"); >>>>> +#define dmb(opt) asm volatile("dmb " #opt : : : "memory"); >>>> Need to remove the trailing ";" I too I think. >>>> Alternatively, to keep the braces, the standard practice is to use >>>> do { ... } while(0) >>> If trailing ";" is not removed >>> the code: >>> if (condition) >>>     rte_smp_rmb(); >>> else >>>     anything(); >>> > Sorry, why not use two different functions as your conditions passed in > are fixed in the calling functions. Do you mean to split update_tail() into update_tail_enqueue() and update_tail_dequeue()? Cheers, Jia